From d716e30e60f1d1bf0a25463e44d98ab406f99849 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maximilian=20Kr=C3=B6g?= Date: Thu, 20 Jul 2023 00:47:53 +0200 Subject: [PATCH] Change deprecated ReflectionProperty method call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Is being deprecated in PHP 8.3 Signed-off-by: Maximilian Krög --- test/classes/AbstractNetworkTestCase.php | 4 ++-- test/classes/ConfigStorage/RelationTest.php | 2 +- .../Controllers/Server/VariablesControllerTest.php | 6 +++--- test/classes/ErrorHandlerTest.php | 8 ++++---- test/classes/InsertEditTest.php | 10 +++++----- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/test/classes/AbstractNetworkTestCase.php b/test/classes/AbstractNetworkTestCase.php index db7838b464..c00075fc5b 100644 --- a/test/classes/AbstractNetworkTestCase.php +++ b/test/classes/AbstractNetworkTestCase.php @@ -90,7 +90,7 @@ abstract class AbstractNetworkTestCase extends AbstractTestCase $attrInstance = new ReflectionProperty(ResponseRenderer::class, 'instance'); $attrInstance->setAccessible(true); - $attrInstance->setValue($mockResponse); + $attrInstance->setValue(null, $mockResponse); return $mockResponse; } @@ -103,7 +103,7 @@ abstract class AbstractNetworkTestCase extends AbstractTestCase parent::tearDown(); $response = new ReflectionProperty(ResponseRenderer::class, 'instance'); $response->setAccessible(true); - $response->setValue(null); + $response->setValue(null, null); $response->setAccessible(false); } } diff --git a/test/classes/ConfigStorage/RelationTest.php b/test/classes/ConfigStorage/RelationTest.php index f42db9225e..b202f374b5 100644 --- a/test/classes/ConfigStorage/RelationTest.php +++ b/test/classes/ConfigStorage/RelationTest.php @@ -1974,7 +1974,7 @@ class RelationTest extends AbstractTestCase $_SESSION['tmpval'] = []; $recentFavoriteTableInstances = (new ReflectionClass(RecentFavoriteTable::class))->getProperty('instances'); $recentFavoriteTableInstances->setAccessible(true); - $recentFavoriteTableInstances->setValue([]); + $recentFavoriteTableInstances->setValue(null, []); $relation = new Relation($this->dbi); $relation->initRelationParamsCache(); diff --git a/test/classes/Controllers/Server/VariablesControllerTest.php b/test/classes/Controllers/Server/VariablesControllerTest.php index be8f53034e..0347eb3da7 100644 --- a/test/classes/Controllers/Server/VariablesControllerTest.php +++ b/test/classes/Controllers/Server/VariablesControllerTest.php @@ -153,7 +153,7 @@ class VariablesControllerTest extends AbstractTestCase $response = new ReflectionProperty(ServerVariablesProvider::class, 'instance'); $response->setAccessible(true); - $response->setValue($voidProviderMock); + $response->setValue(null, $voidProviderMock); [$formattedValue, $isHtmlFormatted] = $this->callFunction( $controller, @@ -205,7 +205,7 @@ class VariablesControllerTest extends AbstractTestCase $response = new ReflectionProperty(ServerVariablesProvider::class, 'instance'); $response->setAccessible(true); - $response->setValue(null); + $response->setValue(null, null); $controller = new VariablesController(ResponseRenderer::getInstance(), new Template(), $GLOBALS['dbi']); @@ -264,7 +264,7 @@ class VariablesControllerTest extends AbstractTestCase { $response = new ReflectionProperty(ServerVariablesProvider::class, 'instance'); $response->setAccessible(true); - $response->setValue(new ServerVariablesVoidProvider()); + $response->setValue(null, new ServerVariablesVoidProvider()); $controller = new VariablesController(ResponseRenderer::getInstance(), new Template(), $GLOBALS['dbi']); diff --git a/test/classes/ErrorHandlerTest.php b/test/classes/ErrorHandlerTest.php index 09ddce5d1b..23b4bbfb28 100644 --- a/test/classes/ErrorHandlerTest.php +++ b/test/classes/ErrorHandlerTest.php @@ -321,7 +321,7 @@ class ErrorHandlerTest extends AbstractTestCase $responseStub = new ResponseRendererStub(); $property = new ReflectionProperty(ResponseRenderer::class, 'instance'); $property->setAccessible(true); - $property->setValue($responseStub); + $property->setValue(null, $responseStub); $responseStub->setHeadersSent(true); $errorHandler = new ErrorHandler(); $this->assertSame([], $errorHandler->getCurrentErrors()); @@ -347,7 +347,7 @@ class ErrorHandlerTest extends AbstractTestCase $responseStub = new ResponseRendererStub(); $property = new ReflectionProperty(ResponseRenderer::class, 'instance'); $property->setAccessible(true); - $property->setValue($responseStub); + $property->setValue(null, $responseStub); $responseStub->setHeadersSent(true); $errorHandler = new ErrorHandler(); $this->assertSame([], $errorHandler->getCurrentErrors()); @@ -373,7 +373,7 @@ class ErrorHandlerTest extends AbstractTestCase $responseStub = new ResponseRendererStub(); $property = new ReflectionProperty(ResponseRenderer::class, 'instance'); $property->setAccessible(true); - $property->setValue($responseStub); + $property->setValue(null, $responseStub); $responseStub->setHeadersSent(true); $errorHandler = new ErrorHandler(); $errorHandler->addError('Fatal error message!', E_ERROR, './file/name', 1); @@ -399,7 +399,7 @@ HTML; $responseStub = new ResponseRendererStub(); $property = new ReflectionProperty(ResponseRenderer::class, 'instance'); $property->setAccessible(true); - $property->setValue($responseStub); + $property->setValue(null, $responseStub); $responseStub->setHeadersSent(false); $errorHandler = new ErrorHandler(); $errorHandler->addError('Fatal error message!', E_ERROR, './file/name', 1); diff --git a/test/classes/InsertEditTest.php b/test/classes/InsertEditTest.php index b58d81066b..e6dd33c73c 100644 --- a/test/classes/InsertEditTest.php +++ b/test/classes/InsertEditTest.php @@ -95,7 +95,7 @@ class InsertEditTest extends AbstractTestCase parent::tearDown(); $response = new ReflectionProperty(ResponseRenderer::class, 'instance'); $response->setAccessible(true); - $response->setValue(null); + $response->setValue(null, null); $response->setAccessible(false); } @@ -331,7 +331,7 @@ class InsertEditTest extends AbstractTestCase $restoreInstance = ResponseRenderer::getInstance(); $response = new ReflectionProperty(ResponseRenderer::class, 'instance'); $response->setAccessible(true); - $response->setValue($responseMock); + $response->setValue(null, $responseMock); $result = $this->callFunction( $this->insertEdit, @@ -346,7 +346,7 @@ class InsertEditTest extends AbstractTestCase ] ); - $response->setValue($restoreInstance); + $response->setValue(null, $restoreInstance); $this->assertFalse($result); } @@ -2863,7 +2863,7 @@ class InsertEditTest extends AbstractTestCase $restoreInstance = ResponseRenderer::getInstance(); $response = new ReflectionProperty(ResponseRenderer::class, 'instance'); $response->setAccessible(true); - $response->setValue($responseMock); + $response->setValue(null, $responseMock); $this->insertEdit = new InsertEdit($dbi); @@ -2890,7 +2890,7 @@ class InsertEditTest extends AbstractTestCase $result = $this->insertEdit->determineInsertOrEdit(null, 'db', 'table'); - $response->setValue($restoreInstance); + $response->setValue(null, $restoreInstance); $this->assertEquals( [