From 582b02262bcda6edb10ffc6df1b67c47468bbe59 Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Thu, 4 Sep 2014 05:43:02 -0400 Subject: [PATCH] Remove Overhead from Server > Databases > Enable Statistics. We cannot show correct results in the case of InnoDB tables. Signed-off-by: Marc Delisle --- libraries/build_html_for_db.lib.php | 8 +++----- test/libraries/PMA_build_html_for_db_test.php | 5 ----- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/libraries/build_html_for_db.lib.php b/libraries/build_html_for_db.lib.php index 694e916b55..c4662e69b5 100644 --- a/libraries/build_html_for_db.lib.php +++ b/libraries/build_html_for_db.lib.php @@ -49,11 +49,9 @@ function PMA_getColumnOrder() 'format' => 'byte', 'footer' => 0, ); - $column_order['SCHEMA_DATA_FREE'] = array( - 'disp_name' => __('Overhead'), - 'format' => 'byte', - 'footer' => 0, - ); + // At this point we were preparing the display of Overhead using DATA_FREE + // but its content does not represent the real overhead in the case + // of InnoDB return $column_order; } diff --git a/test/libraries/PMA_build_html_for_db_test.php b/test/libraries/PMA_build_html_for_db_test.php index c614d1eaf8..4e30b33430 100644 --- a/test/libraries/PMA_build_html_for_db_test.php +++ b/test/libraries/PMA_build_html_for_db_test.php @@ -90,11 +90,6 @@ class PMA_BuildHtmlForDb_Test extends PHPUnit_Framework_TestCase 'disp_name' => __('Total'), 'format' => 'byte', 'footer' => 0 - ), - 'SCHEMA_DATA_FREE' => array( - 'disp_name' => __('Overhead'), - 'format' => 'byte', - 'footer' => 0 ) ), PMA_getColumnOrder()