diff --git a/PMAStandard/ruleset.xml b/PMAStandard/ruleset.xml index e46b001ba6..6974ec640a 100644 --- a/PMAStandard/ruleset.xml +++ b/PMAStandard/ruleset.xml @@ -3,12 +3,7 @@ phpMyAdmin custom coding standard - - - - - - + diff --git a/libraries/DbQbe.php b/libraries/DbQbe.php index 7d1b637b17..1e18dc9132 100644 --- a/libraries/DbQbe.php +++ b/libraries/DbQbe.php @@ -7,10 +7,6 @@ */ namespace PMA\libraries; -if (! defined('PHPMYADMIN')) { - exit; -} - /** * Class to handle database QBE search * diff --git a/libraries/advisor.lib.php b/libraries/advisor.lib.php index ad4ac92ecd..cacd296309 100644 --- a/libraries/advisor.lib.php +++ b/libraries/advisor.lib.php @@ -5,9 +5,6 @@ * * @package PhpMyAdmin */ -if (! defined('PHPMYADMIN')) { - exit; -} /** * Formats interval like 10 per hour diff --git a/libraries/autoloader.php b/libraries/autoloader.php index 563e7afa13..8497005133 100644 --- a/libraries/autoloader.php +++ b/libraries/autoloader.php @@ -1,7 +1,6 @@ 'SELECT 1', 'result' => array(array('1'))), array( - 'query' => 'SELECT CURRENT_USER();', + 'query' => 'SELECT CURRENT_USER();', 'result' => array(array('pma_test@localhost')), ), array( - 'query' => "SHOW VARIABLES LIKE 'lower_case_table_names'", - 'result' => array(array('lower_case_table_names', '1')) + 'query' => "SHOW VARIABLES LIKE 'lower_case_table_names'", + 'result' => array(array('lower_case_table_names', '1')), ), array( - 'query' => 'SELECT 1 FROM mysql.user LIMIT 1', + 'query' => 'SELECT 1 FROM mysql.user LIMIT 1', 'result' => array(array('1')), ), array( - 'query' => "SELECT 1 FROM `INFORMATION_SCHEMA`.`USER_PRIVILEGES`" + 'query' => "SELECT 1 FROM `INFORMATION_SCHEMA`.`USER_PRIVILEGES`" . " WHERE `PRIVILEGE_TYPE` = 'CREATE USER'" . " AND '''pma_test''@''localhost''' LIKE `GRANTEE` LIMIT 1", 'result' => array(array('1')), ), array( - 'query' => "SELECT 1 FROM (SELECT `GRANTEE`, `IS_GRANTABLE`" + 'query' => "SELECT 1 FROM (SELECT `GRANTEE`, `IS_GRANTABLE`" . " FROM `INFORMATION_SCHEMA`.`COLUMN_PRIVILEGES`" . " UNION SELECT `GRANTEE`, `IS_GRANTABLE`" . " FROM `INFORMATION_SCHEMA`.`TABLE_PRIVILEGES`" @@ -53,31 +53,31 @@ $GLOBALS['dummy_queries'] = array( 'result' => array(array('1')), ), array( - 'query' => 'SHOW MASTER LOGS', + 'query' => 'SHOW MASTER LOGS', 'result' => false, ), array( - 'query' => 'SHOW STORAGE ENGINES', + 'query' => 'SHOW STORAGE ENGINES', 'result' => array( array( - 'Engine' => 'dummy', + 'Engine' => 'dummy', 'Support' => 'YES', - 'Comment' => 'dummy comment' + 'Comment' => 'dummy comment', ), array( - 'Engine' => 'dummy2', + 'Engine' => 'dummy2', 'Support' => 'NO', - 'Comment' => 'dummy2 comment' + 'Comment' => 'dummy2 comment', ), array( - 'Engine' => 'FEDERATED', + 'Engine' => 'FEDERATED', 'Support' => 'NO', - 'Comment' => 'Federated MySQL storage engine' + 'Comment' => 'Federated MySQL storage engine', ), - ) + ), ), array( - 'query' => 'SHOW STATUS WHERE Variable_name' + 'query' => 'SHOW STATUS WHERE Variable_name' . ' LIKE \'Innodb\\_buffer\\_pool\\_%\'' . ' OR Variable_name = \'Innodb_page_size\';', 'result' => array( @@ -95,141 +95,176 @@ $GLOBALS['dummy_queries'] = array( array('Innodb_buffer_pool_wait_free', 0), array('Innodb_buffer_pool_write_requests', 64), array('Innodb_page_size', 16384), - ) + ), ), array( - 'query' => 'SHOW ENGINE INNODB STATUS;', + 'query' => 'SHOW ENGINE INNODB STATUS;', 'result' => false, ), array( - 'query' => 'SELECT @@innodb_version;', + 'query' => 'SELECT @@innodb_version;', 'result' => array( array('1.1.8'), - ) - ), - array( - 'query' => 'SELECT @@disabled_storage_engines', - 'result' => array( - array(''), - ) - ), - array( - 'query' => 'SHOW GLOBAL VARIABLES LIKE \'innodb_file_per_table\';', - 'result' => array( - array('innodb_file_per_table', 'OFF'), - ) - ), - array( - 'query' => 'SHOW GLOBAL VARIABLES LIKE \'innodb_file_format\';', - 'result' => array( - array('innodb_file_format', 'Antelope'), - ) - ), - array( - 'query' => 'SELECT @@collation_server', - 'result' => array( - array('utf8_general_ci'), - ) - ), - array( - 'query' => 'SELECT @@lc_messages;', - 'result' => array(), - ), - array( - 'query' => 'SHOW SESSION VARIABLES LIKE \'FOREIGN_KEY_CHECKS\';', - 'result' => array( - array('foreign_key_checks', 'ON') ), ), array( - 'query' => 'SHOW TABLES FROM `pma_test`;', + 'query' => 'SELECT @@disabled_storage_engines', + 'result' => array( + array(''), + ), + ), + array( + 'query' => 'SHOW GLOBAL VARIABLES LIKE \'innodb_file_per_table\';', + 'result' => array( + array('innodb_file_per_table', 'OFF'), + ), + ), + array( + 'query' => 'SHOW GLOBAL VARIABLES LIKE \'innodb_file_format\';', + 'result' => array( + array('innodb_file_format', 'Antelope'), + ), + ), + array( + 'query' => 'SELECT @@collation_server', + 'result' => array( + array('utf8_general_ci'), + ), + ), + array( + 'query' => 'SELECT @@lc_messages;', + 'result' => array(), + ), + array( + 'query' => 'SHOW SESSION VARIABLES LIKE \'FOREIGN_KEY_CHECKS\';', + 'result' => array( + array('foreign_key_checks', 'ON'), + ), + ), + array( + 'query' => 'SHOW TABLES FROM `pma_test`;', 'result' => array( array('table1'), array('table2'), - ) + ), ), array( - 'query' => 'SHOW TABLES FROM `pmadb`', + 'query' => 'SHOW TABLES FROM `pmadb`', 'result' => array( array('column_info'), - ) + ), ), array( - 'query' => 'SHOW COLUMNS FROM `pma_test`.`table1`', + 'query' => 'SHOW COLUMNS FROM `pma_test`.`table1`', 'columns' => array( - 'Field', 'Type', 'Null', 'Key', 'Default', 'Extra' + 'Field', + 'Type', + 'Null', + 'Key', + 'Default', + 'Extra', ), - 'result' => array( + 'result' => array( array('i', 'int(11)', 'NO', 'PRI', 'NULL', 'auto_increment'), array('o', 'int(11)', 'NO', 'MUL', 'NULL', ''), - ) + ), ), array( - 'query' => 'SHOW INDEXES FROM `pma_test`.`table1` WHERE (Non_unique = 0)', + 'query' => 'SHOW INDEXES FROM `pma_test`.`table1` WHERE (Non_unique = 0)', 'result' => array(), ), array( - 'query' => 'SHOW COLUMNS FROM `pma_test`.`table2`', + 'query' => 'SHOW COLUMNS FROM `pma_test`.`table2`', 'columns' => array( - 'Field', 'Type', 'Null', 'Key', 'Default', 'Extra' + 'Field', + 'Type', + 'Null', + 'Key', + 'Default', + 'Extra', ), - 'result' => array( + 'result' => array( array('i', 'int(11)', 'NO', 'PRI', 'NULL', 'auto_increment'), array('o', 'int(11)', 'NO', 'MUL', 'NULL', ''), - ) + ), ), array( - 'query' => 'SHOW INDEXES FROM `pma_test`.`table1`', + 'query' => 'SHOW INDEXES FROM `pma_test`.`table1`', 'result' => array(), ), array( - 'query' => 'SHOW INDEXES FROM `pma_test`.`table2`', + 'query' => 'SHOW INDEXES FROM `pma_test`.`table2`', 'result' => array(), ), array( - 'query' => 'SHOW COLUMNS FROM `pma`.`table1`', + 'query' => 'SHOW COLUMNS FROM `pma`.`table1`', 'columns' => array( - 'Field', 'Type', 'Null', 'Key', 'Default', 'Extra', - 'Privileges', 'Comment' + 'Field', + 'Type', + 'Null', + 'Key', + 'Default', + 'Extra', + 'Privileges', + 'Comment', ), - 'result' => array( + 'result' => array( array( - 'i', 'int(11)', 'NO', 'PRI', 'NULL', 'auto_increment', - 'select,insert,update,references', '' + 'i', + 'int(11)', + 'NO', + 'PRI', + 'NULL', + 'auto_increment', + 'select,insert,update,references', + '', ), array( - 'o', 'varchar(100)', 'NO', 'MUL', 'NULL', '', - 'select,insert,update,references', '' + 'o', + 'varchar(100)', + 'NO', + 'MUL', + 'NULL', + '', + 'select,insert,update,references', + '', ), - ) + ), ), array( - 'query' => 'SELECT * FROM information_schema.CHARACTER_SETS', + 'query' => 'SELECT * FROM information_schema.CHARACTER_SETS', 'columns' => array( - 'CHARACTER_SET_NAME', 'DEFAULT_COLLATE_NAME', 'DESCRIPTION', 'MAXLEN' + 'CHARACTER_SET_NAME', + 'DEFAULT_COLLATE_NAME', + 'DESCRIPTION', + 'MAXLEN', ), - 'result' => array( + 'result' => array( array('utf8', 'utf8_general_ci', 'UTF-8 Unicode', 3), - ) + ), ), array( - 'query' => 'SELECT * FROM information_schema.COLLATIONS', + 'query' => 'SELECT * FROM information_schema.COLLATIONS', 'columns' => array( - 'COLLATION_NAME', 'CHARACTER_SET_NAME', 'ID', 'IS_DEFAULT', - 'IS_COMPILED', 'SORTLEN' + 'COLLATION_NAME', + 'CHARACTER_SET_NAME', + 'ID', + 'IS_DEFAULT', + 'IS_COMPILED', + 'SORTLEN', ), - 'result' => array( + 'result' => array( array('utf8_general_ci', 'utf8', 33, 'Yes', 'Yes', 1), array('utf8_bin', 'utf8', 83, '', 'Yes', 1), - ) + ), ), array( - 'query' => 'SELECT `TABLE_NAME` FROM `INFORMATION_SCHEMA`.`TABLES`' + 'query' => 'SELECT `TABLE_NAME` FROM `INFORMATION_SCHEMA`.`TABLES`' . ' WHERE `TABLE_SCHEMA`=\'pma_test\' AND `TABLE_TYPE`=\'BASE TABLE\'', 'result' => array(), ), array( - 'query' => 'SELECT `column_name`, `mimetype`, `transformation`,' + 'query' => 'SELECT `column_name`, `mimetype`, `transformation`,' . ' `transformation_options`, `input_transformation`,' . ' `input_transformation_options`' . ' FROM `pmadb`.`column_info`' @@ -239,21 +274,25 @@ $GLOBALS['dummy_queries'] = array( . ' OR `input_transformation` != \'\'' . ' OR `input_transformation_options` != \'\')', 'columns' => array( - 'column_name', 'mimetype', 'transformation', 'transformation_options', - 'input_transformation', 'input_transformation_options' + 'column_name', + 'mimetype', + 'transformation', + 'transformation_options', + 'input_transformation', + 'input_transformation_options', ), - 'result' => array( + 'result' => array( array('o', 'text/plain', 'sql', '', 'regex', '/pma/i'), - array('col', 't', 'o/p', '', 'i/p', '') - ) + array('col', 't', 'o/p', '', 'i/p', ''), + ), ), array( - 'query' => 'SELECT TABLE_NAME FROM information_schema.VIEWS' + 'query' => 'SELECT TABLE_NAME FROM information_schema.VIEWS' . ' WHERE TABLE_SCHEMA = \'pma_test\' AND TABLE_NAME = \'table1\'', 'result' => array(), ), array( - 'query' => 'SELECT *, `TABLE_SCHEMA` AS `Db`, `TABLE_NAME` AS `Name`,' + 'query' => 'SELECT *, `TABLE_SCHEMA` AS `Db`, `TABLE_NAME` AS `Name`,' . ' `TABLE_TYPE` AS `TABLE_TYPE`, `ENGINE` AS `Engine`,' . ' `ENGINE` AS `Type`, `VERSION` AS `Version`,' . ' `ROW_FORMAT` AS `Row_format`, `TABLE_ROWS` AS `Rows`,' @@ -270,30 +309,96 @@ $GLOBALS['dummy_queries'] = array( . ' WHERE `TABLE_SCHEMA` IN (\'pma_test\')' . ' AND t.`TABLE_NAME` = \'table1\' ORDER BY Name ASC', 'columns' => array( - 'TABLE_CATALOG', 'TABLE_SCHEMA', 'TABLE_NAME', 'TABLE_TYPE', 'ENGINE', - 'VERSION', 'ROW_FORMAT', 'TABLE_ROWS', 'AVG_ROW_LENGTH', 'DATA_LENGTH', - 'MAX_DATA_LENGTH', 'INDEX_LENGTH', 'DATA_FREE', 'AUTO_INCREMENT', - 'CREATE_TIME', 'UPDATE_TIME', 'CHECK_TIME', 'TABLE_COLLATION', - 'CHECKSUM', 'CREATE_OPTIONS', 'TABLE_COMMENT', 'Db', 'Name', - 'TABLE_TYPE', 'Engine', 'Type', 'Version', 'Row_format', 'Rows', - 'Avg_row_length', 'Data_length', 'Max_data_length', 'Index_length', - 'Data_free', 'Auto_increment', 'Create_time', 'Update_time', - 'Check_time', 'Collation', 'Checksum', 'Create_options', 'Comment' + 'TABLE_CATALOG', + 'TABLE_SCHEMA', + 'TABLE_NAME', + 'TABLE_TYPE', + 'ENGINE', + 'VERSION', + 'ROW_FORMAT', + 'TABLE_ROWS', + 'AVG_ROW_LENGTH', + 'DATA_LENGTH', + 'MAX_DATA_LENGTH', + 'INDEX_LENGTH', + 'DATA_FREE', + 'AUTO_INCREMENT', + 'CREATE_TIME', + 'UPDATE_TIME', + 'CHECK_TIME', + 'TABLE_COLLATION', + 'CHECKSUM', + 'CREATE_OPTIONS', + 'TABLE_COMMENT', + 'Db', + 'Name', + 'TABLE_TYPE', + 'Engine', + 'Type', + 'Version', + 'Row_format', + 'Rows', + 'Avg_row_length', + 'Data_length', + 'Max_data_length', + 'Index_length', + 'Data_free', + 'Auto_increment', + 'Create_time', + 'Update_time', + 'Check_time', + 'Collation', + 'Checksum', + 'Create_options', + 'Comment', ), - 'result' => array( + 'result' => array( array( - 'def', 'smash', 'issues_issue', 'BASE TABLE', 'InnoDB', '10', - 'Compact', '9136', '862', '7880704', '0', '1032192', '420478976', - '155862', '2012-08-29 13:28:28', 'NULL', 'NULL', 'utf8_general_ci', - 'NULL', '', '', 'smash', 'issues_issue', 'BASE TABLE', 'InnoDB', - 'InnoDB', '10', 'Compact', '9136', '862', '7880704', '0', '1032192', - '420478976', '155862', '2012-08-29 13:28:28', 'NULL', 'NULL', - 'utf8_general_ci', 'NULL' + 'def', + 'smash', + 'issues_issue', + 'BASE TABLE', + 'InnoDB', + '10', + 'Compact', + '9136', + '862', + '7880704', + '0', + '1032192', + '420478976', + '155862', + '2012-08-29 13:28:28', + 'NULL', + 'NULL', + 'utf8_general_ci', + 'NULL', + '', + '', + 'smash', + 'issues_issue', + 'BASE TABLE', + 'InnoDB', + 'InnoDB', + '10', + 'Compact', + '9136', + '862', + '7880704', + '0', + '1032192', + '420478976', + '155862', + '2012-08-29 13:28:28', + 'NULL', + 'NULL', + 'utf8_general_ci', + 'NULL', ), ), ), array( - 'query' => 'SELECT *, `TABLE_SCHEMA` AS `Db`, `TABLE_NAME` AS `Name`,' + 'query' => 'SELECT *, `TABLE_SCHEMA` AS `Db`, `TABLE_NAME` AS `Name`,' . ' `TABLE_TYPE` AS `TABLE_TYPE`, `ENGINE` AS `Engine`,' . ' `ENGINE` AS `Type`, `VERSION` AS `Version`,' . ' `ROW_FORMAT` AS `Row_format`, `TABLE_ROWS` AS `Rows`,' @@ -309,41 +414,108 @@ $GLOBALS['dummy_queries'] = array( . ' FROM `information_schema`.`TABLES` t' . ' WHERE `TABLE_SCHEMA` IN (\'pma_test\')' . ' AND t.`TABLE_NAME` = \'table1\' ORDER BY Name ASC', - 'columns' => array('TABLE_CATALOG', 'TABLE_SCHEMA', 'TABLE_NAME', - 'TABLE_TYPE', 'ENGINE', 'VERSION', 'ROW_FORMAT', 'TABLE_ROWS', - 'AVG_ROW_LENGTH', 'DATA_LENGTH', 'MAX_DATA_LENGTH', - 'INDEX_LENGTH', 'DATA_FREE', 'AUTO_INCREMENT', 'CREATE_TIME', - 'UPDATE_TIME', 'CHECK_TIME', 'TABLE_COLLATION', 'CHECKSUM', - 'CREATE_OPTIONS', 'TABLE_COMMENT', 'Db', 'Name', 'TABLE_TYPE', - 'Engine', 'Type', 'Version', 'Row_format', 'Rows', - 'Avg_row_length', 'Data_length', 'Max_data_length', - 'Index_length', 'Data_free', 'Auto_increment', 'Create_time', - 'Update_time', 'Check_time', 'Collation', 'Checksum', - 'Create_options', 'Comment'), - 'result' => array( - array('def', 'smash', 'issues_issue', 'BASE TABLE', 'InnoDB', '10', - 'Compact', '9136', '862', '7880704', '0', '1032192', - '420478976', '155862', '2012-08-29 13:28:28', 'NULL', 'NULL', - 'utf8_general_ci', 'NULL', '', '', 'smash', 'issues_issue', - 'BASE TABLE', 'InnoDB', 'InnoDB', '10', 'Compact', '9136', - '862', '7880704', '0', '1032192', '420478976', '155862', - '2012-08-29 13:28:28', 'NULL', 'NULL', 'utf8_general_ci', - 'NULL'), + 'columns' => array( + 'TABLE_CATALOG', + 'TABLE_SCHEMA', + 'TABLE_NAME', + 'TABLE_TYPE', + 'ENGINE', + 'VERSION', + 'ROW_FORMAT', + 'TABLE_ROWS', + 'AVG_ROW_LENGTH', + 'DATA_LENGTH', + 'MAX_DATA_LENGTH', + 'INDEX_LENGTH', + 'DATA_FREE', + 'AUTO_INCREMENT', + 'CREATE_TIME', + 'UPDATE_TIME', + 'CHECK_TIME', + 'TABLE_COLLATION', + 'CHECKSUM', + 'CREATE_OPTIONS', + 'TABLE_COMMENT', + 'Db', + 'Name', + 'TABLE_TYPE', + 'Engine', + 'Type', + 'Version', + 'Row_format', + 'Rows', + 'Avg_row_length', + 'Data_length', + 'Max_data_length', + 'Index_length', + 'Data_free', + 'Auto_increment', + 'Create_time', + 'Update_time', + 'Check_time', + 'Collation', + 'Checksum', + 'Create_options', + 'Comment', + ), + 'result' => array( + array( + 'def', + 'smash', + 'issues_issue', + 'BASE TABLE', + 'InnoDB', + '10', + 'Compact', + '9136', + '862', + '7880704', + '0', + '1032192', + '420478976', + '155862', + '2012-08-29 13:28:28', + 'NULL', + 'NULL', + 'utf8_general_ci', + 'NULL', + '', + '', + 'smash', + 'issues_issue', + 'BASE TABLE', + 'InnoDB', + 'InnoDB', + '10', + 'Compact', + '9136', + '862', + '7880704', + '0', + '1032192', + '420478976', + '155862', + '2012-08-29 13:28:28', + 'NULL', + 'NULL', + 'utf8_general_ci', + 'NULL', + ), ), ), array( - 'query' => 'SELECT COUNT(*) FROM `pma_test`.`table1`', + 'query' => 'SELECT COUNT(*) FROM `pma_test`.`table1`', 'result' => array(array(0)), ), array( - 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' + 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' . '`USER_PRIVILEGES`' . ' WHERE GRANTEE=\'\'\'pma_test\'\'@\'\'localhost\'\'\'' . ' AND PRIVILEGE_TYPE=\'TRIGGER\'', 'result' => array(), ), array( - 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' + 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' . '`SCHEMA_PRIVILEGES`' . ' WHERE GRANTEE=\'\'\'pma_test\'\'@\'\'localhost\'\'\'' . ' AND PRIVILEGE_TYPE=\'TRIGGER\' AND \'pma_test\'' @@ -351,7 +523,7 @@ $GLOBALS['dummy_queries'] = array( 'result' => array(), ), array( - 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' + 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' . '`TABLE_PRIVILEGES`' . ' WHERE GRANTEE=\'\'\'pma_test\'\'@\'\'localhost\'\'\'' . ' AND PRIVILEGE_TYPE=\'TRIGGER\' AND \'pma_test\'' @@ -359,14 +531,14 @@ $GLOBALS['dummy_queries'] = array( 'result' => array(), ), array( - 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' + 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' . '`USER_PRIVILEGES`' . ' WHERE GRANTEE=\'\'\'pma_test\'\'@\'\'localhost\'\'\'' . ' AND PRIVILEGE_TYPE=\'EVENT\'', 'result' => array(), ), array( - 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' + 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' . '`SCHEMA_PRIVILEGES`' . ' WHERE GRANTEE=\'\'\'pma_test\'\'@\'\'localhost\'\'\'' . ' AND PRIVILEGE_TYPE=\'EVENT\' AND \'pma_test\'' @@ -374,7 +546,7 @@ $GLOBALS['dummy_queries'] = array( 'result' => array(), ), array( - 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' + 'query' => 'SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`.' . '`TABLE_PRIVILEGES`' . ' WHERE GRANTEE=\'\'\'pma_test\'\'@\'\'localhost\'\'\'' . ' AND PRIVILEGE_TYPE=\'EVENT\'' @@ -382,11 +554,11 @@ $GLOBALS['dummy_queries'] = array( 'result' => array(), ), array( - 'query' => 'RENAME TABLE `pma_test`.`table1` TO `pma_test`.`table3`;', + 'query' => 'RENAME TABLE `pma_test`.`table1` TO `pma_test`.`table3`;', 'result' => array(), ), array( - 'query' => 'SELECT TRIGGER_SCHEMA, TRIGGER_NAME, EVENT_MANIPULATION,' + 'query' => 'SELECT TRIGGER_SCHEMA, TRIGGER_NAME, EVENT_MANIPULATION,' . ' EVENT_OBJECT_TABLE, ACTION_TIMING, ACTION_STATEMENT, ' . 'EVENT_OBJECT_SCHEMA, EVENT_OBJECT_TABLE, DEFINER' . ' FROM information_schema.TRIGGERS' @@ -395,114 +567,114 @@ $GLOBALS['dummy_queries'] = array( 'result' => array(), ), array( - 'query' => 'SHOW TABLES FROM `pma`;', + 'query' => 'SHOW TABLES FROM `pma`;', 'result' => array(), ), array( - 'query' => "SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`." + 'query' => "SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`." . "`SCHEMA_PRIVILEGES` WHERE GRANTEE='''pma_test''@''localhost'''" . " AND PRIVILEGE_TYPE='EVENT' AND TABLE_SCHEMA='pma'", 'result' => array(), ), array( - 'query' => "SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`." + 'query' => "SELECT `PRIVILEGE_TYPE` FROM `INFORMATION_SCHEMA`." . "`SCHEMA_PRIVILEGES` WHERE GRANTEE='''pma_test''@''localhost'''" . " AND PRIVILEGE_TYPE='TRIGGER' AND TABLE_SCHEMA='pma'", 'result' => array(), ), array( - 'query' => 'SELECT DEFAULT_COLLATION_NAME FROM information_schema.SCHEMATA' - . ' WHERE SCHEMA_NAME = \'pma_test\' LIMIT 1', + 'query' => 'SELECT DEFAULT_COLLATION_NAME FROM information_schema.SCHEMATA' + . ' WHERE SCHEMA_NAME = \'pma_test\' LIMIT 1', 'columns' => array('DEFAULT_COLLATION_NAME'), - 'result' => array( - array('utf8_general_ci') - ) + 'result' => array( + array('utf8_general_ci'), + ), ), array( - 'query' => 'SELECT @@collation_database', + 'query' => 'SELECT @@collation_database', 'columns' => array('@@collation_database'), - 'result' => array( + 'result' => array( array('bar'), - ) + ), ), array( - 'query' => "SHOW TABLES FROM `phpmyadmin`", + 'query' => "SHOW TABLES FROM `phpmyadmin`", 'result' => array(), ), array( - 'query' => "SELECT tracking_active FROM `pmadb`.`tracking`" . + 'query' => "SELECT tracking_active FROM `pmadb`.`tracking`" . " WHERE db_name = 'pma_test_db'" . " AND table_name = 'pma_test_table'" . " ORDER BY version DESC", 'columns' => array('tracking_active'), - 'result' => array( - array(1) - ) + 'result' => array( + array(1), + ), ), array( - 'query' => "SELECT tracking_active FROM `pmadb`.`tracking`" . + 'query' => "SELECT tracking_active FROM `pmadb`.`tracking`" . " WHERE db_name = 'pma_test_db'" . " AND table_name = 'pma_test_table2'" . " ORDER BY version DESC", - 'result' => array() + 'result' => array(), ), array( - 'query' => "SHOW SLAVE STATUS", + 'query' => "SHOW SLAVE STATUS", 'result' => array( array( - 'Slave_IO_State' => 'running', - 'Master_Host' => 'locahost', - 'Master_User' => 'Master_User', - 'Master_Port' => '1002', - 'Connect_Retry' => 'Connect_Retry', - 'Master_Log_File' => 'Master_Log_File', - 'Read_Master_Log_Pos' => 'Read_Master_Log_Pos', - 'Relay_Log_File' => 'Relay_Log_File', - 'Relay_Log_Pos' => 'Relay_Log_Pos', - 'Relay_Master_Log_File' => 'Relay_Master_Log_File', - 'Slave_IO_Running' => 'NO', - 'Slave_SQL_Running' => 'NO', - 'Replicate_Do_DB' => 'Replicate_Do_DB', - 'Replicate_Ignore_DB' => 'Replicate_Ignore_DB', - 'Replicate_Do_Table' => 'Replicate_Do_Table', - 'Replicate_Ignore_Table' => 'Replicate_Ignore_Table', - 'Replicate_Wild_Do_Table' => 'Replicate_Wild_Do_Table', + 'Slave_IO_State' => 'running', + 'Master_Host' => 'locahost', + 'Master_User' => 'Master_User', + 'Master_Port' => '1002', + 'Connect_Retry' => 'Connect_Retry', + 'Master_Log_File' => 'Master_Log_File', + 'Read_Master_Log_Pos' => 'Read_Master_Log_Pos', + 'Relay_Log_File' => 'Relay_Log_File', + 'Relay_Log_Pos' => 'Relay_Log_Pos', + 'Relay_Master_Log_File' => 'Relay_Master_Log_File', + 'Slave_IO_Running' => 'NO', + 'Slave_SQL_Running' => 'NO', + 'Replicate_Do_DB' => 'Replicate_Do_DB', + 'Replicate_Ignore_DB' => 'Replicate_Ignore_DB', + 'Replicate_Do_Table' => 'Replicate_Do_Table', + 'Replicate_Ignore_Table' => 'Replicate_Ignore_Table', + 'Replicate_Wild_Do_Table' => 'Replicate_Wild_Do_Table', 'Replicate_Wild_Ignore_Table' => 'Replicate_Wild_Ignore_Table', - 'Last_Errno' => 'Last_Errno', - 'Last_Error' => 'Last_Error', - 'Skip_Counter' => 'Skip_Counter', - 'Exec_Master_Log_Pos' => 'Exec_Master_Log_Pos', - 'Relay_Log_Space' => 'Relay_Log_Space', - 'Until_Condition' => 'Until_Condition', - 'Until_Log_File' => 'Until_Log_File', - 'Until_Log_Pos' => 'Until_Log_Pos', - 'Master_SSL_Allowed' => 'Master_SSL_Allowed', - 'Master_SSL_CA_File' => 'Master_SSL_CA_File', - 'Master_SSL_CA_Path' => 'Master_SSL_CA_Path', - 'Master_SSL_Cert' => 'Master_SSL_Cert', - 'Master_SSL_Cipher' => 'Master_SSL_Cipher', - 'Master_SSL_Key' => 'Master_SSL_Key', - 'Seconds_Behind_Master' => 'Seconds_Behind_Master', - ) - ) + 'Last_Errno' => 'Last_Errno', + 'Last_Error' => 'Last_Error', + 'Skip_Counter' => 'Skip_Counter', + 'Exec_Master_Log_Pos' => 'Exec_Master_Log_Pos', + 'Relay_Log_Space' => 'Relay_Log_Space', + 'Until_Condition' => 'Until_Condition', + 'Until_Log_File' => 'Until_Log_File', + 'Until_Log_Pos' => 'Until_Log_Pos', + 'Master_SSL_Allowed' => 'Master_SSL_Allowed', + 'Master_SSL_CA_File' => 'Master_SSL_CA_File', + 'Master_SSL_CA_Path' => 'Master_SSL_CA_Path', + 'Master_SSL_Cert' => 'Master_SSL_Cert', + 'Master_SSL_Cipher' => 'Master_SSL_Cipher', + 'Master_SSL_Key' => 'Master_SSL_Key', + 'Seconds_Behind_Master' => 'Seconds_Behind_Master', + ), + ), ), array( - 'query' => "SHOW MASTER STATUS", + 'query' => "SHOW MASTER STATUS", 'result' => array( array( - "File" => "master-bin.000030", - "Position" => "107", - "Binlog_Do_DB" => "Binlog_Do_DB", + "File" => "master-bin.000030", + "Position" => "107", + "Binlog_Do_DB" => "Binlog_Do_DB", "Binlog_Ignore_DB" => "Binlog_Ignore_DB", - ) - ) + ), + ), ), array( - 'query' => "SHOW GRANTS", - 'result' => array() + 'query' => "SHOW GRANTS", + 'result' => array(), ), array( - 'query' => "SELECT `SCHEMA_NAME` FROM `INFORMATION_SCHEMA`.`SCHEMATA`, " + 'query' => "SELECT `SCHEMA_NAME` FROM `INFORMATION_SCHEMA`.`SCHEMATA`, " . "(SELECT DB_first_level FROM ( SELECT DISTINCT " . "SUBSTRING_INDEX(SCHEMA_NAME, '_', 1) DB_first_level " . "FROM INFORMATION_SCHEMA.SCHEMATA WHERE TRUE ) t ORDER BY " @@ -511,112 +683,112 @@ $GLOBALS['dummy_queries'] = array( . "ORDER BY SCHEMA_NAME ASC", 'result' => array( "test", - ) + ), ), array( - 'query' => "SELECT COUNT(*) FROM ( SELECT DISTINCT SUBSTRING_INDEX(" + 'query' => "SELECT COUNT(*) FROM ( SELECT DISTINCT SUBSTRING_INDEX(" . "SCHEMA_NAME, '_', 1) DB_first_level " . "FROM INFORMATION_SCHEMA.SCHEMATA WHERE TRUE ) t", 'result' => array( array(1), - ) - ), - array( - 'query' => "SELECT `PARTITION_METHOD` " - . "FROM `information_schema`.`PARTITIONS` " - . "WHERE `TABLE_SCHEMA` = 'db' AND `TABLE_NAME` = 'table'", - 'result' => array() - ), - array( - 'query' => "SHOW PLUGINS", - 'result' => array( - array('Name' => 'partition') - ) - ), - array( - 'query' => "SHOW FULL TABLES FROM `default` WHERE `Table_type`='BASE TABLE'", - 'result' => array( - array("test1", "BASE TABLE"), - array("test2", "BASE TABLE"), - ) - ), - array( - 'query' => "SHOW FULL TABLES FROM `default` " - . "WHERE `Table_type`!='BASE TABLE'", - 'result' => array() - ), - array( - 'query' => "SHOW FUNCTION STATUS WHERE `Db`='default'", - 'result' => array(array("Name" => "testFunction")) - ), - array( - 'query' => "SHOW PROCEDURE STATUS WHERE `Db`='default'", - 'result' => array() - ), - array( - 'query' => "SHOW EVENTS FROM `default`", - 'result' => array() - ), - array( - 'query' => "FLUSH PRIVILEGES", - 'result' => array() - ), - array( - 'query' => "SELECT * FROM `mysql`.`db` LIMIT 1", - 'result' => array() - ), - array( - 'query' => "SELECT * FROM `mysql`.`columns_priv` LIMIT 1", - 'result' => array() - ), - array( - 'query' => "SELECT * FROM `mysql`.`tables_priv` LIMIT 1", - 'result' => array() - ), - array( - 'query' => "SELECT * FROM `mysql`.`procs_priv` LIMIT 1", - 'result' => array() - ), - array( - 'query' => 'DELETE FROM `mysql`.`db` WHERE `host` = "" ' - . 'AND `Db` = "" AND `User` = "" LIMIT 1', - 'result' => true - ), - array( - 'query' => 'DELETE FROM `mysql`.`columns_priv` WHERE ' - . '`host` = "" AND `Db` = "" AND `User` = "" LIMIT 1', - 'result' => true - ), - array( - 'query' => 'DELETE FROM `mysql`.`tables_priv` WHERE ' - . '`host` = "" AND `Db` = "" AND `User` = "" AND Table_name = "" ' - . 'LIMIT 1', - 'result' => true - ), - array( - 'query' => 'DELETE FROM `mysql`.`procs_priv` WHERE ' - . '`host` = "" AND `Db` = "" AND `User` = "" AND `Routine_name` = "" ' - . 'AND `Routine_type` = "" LIMIT 1', - 'result' => true - ), - array( - 'query' => 'SELECT `plugin` FROM `mysql`.`user` WHERE ' - . '`User` = "pma_username" AND `Host` = "pma_hostname" LIMIT 1', - 'result' => array() - ), - array( - 'query' => 'SELECT @@default_authentication_plugin', - 'result' => array( - array('@@default_authentication_plugin' => 'mysql_native_password') ), ), array( - 'query' => "SELECT TABLE_NAME FROM information_schema.VIEWS WHERE " - . "TABLE_SCHEMA = 'db' AND TABLE_NAME = 'table'", - 'result' => array() + 'query' => "SELECT `PARTITION_METHOD` " + . "FROM `information_schema`.`PARTITIONS` " + . "WHERE `TABLE_SCHEMA` = 'db' AND `TABLE_NAME` = 'table'", + 'result' => array(), ), array( - 'query' => "SELECT *, `TABLE_SCHEMA` AS `Db`, " + 'query' => "SHOW PLUGINS", + 'result' => array( + array('Name' => 'partition'), + ), + ), + array( + 'query' => "SHOW FULL TABLES FROM `default` WHERE `Table_type`='BASE TABLE'", + 'result' => array( + array("test1", "BASE TABLE"), + array("test2", "BASE TABLE"), + ), + ), + array( + 'query' => "SHOW FULL TABLES FROM `default` " + . "WHERE `Table_type`!='BASE TABLE'", + 'result' => array(), + ), + array( + 'query' => "SHOW FUNCTION STATUS WHERE `Db`='default'", + 'result' => array(array("Name" => "testFunction")), + ), + array( + 'query' => "SHOW PROCEDURE STATUS WHERE `Db`='default'", + 'result' => array(), + ), + array( + 'query' => "SHOW EVENTS FROM `default`", + 'result' => array(), + ), + array( + 'query' => "FLUSH PRIVILEGES", + 'result' => array(), + ), + array( + 'query' => "SELECT * FROM `mysql`.`db` LIMIT 1", + 'result' => array(), + ), + array( + 'query' => "SELECT * FROM `mysql`.`columns_priv` LIMIT 1", + 'result' => array(), + ), + array( + 'query' => "SELECT * FROM `mysql`.`tables_priv` LIMIT 1", + 'result' => array(), + ), + array( + 'query' => "SELECT * FROM `mysql`.`procs_priv` LIMIT 1", + 'result' => array(), + ), + array( + 'query' => 'DELETE FROM `mysql`.`db` WHERE `host` = "" ' + . 'AND `Db` = "" AND `User` = "" LIMIT 1', + 'result' => true, + ), + array( + 'query' => 'DELETE FROM `mysql`.`columns_priv` WHERE ' + . '`host` = "" AND `Db` = "" AND `User` = "" LIMIT 1', + 'result' => true, + ), + array( + 'query' => 'DELETE FROM `mysql`.`tables_priv` WHERE ' + . '`host` = "" AND `Db` = "" AND `User` = "" AND Table_name = "" ' + . 'LIMIT 1', + 'result' => true, + ), + array( + 'query' => 'DELETE FROM `mysql`.`procs_priv` WHERE ' + . '`host` = "" AND `Db` = "" AND `User` = "" AND `Routine_name` = "" ' + . 'AND `Routine_type` = "" LIMIT 1', + 'result' => true, + ), + array( + 'query' => 'SELECT `plugin` FROM `mysql`.`user` WHERE ' + . '`User` = "pma_username" AND `Host` = "pma_hostname" LIMIT 1', + 'result' => array(), + ), + array( + 'query' => 'SELECT @@default_authentication_plugin', + 'result' => array( + array('@@default_authentication_plugin' => 'mysql_native_password'), + ), + ), + array( + 'query' => "SELECT TABLE_NAME FROM information_schema.VIEWS WHERE " + . "TABLE_SCHEMA = 'db' AND TABLE_NAME = 'table'", + 'result' => array(), + ), + array( + 'query' => "SELECT *, `TABLE_SCHEMA` AS `Db`, " . "`TABLE_NAME` AS `Name`, `TABLE_TYPE` AS `TABLE_TYPE`, " . "`ENGINE` AS `Engine`, `ENGINE` AS `Type`, " . "`VERSION` AS `Version`, `ROW_FORMAT` AS `Row_format`, " @@ -633,26 +805,26 @@ $GLOBALS['dummy_queries'] = array( . "FROM `information_schema`.`TABLES` t " . "WHERE `TABLE_SCHEMA` IN ('db') " . "AND t.`TABLE_NAME` = 'table' ORDER BY Name ASC", - 'result' => array() + 'result' => array(), ), array( - 'query' => "SHOW TABLE STATUS FROM `db` WHERE `Name` LIKE 'table%'", - 'result' => array() + 'query' => "SHOW TABLE STATUS FROM `db` WHERE `Name` LIKE 'table%'", + 'result' => array(), ), array( - 'query' => "SELECT @@have_partitioning;", - 'result' => array() + 'query' => "SELECT @@have_partitioning;", + 'result' => array(), ), array( - 'query' => "SELECT @@lower_case_table_names", - 'result' => array() + 'query' => "SELECT @@lower_case_table_names", + 'result' => array(), ), array( - 'query' => "SELECT `PLUGIN_NAME`, `PLUGIN_DESCRIPTION` " + 'query' => "SELECT `PLUGIN_NAME`, `PLUGIN_DESCRIPTION` " . "FROM `information_schema`.`PLUGINS` " . "WHERE `PLUGIN_TYPE` = 'AUTHENTICATION';", - 'result' => array() - ) + 'result' => array(), + ), ); /** * Current database. @@ -663,7 +835,7 @@ $GLOBALS['dummy_db'] = ''; $GLOBALS['userlink'] = 1; $GLOBALS['controllink'] = 2; $GLOBALS['cfg']['DBG']['sql'] = false; -if (! defined('PMA_MARIADB')) { +if (!defined('PMA_MARIADB')) { define('PMA_MARIADB', 0); } @@ -692,7 +864,10 @@ class DBIDummy implements DBIExtension * @return mixed false on error or a mysqli object on success */ public function connect( - $user, $password, $is_controluser = false, $server = null, + $user, + $password, + $is_controluser = false, + $server = null, $auxiliary_connection = false ) { return true; @@ -709,6 +884,7 @@ class DBIDummy implements DBIExtension public function selectDb($dbname, $link) { $GLOBALS['dummy_db'] = $dbname; + return true; } @@ -737,6 +913,7 @@ class DBIDummy implements DBIExtension return $i; } echo "Not supported query: $query\n"; + return false; } @@ -768,6 +945,7 @@ class DBIDummy implements DBIExtension } $ret = $query_data['result'][$query_data['pos']]; $GLOBALS['dummy_queries'][$result]['pos'] += 1; + return $ret; } @@ -790,6 +968,7 @@ class DBIDummy implements DBIExtension foreach ($data as $key => $val) { $data[$GLOBALS['dummy_queries'][$result]['columns'][$key]] = $val; } + return $data; } @@ -813,6 +992,7 @@ class DBIDummy implements DBIExtension foreach ($data as $key => $val) { $ret[$GLOBALS['dummy_queries'][$result]['columns'][$key]] = $val; } + return $ret; } @@ -826,6 +1006,7 @@ class DBIDummy implements DBIExtension public function fetchRow($result) { $data = $this->fetchAny($result); + return $data; } @@ -843,6 +1024,7 @@ class DBIDummy implements DBIExtension return false; } $GLOBALS['dummy_queries'][$result]['pos'] = $offset; + return true; } diff --git a/libraries/display_change_password.lib.php b/libraries/display_change_password.lib.php index 28abe6b817..d72009bc61 100644 --- a/libraries/display_change_password.lib.php +++ b/libraries/display_change_password.lib.php @@ -7,10 +7,6 @@ */ use PMA\libraries\Message; -if (! defined('PHPMYADMIN')) { - exit; -} - /** * Get HTML for the Change password dialog * diff --git a/libraries/display_export.lib.php b/libraries/display_export.lib.php index 73537fe7a9..d4ebd04bf3 100644 --- a/libraries/display_export.lib.php +++ b/libraries/display_export.lib.php @@ -10,10 +10,6 @@ use PMA\libraries\Message; use PMA\libraries\plugins\ExportPlugin; use PMA\libraries\Table; -if (! defined('PHPMYADMIN')) { - exit; -} - /** * Outputs appropriate checked statement for checkbox. * diff --git a/libraries/display_git_revision.lib.php b/libraries/display_git_revision.lib.php index b670d11abf..bd179973dc 100644 --- a/libraries/display_git_revision.lib.php +++ b/libraries/display_git_revision.lib.php @@ -5,9 +5,6 @@ * * @package PhpMyAdmin */ -if (! defined('PHPMYADMIN')) { - exit; -} /** * Prints details about the current Git commit revision diff --git a/libraries/display_import.lib.php b/libraries/display_import.lib.php index d40cda6150..862484ff97 100644 --- a/libraries/display_import.lib.php +++ b/libraries/display_import.lib.php @@ -8,14 +8,9 @@ * * @package PhpMyAdmin */ - use PMA\libraries\Message; use PMA\libraries\plugins\ImportPlugin; -if (! defined('PHPMYADMIN')) { - exit; -} - /** * Prints Html For Display Import Hidden Input * diff --git a/libraries/display_select_lang.lib.php b/libraries/display_select_lang.lib.php index 99eb895fcc..1318c8b10d 100644 --- a/libraries/display_select_lang.lib.php +++ b/libraries/display_select_lang.lib.php @@ -5,9 +5,6 @@ * * @package PhpMyAdmin */ -if (! defined('PHPMYADMIN')) { - exit; -} /** * Compares the names of two languages. diff --git a/libraries/engines/Bdb.php b/libraries/engines/Bdb.php index c9a456860b..6c28ae3ba4 100644 --- a/libraries/engines/Bdb.php +++ b/libraries/engines/Bdb.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The BDB storage engine * diff --git a/libraries/engines/Berkeleydb.php b/libraries/engines/Berkeleydb.php index 7cbae983fe..55941e646b 100644 --- a/libraries/engines/Berkeleydb.php +++ b/libraries/engines/Berkeleydb.php @@ -7,10 +7,6 @@ */ namespace PMA\libraries\engines; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * This is same as BDB * diff --git a/libraries/engines/Binlog.php b/libraries/engines/Binlog.php index f6a4b0d153..0012f8525c 100644 --- a/libraries/engines/Binlog.php +++ b/libraries/engines/Binlog.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The binary log storage engine * diff --git a/libraries/engines/Innobase.php b/libraries/engines/Innobase.php index fea1f1a472..e3fc63b06c 100644 --- a/libraries/engines/Innobase.php +++ b/libraries/engines/Innobase.php @@ -7,10 +7,6 @@ */ namespace PMA\libraries\engines; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The Innobase storage engine * diff --git a/libraries/engines/Innodb.php b/libraries/engines/Innodb.php index 0e940592c6..bbb531ba62 100644 --- a/libraries/engines/Innodb.php +++ b/libraries/engines/Innodb.php @@ -10,10 +10,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; use PMA\libraries\Util; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The InnoDB storage engine * diff --git a/libraries/engines/Memory.php b/libraries/engines/Memory.php index c4190e3d78..b4e8824891 100644 --- a/libraries/engines/Memory.php +++ b/libraries/engines/Memory.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The MEMORY (HEAP) storage engine * diff --git a/libraries/engines/Merge.php b/libraries/engines/Merge.php index 60f19f88d4..dc9553a753 100644 --- a/libraries/engines/Merge.php +++ b/libraries/engines/Merge.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The MERGE storage engine * diff --git a/libraries/engines/Mrg_Myisam.php b/libraries/engines/Mrg_Myisam.php index b778498a51..39bd272066 100644 --- a/libraries/engines/Mrg_Myisam.php +++ b/libraries/engines/Mrg_Myisam.php @@ -7,10 +7,6 @@ */ namespace PMA\libraries\engines; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The MERGE storage engine * diff --git a/libraries/engines/Myisam.php b/libraries/engines/Myisam.php index 0fc92cfb83..7dff629eea 100644 --- a/libraries/engines/Myisam.php +++ b/libraries/engines/Myisam.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The MyISAM storage engine * diff --git a/libraries/engines/Ndbcluster.php b/libraries/engines/Ndbcluster.php index a267ed1767..cbf1fc754b 100644 --- a/libraries/engines/Ndbcluster.php +++ b/libraries/engines/Ndbcluster.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The NDBCLUSTER storage engine * diff --git a/libraries/engines/Pbxt.php b/libraries/engines/Pbxt.php index 0968a1b561..33b968fd96 100644 --- a/libraries/engines/Pbxt.php +++ b/libraries/engines/Pbxt.php @@ -10,10 +10,6 @@ namespace PMA\libraries\engines; use PMA; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The PBXT storage engine * diff --git a/libraries/engines/Performance_Schema.php b/libraries/engines/Performance_Schema.php index 913395d241..e0c53aef7f 100644 --- a/libraries/engines/Performance_Schema.php +++ b/libraries/engines/Performance_Schema.php @@ -9,10 +9,6 @@ namespace PMA\libraries\engines; use PMA\libraries\StorageEngine; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * The performance schema storage engine * diff --git a/libraries/export.lib.php b/libraries/export.lib.php index 186c925e57..601f6262a1 100644 --- a/libraries/export.lib.php +++ b/libraries/export.lib.php @@ -6,16 +6,11 @@ * * @package PhpMyAdmin */ - use PMA\libraries\Message; use PMA\libraries\plugins\ExportPlugin; use PMA\libraries\Table; use PMA\libraries\ZipFile; -if (! defined('PHPMYADMIN')) { - exit; -} - /** * Sets a session variable upon a possible fatal error during export * diff --git a/libraries/file_listing.lib.php b/libraries/file_listing.lib.php index 4e78c4623a..73ab36bc30 100644 --- a/libraries/file_listing.lib.php +++ b/libraries/file_listing.lib.php @@ -5,9 +5,6 @@ * * @package PhpMyAdmin */ -if (! defined('PHPMYADMIN')) { - exit; -} /** * Returns array of filtered file names diff --git a/libraries/gis/GISFactory.php b/libraries/gis/GISFactory.php index 45c89bd1f0..3cf1b2a940 100644 --- a/libraries/gis/GISFactory.php +++ b/libraries/gis/GISFactory.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use PMA; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Factory class that handles the creation of geometric objects. * diff --git a/libraries/gis/GISGeometry.php b/libraries/gis/GISGeometry.php index b066c56e98..c6868a0690 100644 --- a/libraries/gis/GISGeometry.php +++ b/libraries/gis/GISGeometry.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Base class for all GIS data type classes. * diff --git a/libraries/gis/GISGeometrycollection.php b/libraries/gis/GISGeometrycollection.php index eb37af7577..e22e25993b 100644 --- a/libraries/gis/GISGeometrycollection.php +++ b/libraries/gis/GISGeometrycollection.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS GEOMETRYCOLLECTION objects * diff --git a/libraries/gis/GISLinestring.php b/libraries/gis/GISLinestring.php index cf54e93401..62cf7324be 100644 --- a/libraries/gis/GISLinestring.php +++ b/libraries/gis/GISLinestring.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS LINESTRING objects * diff --git a/libraries/gis/GISMultilinestring.php b/libraries/gis/GISMultilinestring.php index bbf7b83e04..33bb249f3a 100644 --- a/libraries/gis/GISMultilinestring.php +++ b/libraries/gis/GISMultilinestring.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS MULTILINESTRING objects * diff --git a/libraries/gis/GISMultipoint.php b/libraries/gis/GISMultipoint.php index 892f05126f..febbc25f3a 100644 --- a/libraries/gis/GISMultipoint.php +++ b/libraries/gis/GISMultipoint.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS MULTIPOINT objects * diff --git a/libraries/gis/GISMultipolygon.php b/libraries/gis/GISMultipolygon.php index 7be556c6d3..d6b7745683 100644 --- a/libraries/gis/GISMultipolygon.php +++ b/libraries/gis/GISMultipolygon.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS MULTIPOLYGON objects * diff --git a/libraries/gis/GISPoint.php b/libraries/gis/GISPoint.php index cf1d888adb..d8020f068f 100644 --- a/libraries/gis/GISPoint.php +++ b/libraries/gis/GISPoint.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS POINT objects * diff --git a/libraries/gis/GISPolygon.php b/libraries/gis/GISPolygon.php index e577299dbf..759913046d 100644 --- a/libraries/gis/GISPolygon.php +++ b/libraries/gis/GISPolygon.php @@ -10,10 +10,6 @@ namespace PMA\libraries\gis; use PMA\libraries\Util; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Handles actions related to GIS POLYGON objects * diff --git a/libraries/gis/GISVisualization.php b/libraries/gis/GISVisualization.php index fd8d165e8a..3336fb8342 100644 --- a/libraries/gis/GISVisualization.php +++ b/libraries/gis/GISVisualization.php @@ -11,10 +11,6 @@ namespace PMA\libraries\gis; use PMA\libraries\Util; use \TCPDF; -if (!defined('PHPMYADMIN')) { - exit; -} - require_once 'libraries/sql.lib.php'; /** diff --git a/libraries/index.lib.php b/libraries/index.lib.php index c5d2439092..804faea201 100644 --- a/libraries/index.lib.php +++ b/libraries/index.lib.php @@ -1,14 +1,10 @@ $val) { + if (preg_match('@' . $GLOBALS['cfg']['FilterLanguages'] . '@', $key)) { + $new_lang[$key] = $val; + } + } + if (count($new_lang) > 0) { + $GLOBALS['available_languages'] = $new_lang; + } + unset($key, $val, $new_lang); +} + +/** + * @global array MySQL charsets map + */ +$GLOBALS['mysql_charset_map'] = array( + 'big5' => 'big5', + 'cp-866' => 'cp866', + 'euc-jp' => 'ujis', + 'euc-kr' => 'euckr', + 'gb2312' => 'gb2312', + 'gbk' => 'gbk', + 'iso-8859-1' => 'latin1', + 'iso-8859-2' => 'latin2', + 'iso-8859-7' => 'greek', + 'iso-8859-8' => 'hebrew', + 'iso-8859-8-i' => 'hebrew', + 'iso-8859-9' => 'latin5', + 'iso-8859-13' => 'latin7', + 'iso-8859-15' => 'latin1', + 'koi8-r' => 'koi8r', + 'shift_jis' => 'sjis', + 'tis-620' => 'tis620', + 'utf-8' => 'utf8', + 'windows-1250' => 'cp1250', + 'windows-1251' => 'cp1251', + 'windows-1252' => 'latin1', + 'windows-1256' => 'cp1256', + 'windows-1257' => 'cp1257', +); + +/* + * Do the work! + */ + +if (! PMA_langCheck()) { + // fallback language + $fall_back_lang = 'en'; + $line = __LINE__; + if (! PMA_langSet($fall_back_lang)) { + trigger_error( + 'phpMyAdmin-ERROR: invalid lang code: ' + . __FILE__ . '#' . $line . ', check hard coded fall back language.', + E_USER_WARNING + ); + // stop execution + // and tell the user that his chosen language is invalid + PMA_fatalError( + 'Could not load any language, ' + . 'please check your language settings and folder.' + ); + } +} + +// Set locale +_setlocale(LC_MESSAGES, $GLOBALS['lang']); +_bindtextdomain('phpmyadmin', $GLOBALS['lang_path']); +_bind_textdomain_codeset('phpmyadmin', 'UTF-8'); +_textdomain('phpmyadmin'); + +/** + * Messages for phpMyAdmin. + * + * These messages are here for easy transition to Gettext. + * You should not add any messages here, use instead gettext directly + * in your template/PHP file. + */ + +if (! function_exists('__')) { + PMA_fatalError('Bad invocation!'); +} + +/* Text direction for language */ +if (in_array($GLOBALS['lang'], array('ar', 'fa', 'he', 'ur'))) { + $GLOBALS['text_dir'] = 'rtl'; +} else { + $GLOBALS['text_dir'] = 'ltr'; +} + +/* TCPDF */ +$GLOBALS['l'] = array(); + +/* TCPDF settings */ +$GLOBALS['l']['a_meta_charset'] = 'UTF-8'; +$GLOBALS['l']['a_meta_dir'] = $GLOBALS['text_dir']; +$GLOBALS['l']['a_meta_language'] = $GLOBALS['lang']; + +/* TCPDF translations */ +$GLOBALS['l']['w_page'] = __('Page number:'); + + +// now, that we have loaded the language strings we can send the errors +if ($GLOBALS['lang_failed_cfg'] + || $GLOBALS['lang_failed_cookie'] + || $GLOBALS['lang_failed_request'] +) { + trigger_error( + __('Ignoring unsupported language code.'), + E_USER_ERROR + ); +} +unset( + $line, $fall_back_lang, $GLOBALS['lang_failed_cfg'], + $GLOBALS['lang_failed_cookie'], $GLOBALS['lang_failed_request'] +); diff --git a/libraries/select_lang.lib.php b/libraries/select_lang.lib.php index 02305139bf..8ce3e50e5d 100644 --- a/libraries/select_lang.lib.php +++ b/libraries/select_lang.lib.php @@ -5,9 +5,6 @@ * * @package PhpMyAdmin */ -if (! defined('PHPMYADMIN')) { - exit; -} /** * Returns language name @@ -466,158 +463,3 @@ function PMA_langList() return $result; } - -/** - * @global string path to the translations directory; - * may be absent if the kit is English-only - */ -$GLOBALS['lang_path'] = './locale/'; - -/** - * Load gettext functions. - */ -require_once GETTEXT_INC; - -/** - * @global string interface language - */ -$GLOBALS['lang'] = 'en'; -/** - * @global boolean whether loading lang from cfg failed - */ -$GLOBALS['lang_failed_cfg'] = false; -/** - * @global boolean whether loading lang from cookie failed - */ -$GLOBALS['lang_failed_cookie'] = false; -/** - * @global boolean whether loading lang from user request failed - */ -$GLOBALS['lang_failed_request'] = false; -/** - * @global string text direction ltr or rtl - */ -$GLOBALS['text_dir'] = 'ltr'; - -/** - * @global array supported languages - */ -$GLOBALS['available_languages'] = PMA_langList(); - -// Language filtering support -if (! empty($GLOBALS['cfg']['FilterLanguages'])) { - $new_lang = array(); - foreach ($GLOBALS['available_languages'] as $key => $val) { - if (preg_match('@' . $GLOBALS['cfg']['FilterLanguages'] . '@', $key)) { - $new_lang[$key] = $val; - } - } - if (count($new_lang) > 0) { - $GLOBALS['available_languages'] = $new_lang; - } - unset($key, $val, $new_lang); -} - -/** - * @global array MySQL charsets map - */ -$GLOBALS['mysql_charset_map'] = array( - 'big5' => 'big5', - 'cp-866' => 'cp866', - 'euc-jp' => 'ujis', - 'euc-kr' => 'euckr', - 'gb2312' => 'gb2312', - 'gbk' => 'gbk', - 'iso-8859-1' => 'latin1', - 'iso-8859-2' => 'latin2', - 'iso-8859-7' => 'greek', - 'iso-8859-8' => 'hebrew', - 'iso-8859-8-i' => 'hebrew', - 'iso-8859-9' => 'latin5', - 'iso-8859-13' => 'latin7', - 'iso-8859-15' => 'latin1', - 'koi8-r' => 'koi8r', - 'shift_jis' => 'sjis', - 'tis-620' => 'tis620', - 'utf-8' => 'utf8', - 'windows-1250' => 'cp1250', - 'windows-1251' => 'cp1251', - 'windows-1252' => 'latin1', - 'windows-1256' => 'cp1256', - 'windows-1257' => 'cp1257', -); - -/* - * Do the work! - */ - -if (! PMA_langCheck()) { - // fallback language - $fall_back_lang = 'en'; - $line = __LINE__; - if (! PMA_langSet($fall_back_lang)) { - trigger_error( - 'phpMyAdmin-ERROR: invalid lang code: ' - . __FILE__ . '#' . $line . ', check hard coded fall back language.', - E_USER_WARNING - ); - // stop execution - // and tell the user that his chosen language is invalid - PMA_fatalError( - 'Could not load any language, ' - . 'please check your language settings and folder.' - ); - } -} - -// Set locale -_setlocale(LC_MESSAGES, $GLOBALS['lang']); -_bindtextdomain('phpmyadmin', $GLOBALS['lang_path']); -_bind_textdomain_codeset('phpmyadmin', 'UTF-8'); -_textdomain('phpmyadmin'); - -/** - * Messages for phpMyAdmin. - * - * These messages are here for easy transition to Gettext. - * You should not add any messages here, use instead gettext directly - * in your template/PHP file. - */ - -if (! function_exists('__')) { - PMA_fatalError('Bad invocation!'); -} - -/* Text direction for language */ -if (in_array($GLOBALS['lang'], array('ar', 'fa', 'he', 'ur'))) { - $GLOBALS['text_dir'] = 'rtl'; -} else { - $GLOBALS['text_dir'] = 'ltr'; -} - -/* TCPDF */ -$GLOBALS['l'] = array(); - -/* TCPDF settings */ -$GLOBALS['l']['a_meta_charset'] = 'UTF-8'; -$GLOBALS['l']['a_meta_dir'] = $GLOBALS['text_dir']; -$GLOBALS['l']['a_meta_language'] = $GLOBALS['lang']; - -/* TCPDF translations */ -$GLOBALS['l']['w_page'] = __('Page number:'); - - -// now, that we have loaded the language strings we can send the errors -if ($GLOBALS['lang_failed_cfg'] - || $GLOBALS['lang_failed_cookie'] - || $GLOBALS['lang_failed_request'] -) { - trigger_error( - __('Ignoring unsupported language code.'), - E_USER_ERROR - ); -} -unset( - $line, $fall_back_lang, $GLOBALS['lang_failed_cfg'], - $GLOBALS['lang_failed_cookie'], $GLOBALS['lang_failed_request'] -); diff --git a/libraries/select_server.lib.php b/libraries/select_server.lib.php index 82dd149fdc..63e1a69029 100644 --- a/libraries/select_server.lib.php +++ b/libraries/select_server.lib.php @@ -5,9 +5,6 @@ * * @package PhpMyAdmin */ -if (! defined('PHPMYADMIN')) { - exit; -} /** * Renders the server selection in list or selectbox form, or option tags only diff --git a/libraries/server_bin_log.lib.php b/libraries/server_bin_log.lib.php index d419fe6142..7fd7920683 100644 --- a/libraries/server_bin_log.lib.php +++ b/libraries/server_bin_log.lib.php @@ -1,6 +1,5 @@ = 50400 && session_status() === PHP_SESSION_ACTIVE) - || (PMA_PHP_INT_VERSION < 50400 && session_id() !== '') - ) { - session_regenerate_id(true); - } - $_SESSION[' PMA_token '] = md5(uniqid(rand(), true)); -} +require_once 'libraries/session.lib.php'; \ No newline at end of file diff --git a/libraries/session.lib.php b/libraries/session.lib.php new file mode 100644 index 0000000000..c4925c454f --- /dev/null +++ b/libraries/session.lib.php @@ -0,0 +1,26 @@ += 50400 && session_status() === PHP_SESSION_ACTIVE) + || (PMA_PHP_INT_VERSION < 50400 && session_id() !== '') + ) { + session_regenerate_id(true); + } + $_SESSION[' PMA_token '] = md5(uniqid(rand(), true)); +} diff --git a/libraries/sql.lib.php b/libraries/sql.lib.php index cff550b9a4..661201ad03 100644 --- a/libraries/sql.lib.php +++ b/libraries/sql.lib.php @@ -10,10 +10,6 @@ use PMA\libraries\Message; use PMA\libraries\Table; use PMA\libraries\Response; -if (!defined('PHPMYADMIN')) { - exit; -} - /** * Parses and analyzes the given SQL query. * diff --git a/test/classes/DatabaseInterfaceTest.php b/test/classes/DatabaseInterfaceTest.php index d640867b73..be7fc0fcfd 100644 --- a/test/classes/DatabaseInterfaceTest.php +++ b/test/classes/DatabaseInterfaceTest.php @@ -6,11 +6,6 @@ * @package PhpMyAdmin-test */ -/* - * Include to test. - */ -require_once 'libraries/dbi/DBIDummy.php'; - /** * Tests basic functionality of dummy dbi driver * @@ -28,8 +23,8 @@ class DatabaseInterfaceTest extends PHPUnit_Framework_TestCase */ function setup() { - //$extension = new DBIDummy(); - $extension = $this->getMockBuilder('DBIDummy') + //$extension = new PMA\libraries\dbi\DBIDummy(); + $extension = $this->getMockBuilder('PMA\libraries\dbi\DBIDummy') ->disableOriginalConstructor() ->getMock(); diff --git a/test/classes/HeaderTest.php b/test/classes/HeaderTest.php index 3d32fa5a5a..c9bca3ef5d 100644 --- a/test/classes/HeaderTest.php +++ b/test/classes/HeaderTest.php @@ -16,7 +16,7 @@ require_once 'libraries/core.lib.php'; require_once 'libraries/database_interface.inc.php'; require_once 'libraries/url_generating.lib.php'; require_once 'libraries/vendor_config.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/relation.lib.php'; require_once 'libraries/js_escape.lib.php'; diff --git a/test/classes/MenuTest.php b/test/classes/MenuTest.php index b96130052e..476b0bb3fb 100644 --- a/test/classes/MenuTest.php +++ b/test/classes/MenuTest.php @@ -17,7 +17,7 @@ require_once 'libraries/core.lib.php'; require_once 'libraries/database_interface.inc.php'; require_once 'libraries/url_generating.lib.php'; require_once 'libraries/vendor_config.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/relation.lib.php'; /** diff --git a/test/classes/plugin/auth/AuthenticationCookieTest.php b/test/classes/plugin/auth/AuthenticationCookieTest.php index 14eb83dc55..e61fd75676 100644 --- a/test/classes/plugin/auth/AuthenticationCookieTest.php +++ b/test/classes/plugin/auth/AuthenticationCookieTest.php @@ -16,7 +16,7 @@ require_once 'libraries/config.default.php'; require_once 'libraries/js_escape.lib.php'; require_once 'libraries/sanitizing.lib.php'; require_once 'libraries/database_interface.inc.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/plugins/auth/AuthenticationCookie.php'; /** diff --git a/test/libraries/common/PMA_checkParameters_test.php b/test/libraries/common/PMA_checkParameters_test.php index e77b39e793..1e73e60541 100644 --- a/test/libraries/common/PMA_checkParameters_test.php +++ b/test/libraries/common/PMA_checkParameters_test.php @@ -16,7 +16,7 @@ require_once 'libraries/core.lib.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/sanitizing.lib.php'; /** diff --git a/test/libraries/core/PMA_fatalError_test.php b/test/libraries/core/PMA_fatalError_test.php index bf14d8716d..757b9a003a 100644 --- a/test/libraries/core/PMA_fatalError_test.php +++ b/test/libraries/core/PMA_fatalError_test.php @@ -19,7 +19,7 @@ require_once 'libraries/vendor_config.php'; require_once 'libraries/core.lib.php'; require_once 'libraries/js_escape.lib.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/sanitizing.lib.php'; require_once 'libraries/url_generating.lib.php'; diff --git a/test/libraries/core/PMA_getTableCount_test_dis.php b/test/libraries/core/PMA_getTableCount_test_dis.php index 958a76f6e5..d64cbb0508 100644 --- a/test/libraries/core/PMA_getTableCount_test_dis.php +++ b/test/libraries/core/PMA_getTableCount_test_dis.php @@ -19,7 +19,7 @@ require_once 'libraries/core.lib.php'; require_once 'libraries/js_escape.lib.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/sanitizing.lib.php'; require_once 'libraries/config.default.php'; diff --git a/test/libraries/core/PMA_headerLocation_test.php b/test/libraries/core/PMA_headerLocation_test.php index 68bd419b1b..b10c3f1988 100644 --- a/test/libraries/core/PMA_headerLocation_test.php +++ b/test/libraries/core/PMA_headerLocation_test.php @@ -15,7 +15,7 @@ use PMA\libraries\Theme; require_once 'libraries/vendor_config.php'; require_once 'libraries/core.lib.php'; require_once 'libraries/js_escape.lib.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; require_once 'libraries/sanitizing.lib.php'; require_once 'libraries/url_generating.lib.php'; diff --git a/test/libraries/core/PMA_warnMissingExtension_test.php b/test/libraries/core/PMA_warnMissingExtension_test.php index 5c87fe7869..6c36a7ea32 100644 --- a/test/libraries/core/PMA_warnMissingExtension_test.php +++ b/test/libraries/core/PMA_warnMissingExtension_test.php @@ -14,7 +14,7 @@ use PMA\libraries\Theme; require_once 'libraries/vendor_config.php'; require_once 'libraries/core.lib.php'; -require_once 'libraries/select_lang.lib.php'; +require_once 'libraries/select_lang.inc.php'; diff --git a/test/libraries/select_lang/PMA_langDetails_test.php b/test/libraries/select_lang/PMA_langDetails_test.php index c6bb5c23ab..609cbe1404 100644 --- a/test/libraries/select_lang/PMA_langDetails_test.php +++ b/test/libraries/select_lang/PMA_langDetails_test.php @@ -1,7 +1,7 @@