diff --git a/libraries/sql_query_form.lib.php b/libraries/sql_query_form.lib.php index d884019d49..8bd1f9b48d 100644 --- a/libraries/sql_query_form.lib.php +++ b/libraries/sql_query_form.lib.php @@ -88,7 +88,8 @@ function PMA_sqlQueryForm($query = true, $display_tab = false, $delimiter = ';')
name="sqlform" onsubmit="var save_name = window.opener.parent.frame_content.name; - window.opener.parent.frame_content.name = save_name + ''; + window.opener.parent.frame_content.name + = save_name + ''; this.target = window.opener.parent.frame_content.name; return checkSqlQuery(this)"> ' . "\n"; - echo $html; - // display querybox if ($display_tab === 'full' || $display_tab === 'sql') { - PMA_sqlQueryFormInsert($query, $is_querywindow, $delimiter); + $html .= PMA_getHtmlForSqlQueryFormInsert( + $query, $is_querywindow, $delimiter + ); } // display uploads if ($display_tab === 'files' && $GLOBALS['is_upload']) { - PMA_sqlQueryFormUpload(); + $html .= PMA_getHtmlForSqlQueryFormUpload(); } // Bookmark Support if ($display_tab === 'full' || $display_tab === 'history') { if (! empty($GLOBALS['cfg']['Bookmark'])) { - PMA_sqlQueryFormBookmark(); + $html .= PMA_getHtmlForSqlQueryFormBookmark(); } } // Encoding setting form appended by Y.Kawada if (function_exists('PMA_Kanji_encodingForm')) { - echo PMA_Kanji_encodingForm(); + $html .= PMA_Kanji_encodingForm(); } - $html = '
' . "\n"; + $html .= '' . "\n"; // print an empty div, which will be later filled with // the sql query results by ajax $html .= '
'; @@ -150,17 +151,17 @@ function PMA_sqlQueryForm($query = true, $display_tab = false, $delimiter = ';') } /** - * Prints querybox fieldset + * return HTML for Sql Query Form Insert * * @param string $query query to display in the textarea * @param boolean $is_querywindow if inside querywindow or not * @param string $delimiter default delimiter to use * - * @return void + * @return string * * @usedby PMA_sqlQueryForm() */ -function PMA_sqlQueryFormInsert( +function PMA_getHtmlForSqlQueryFormInsert( $query = '', $is_querywindow = false, $delimiter = ';' ) { // enable auto select text in textarea @@ -219,7 +220,9 @@ function PMA_sqlQueryFormInsert( // Get the list and number of fields // we do a try_query here, because we could be in the query window, // trying to synchonize and the table has not yet been created - $fields_list = $GLOBALS['dbi']->getColumns($db, $GLOBALS['table'], null, true); + $fields_list = $GLOBALS['dbi']->getColumns( + $db, $GLOBALS['table'], null, true + ); $tmp_db_link = ' - - '; } - $html = '' . "\n"; + $html .= '' . "\n"; $html .= '
' . "\n"; $html .= '' . "\n"; @@ -375,77 +375,81 @@ function PMA_sqlQueryFormInsert( . ''; } $html .= '
' . "\n"; - $html .= '' . "\n"; + $html .= '' . "\n"; $html .= '
' . "\n"; $html .= '' . "\n"; - echo $html; + + return $html; } /** - * Prints bookmark fieldset + * return HTML for sql Query Form Bookmark * - * @return void + * @return string * * @usedby PMA_sqlQueryForm() */ -function PMA_sqlQueryFormBookmark() +function PMA_getHtmlForSqlQueryFormBookmark() { $bookmark_list = PMA_Bookmark_getList($GLOBALS['db']); if (! $bookmark_list || count($bookmark_list) < 1) { return; } - echo '
'; - echo ''; - echo __('Bookmarked SQL query') . '' . "\n"; - echo '
'; - echo '' . "\n"; + $html .= '' . "\n"; foreach ($bookmark_list as $key => $value) { - echo '' . "\n"; } //   is required for correct display with styles/line height - echo ' ' . "\n"; - echo '
' . "\n"; - echo '
' . "\n"; - echo __('Variable'); - echo PMA_Util::showDocu('faq', 'faqbookmark'); - echo '' . "\n"; - echo '
' . "\n"; - echo '
' . "\n"; - echo '' .'' . "\n"; - echo '' .'' . "\n"; - echo '' .'' . "\n"; - echo '
' . "\n"; - echo '
' . "\n"; - echo '
' . "\n"; + $html .= '' . "\n"; + $html .= '
' . "\n"; + $html .= '' . "\n"; - echo '
' . "\n"; - echo ''; - echo '
' . "\n"; - echo '
' . "\n"; + $html .= '
' . "\n"; + $html .= ''; + $html .= '
' . "\n"; + $html .= '
' . "\n"; + + return $html; } /** - * Prints bookmark fieldset + * return HTML for Sql Query Form Upload * - * @return void + * @return string * * @usedby PMA_sqlQueryForm() */ -function PMA_sqlQueryFormUpload() +function PMA_getHtmlForSqlQueryFormUpload() { global $timeout_passed, $local_import_file; @@ -466,45 +470,49 @@ function PMA_sqlQueryFormUpload() } // start output - echo '
'; - echo ''; - echo __('Browse your computer:') . ''; - echo '
'; - echo ' '; - echo PMA_Util::getFormattedMaximumUploadSize($GLOBALS['max_upload_size']); + $html = '
'; + $html .= ''; + $html .= __('Browse your computer:') . ''; + $html .= '
'; + $html .= ' '; + $html .= PMA_Util::getFormattedMaximumUploadSize($GLOBALS['max_upload_size']); // some browsers should respect this :) - echo PMA_Util::generateHiddenMaxFileSize($GLOBALS['max_upload_size']) . "\n"; - echo '
'; + $html .= PMA_Util::generateHiddenMaxFileSize($GLOBALS['max_upload_size']) . "\n"; + $html .= '
'; if ($files === false) { - $errors[] = PMA_Message::error(__('The directory you set for upload work cannot be reached.')); + $errors[] = PMA_Message::error( + __('The directory you set for upload work cannot be reached.') + ); } elseif (!empty($files)) { - echo '
'; - echo '' . __('web server upload directory:') .'' . "\n"; - echo '' . "\n"; - echo '
'; + $html .= '
'; + $html .= '' . __('web server upload directory:') .'' . "\n"; + $html .= '' . "\n"; + $html .= '
'; } - echo '
' . "\n"; - echo '
'; + $html .= '
' . "\n"; + $html .= ''; - echo '
'; - echo __('Character set of the file:') . "\n"; - echo PMA_generateCharsetDropdownBox( + $html .= '
'; + $html .= __('Character set of the file:') . "\n"; + $html .= PMA_generateCharsetDropdownBox( PMA_CSDROPDOWN_CHARSET, 'charset_of_file', null, 'utf8', false ); - echo '' . "\n"; - echo '
' . "\n"; - echo '
'; + $html .= '
' . "\n"; + $html .= '
'; foreach ($errors as $error) { - $error->display(); + $html .= $error->getDisplay(); } + + return $html; } ?>