diff --git a/ChangeLog b/ChangeLog index ab3d6a7753..62de324c73 100644 --- a/ChangeLog +++ b/ChangeLog @@ -21,6 +21,7 @@ phpMyAdmin - ChangeLog + Removed the PHP version of the ENUM editor + Patch #3507111 Display distinct results, linked to corresponding data rows + Update to jQuery 1.7.2 +- bug #3507917 [export] JSON has unescaped values for allegedly numeric columns 3.5.1.0 (not yet released) - bug #3510784 [edit] Limit clause ignored when sort order is remembered diff --git a/js/db_structure.js b/js/db_structure.js index 827c0df0f9..5ef5e99875 100644 --- a/js/db_structure.js +++ b/js/db_structure.js @@ -259,7 +259,7 @@ $(document).ready(function() { */ $(".fkc_switch").click(function(event){ if ($("#fkc_checkbox").prop('checked')) { - $("#fkc_checkbox").removeProp('checked'); + $("#fkc_checkbox").prop('checked', false); $("#fkc_status").html(PMA_messages['strForeignKeyCheckDisabled']); return; } diff --git a/js/export.js b/js/export.js index 2982e1ef14..3c8f56a0e3 100644 --- a/js/export.js +++ b/js/export.js @@ -136,13 +136,14 @@ function toggle_sql_include_comments() * For SQL plugin, if "CREATE TABLE options" is checked/unchecked, check/uncheck each of its sub-options */ $(document).ready(function() { - $("#checkbox_sql_create_table_statements").change(function() { - if($("#checkbox_sql_create_table_statements:checked").length == 0) { - $("#checkbox_sql_if_not_exists").removeProp('checked'); - $("#checkbox_sql_auto_increment").removeProp('checked'); - } else { - $("#checkbox_sql_if_not_exists").prop('checked', true); - $("#checkbox_sql_auto_increment").prop('checked', true); + var $create = $("#checkbox_sql_create_table_statements"); + var $create_options = $("#ul_create_table_statements input"); + $create.change(function() { + $create_options.prop('checked', $(this).prop("checked")); + }); + $create_options.change(function() { + if ($create_options.is(":checked")) { + $create.prop('checked', true); } }); }); diff --git a/js/functions.js b/js/functions.js index 30e5511ce0..4d4da3a0c8 100644 --- a/js/functions.js +++ b/js/functions.js @@ -681,16 +681,10 @@ function unMarkAllRows( container_id ) * @param boolean state new value for checkbox (true or false) * @return boolean always true */ -function setCheckboxes( container_id, state ) +function setCheckboxes(container_id, state) { - if (state) { - $("#"+container_id).find("input:checkbox").prop('checked', true); - } - else { - $("#"+container_id).find("input:checkbox").removeProp('checked'); - } - + $("#" + container_id).find("input:checkbox").prop('checked', state); return true; } // end of the 'setCheckboxes()' function diff --git a/js/get_image.js.php b/js/get_image.js.php index b327844bdb..60888c88f7 100644 --- a/js/get_image.js.php +++ b/js/get_image.js.php @@ -68,7 +68,8 @@ function PMA_getImage(image, alternate, attributes) { // this is private alt: '', title: '', - src: 'themes/dot.gif' + src: (typeof PMA_TEST_THEME == 'undefined' ? '' : '../') + + 'themes/dot.gif' }, isSprite: true, attr: function (name, value) { diff --git a/js/import.js b/js/import.js index 04f5217a4d..8b25e85aa2 100644 --- a/js/import.js +++ b/js/import.js @@ -66,11 +66,11 @@ $(document).ready(function() { */ $("#input_import_file").bind("focus change", function() { $("#radio_import_file").prop('checked', true); - $("#radio_local_import_file").removeProp('checked'); + $("#radio_local_import_file").prop('checked', false); }); $("#select_local_import_file").focus(function() { $("#radio_local_import_file").prop('checked', true); - $("#radio_import_file").removeProp('checked'); + $("#radio_import_file").prop('checked', false); }); /** diff --git a/js/makegrid.js b/js/makegrid.js index 1027dbf6bb..459205e0de 100644 --- a/js/makegrid.js +++ b/js/makegrid.js @@ -437,14 +437,13 @@ function PMA_makegrid(t, enableResize, enableReorder, enableVisib, enableGridEdi ) { text += text.length > 0 ? '
' : ''; text += g.markHint; + text += text.length > 0 ? '
' : ''; + text += g.copyHint; } if (g.showColVisibHint && g.colVisibHint) { text += text.length > 0 ? '
' : ''; text += g.colVisibHint; } - text += text.length > 0 ? '
' : ''; - text += g.copyHint; - // hide the hint if no text and the event is mouseenter if (g.qtip) { g.qtip.disable(!text && e.type == 'mouseenter'); @@ -478,7 +477,7 @@ function PMA_makegrid(t, enableResize, enableReorder, enableVisib, enableGridEdi .hide(); }); g.colVisib[n] = 0; - $(g.cList).find('.lDiv div:eq(' + n + ') input').removeProp('checked'); + $(g.cList).find('.lDiv div:eq(' + n + ') input').prop('checked', false); } else { // cannot hide, force the checkbox to stay checked $(g.cList).find('.lDiv div:eq(' + n + ') input').prop('checked', true); diff --git a/libraries/common.inc.php b/libraries/common.inc.php index 86dbf07f28..1f45ef2884 100644 --- a/libraries/common.inc.php +++ b/libraries/common.inc.php @@ -483,6 +483,12 @@ if (! PMA_isValid($_REQUEST['token']) || $_SESSION[' PMA_token '] != $_REQUEST[' /* Possible login form */ 'pma_servername', 'pma_username', 'pma_password' ); + /** + * Allow changing themes in test/theme.php + */ + if (defined('PMA_TEST_THEME')) { + $allow_list[] = 'set_theme'; + } /** * Require cleanup functions */ @@ -596,11 +602,11 @@ require './libraries/select_lang.lib.php'; * this check is done here after loading language files to present errors in locale */ if ($GLOBALS['PMA_Config']->error_config_file) { - $error = '

' . __('Failed to read configuration file') . '

' + $error = '[strong]' . __('Failed to read configuration file') . '[/strong][br][br]' . _('This usually means there is a syntax error in it, please check any errors shown below.') - . '
' - . '
' - . '