Fix broken test
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This commit is contained in:
parent
c6eee3aa1f
commit
b0456096b5
@ -51,7 +51,6 @@ use ReflectionMethod;
|
||||
|
||||
use function date_default_timezone_set;
|
||||
use function function_exists;
|
||||
use function method_exists;
|
||||
|
||||
use const MYSQLI_TYPE_STRING;
|
||||
use const MYSQLI_TYPE_TINY;
|
||||
@ -598,7 +597,7 @@ class TransformationPluginsTest extends AbstractTestCase
|
||||
[new Text_Plain_Longtoipv4(), ['168496141'], '10.11.12.13'],
|
||||
[new Text_Plain_Longtoipv4(), ['my ip'], 'my ip'],
|
||||
[new Text_Plain_Longtoipv4(), ['<my ip>'], '<my ip>'],
|
||||
[new Text_Plain_Iptolong(), ['10.11.12.13'], 168496141],
|
||||
[new Text_Plain_Iptolong(), ['10.11.12.13'], '168496141'],
|
||||
[new Text_Plain_Iptolong(), ['10.11.12.913'], '10.11.12.913'],
|
||||
[new Text_Plain_Iptolong(), ['my ip'], 'my ip'],
|
||||
[new Text_Plain_Iptolong(), ['<my ip>'], '<my ip>'],
|
||||
@ -647,7 +646,7 @@ class TransformationPluginsTest extends AbstractTestCase
|
||||
*
|
||||
* @param TransformationsPlugin $object instance of the plugin
|
||||
* @param array $applyArgs arguments for applyTransformation
|
||||
* @param string|int $transformed the expected output of applyTransformation
|
||||
* @param string $transformed the expected output of applyTransformation
|
||||
* @param bool $success the expected output of isSuccess
|
||||
* @param string $error the expected output of getError
|
||||
* @psalm-param array{string, array, FieldMetadata|null} $applyArgs
|
||||
@ -656,26 +655,22 @@ class TransformationPluginsTest extends AbstractTestCase
|
||||
public function testTransformation(
|
||||
TransformationsPlugin $object,
|
||||
array $applyArgs,
|
||||
string|int $transformed,
|
||||
string $transformed,
|
||||
bool $success = true,
|
||||
string $error = '',
|
||||
): void {
|
||||
$actual = $object->applyTransformation(...$applyArgs);
|
||||
self::assertEquals($transformed, $actual);
|
||||
|
||||
// For output transformation plugins, this method may not exist
|
||||
if (method_exists($object, 'isSuccess')) {
|
||||
self::assertSame(
|
||||
$success,
|
||||
$object->isSuccess(),
|
||||
);
|
||||
}
|
||||
|
||||
// For output transformation plugins, this method may not exist
|
||||
if (! method_exists($object, 'getError')) {
|
||||
if (! ($object instanceof IOTransformationsPlugin)) {
|
||||
return;
|
||||
}
|
||||
|
||||
self::assertSame(
|
||||
$success,
|
||||
$object->isSuccess(),
|
||||
);
|
||||
|
||||
self::assertSame(
|
||||
$error,
|
||||
$object->getError(),
|
||||
|
||||
Loading…
Reference in New Issue
Block a user