diff --git a/libraries/Scripts.class.php b/libraries/Scripts.class.php index 957ffedf9c..2878207271 100644 --- a/libraries/Scripts.class.php +++ b/libraries/Scripts.class.php @@ -73,10 +73,14 @@ class PMA_Scripts $scripts[] = "scripts[]=" . $value['filename']; } } + $separator = PMA_URL_getArgSeparator(); + $url = 'js/get_scripts.js.php' + . PMA_URL_getCommon(array(), 'none') + . $separator . implode($separator, $scripts); + $static_scripts = sprintf( - '', - PMA_URL_getCommon(array(), 'none'), implode("&", $scripts) + '', + htmlspecialchars($url) ); return $static_scripts . $dynamic_scripts; } diff --git a/test/classes/PMA_Scripts_test.php b/test/classes/PMA_Scripts_test.php index d59b8a83a1..b5295ac633 100644 --- a/test/classes/PMA_Scripts_test.php +++ b/test/classes/PMA_Scripts_test.php @@ -11,6 +11,7 @@ require_once 'libraries/Scripts.class.php'; require_once 'libraries/js_escape.lib.php'; +require_once 'libraries/url_generating.lib.php'; /** * Tests for Script.class.php @@ -78,7 +79,7 @@ class PMA_Scripts_Test extends PHPUnit_Framework_TestCase { $this->assertEquals( '', + . '&token=token&scripts[]=common.js">', $this->_callPrivateFunction( '_includeFiles', array( @@ -107,7 +108,7 @@ class PMA_Scripts_Test extends PHPUnit_Framework_TestCase $this->assertRegExp( '@