gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18858 from kamil-tekiela/Optimize-MultiTableQuery

Browse Source 
Optimize MultiTableQuery
This commit is contained in:
Maurício Meneghini Fauth 2023-12-23 20:26:42 -03:00 committed by GitHub
commit b7efa525d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/Database/MultiTableQuery.php
View File

@ -19,26 +19,19 @@ use PhpMyAdmin\Transformations;
use PhpMyAdmin\Url;
use function md5;
use function sprintf;
/**
* Class to handle database Multi-table querying
*/
class MultiTableQuery
{
/**
* Table names
*
* @var array<int, string>
*/
private array $tables;
public function __construct(
private DatabaseInterface $dbi,
public Template $template,
private string $db,
private int $defaultNoOfColumns = 3,
) {
$this->tables = $this->dbi->getTables($this->db);
}
/**
@ -48,10 +41,17 @@ class MultiTableQuery
*/
public function getFormHtml(): string
{
$columnsInTables = $this->dbi->query(sprintf(
'SELECT TABLE_NAME, COLUMN_NAME FROM information_schema.columns WHERE table_schema = %s',
$this->dbi->quoteString($this->db),
));
$tables = [];
foreach ($this->tables as $table) {
$tables[$table]['hash'] = md5($table);
$tables[$table]['columns'] = $this->dbi->getColumnNames($this->db, $table);
/** @var array{TABLE_NAME:string, COLUMN_NAME:string} $column */
foreach ($columnsInTables as $column) {
$table = $column['TABLE_NAME'];
$tables[$table]['hash'] ??= md5($table);
$tables[$table]['columns'][] = $column['COLUMN_NAME'];
}
return $this->template->render('database/multi_table_query/form', [