diff --git a/libraries/classes/Tracking.php b/libraries/classes/Tracking.php index a7e369b199..826f96c178 100644 --- a/libraries/classes/Tracking.php +++ b/libraries/classes/Tracking.php @@ -101,7 +101,7 @@ class Tracking array $selected, $type = 'both' ) { - return $this->template->render('table/tracking/create_version', [ + return $this->template->render('create_tracking_version', [ 'url_query' => $urlQuery, 'last_version' => $lastVersion, 'db' => $db, @@ -156,129 +156,62 @@ class Tracking } /** - * Function to get html for displaying last version number + * Function to get html for main page parts that do not use $_REQUEST * - * @param array $sql_result sql result - * @param int $last_version last version - * @param array $url_params url parameters - * @param string $url_query url query + * @param string $urlQuery url query + * @param array $urlParams url parameters * @param string $pmaThemeImage path to theme's image folder - * @param string $text_dir text direction + * @param string $textDir text direction + * @param int $lastVersion last tracking version * * @return string */ - public function getHtmlForTableVersionDetails( - $sql_result, - $last_version, - array $url_params, - $url_query, + public function getHtmlForMainPage( + $urlQuery, + $urlParams, $pmaThemeImage, - $text_dir + $textDir, + $lastVersion = null ) { - $tracking_active = false; - - $html = '
'; - - if ($tracking_active) { - $html .= $this->getHtmlForActivateDeactivateTracking( - 'deactivate', - $url_query, - $last_version - ); - } else { - $html .= $this->getHtmlForActivateDeactivateTracking( - 'activate', - $url_query, - $last_version - ); - } - - return $html; } /** @@ -314,36 +247,6 @@ class Tracking return $relation->queryAsControlUser($sql_query); } - /** - * Function to get html for selectable table rows - * - * @param array $selectableTablesSqlResult sql results for selectable rows - * @param string $urlQuery url query - * - * @return string - */ - public function getHtmlForSelectableTables( - $selectableTablesSqlResult, - $urlQuery - ) { - $entries = []; - while ($entry = $GLOBALS['dbi']->fetchArray($selectableTablesSqlResult)) { - $entry['is_tracked'] = Tracker::isTracked( - $entry['db_name'], - $entry['table_name'] - ); - $entries[] = $entry; - } - - return $this->template->render('table/tracking/selectable_tables', [ - 'url_query' => $urlQuery, - 'db' => $GLOBALS['db'], - 'table' => $GLOBALS['table'], - 'entries' => $entries, - 'selected_table' => isset($_REQUEST['table']) ? $_REQUEST['table'] : null, - ]); - } - /** * Function to get html for tracking report and tracking report export * diff --git a/tbl_tracking.php b/tbl_tracking.php index e5b1771e35..d43a43d47d 100644 --- a/tbl_tracking.php +++ b/tbl_tracking.php @@ -94,7 +94,7 @@ if (isset($_REQUEST['report_export']) $tracking->exportAsFileDownload($entries); } -$html = '