diff --git a/ChangeLog b/ChangeLog index 975b173306..02d02217d0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,9 @@ phpMyAdmin - ChangeLog ====================== +4.2.10.1 (not yet released) +- bug #4562 [security] XSS in debug SQL output + 4.2.10.0 (2014-10-11) - bug #4361 Can't change font size (when config.inc.php not present) - bug #4542 Tab key in column name not shown diff --git a/libraries/DatabaseInterface.class.php b/libraries/DatabaseInterface.class.php index c126c17d5d..c7c5171420 100644 --- a/libraries/DatabaseInterface.class.php +++ b/libraries/DatabaseInterface.class.php @@ -139,10 +139,11 @@ class PMA_DatabaseInterface $_SESSION['debug']['queries'][$hash] = array(); if ($result == false) { $_SESSION['debug']['queries'][$hash]['error'] - = '' . mysqli_error($link) . ''; + = '' + . htmlspecialchars(mysqli_error($link)) . ''; } $_SESSION['debug']['queries'][$hash]['count'] = 1; - $_SESSION['debug']['queries'][$hash]['query'] = $query; + $_SESSION['debug']['queries'][$hash]['query'] = htmlspecialchars($query); $_SESSION['debug']['queries'][$hash]['time'] = $time; }