From bed6fb4ebdc5f83ed30fe3e83e380baf24ed2fa5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Mon, 27 Nov 2017 14:24:42 +0100 Subject: [PATCH] Avois passing extension to Util::getImage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We do not use it anyway for quite some time and this way it's less processing to generate the img tag. Signed-off-by: Michal Čihař --- index.php | 12 +-- libraries/classes/CentralColumns.php | 10 +-- .../classes/Config/FormDisplayTemplate.php | 8 +- libraries/classes/Console.php | 2 +- .../Server/ServerDatabasesController.php | 4 +- .../Table/TableSearchController.php | 10 +-- .../Table/TableStructureController.php | 31 ++++--- libraries/classes/Display/Export.php | 2 +- libraries/classes/Display/Results.php | 34 ++++---- libraries/classes/Footer.php | 2 +- libraries/classes/Header.php | 4 +- libraries/classes/Index.php | 4 +- libraries/classes/InsertEdit.php | 2 +- libraries/classes/Menu.php | 84 +++++++++---------- libraries/classes/Message.php | 6 +- .../classes/Navigation/NavigationHeader.php | 14 ++-- .../classes/Navigation/NavigationTree.php | 8 +- libraries/classes/Navigation/Nodes/Node.php | 4 +- .../classes/Navigation/Nodes/NodeColumn.php | 2 +- .../Navigation/Nodes/NodeColumnContainer.php | 4 +- .../classes/Navigation/Nodes/NodeDatabase.php | 4 +- .../Navigation/Nodes/NodeDatabaseChild.php | 2 +- .../Nodes/NodeDatabaseContainer.php | 2 +- .../classes/Navigation/Nodes/NodeEvent.php | 2 +- .../Navigation/Nodes/NodeEventContainer.php | 4 +- .../classes/Navigation/Nodes/NodeFunction.php | 2 +- .../Nodes/NodeFunctionContainer.php | 7 +- .../classes/Navigation/Nodes/NodeIndex.php | 2 +- .../Navigation/Nodes/NodeIndexContainer.php | 4 +- .../Navigation/Nodes/NodeProcedure.php | 5 +- .../Nodes/NodeProcedureContainer.php | 7 +- .../classes/Navigation/Nodes/NodeTable.php | 22 ++--- .../Navigation/Nodes/NodeTableContainer.php | 4 +- .../classes/Navigation/Nodes/NodeTrigger.php | 2 +- .../Navigation/Nodes/NodeTriggerContainer.php | 4 +- .../classes/Navigation/Nodes/NodeView.php | 2 +- .../Navigation/Nodes/NodeViewContainer.php | 4 +- libraries/classes/Normalization.php | 2 +- libraries/classes/Operations.php | 10 +-- libraries/classes/RecentFavoriteTable.php | 2 +- libraries/classes/Rte/RteList.php | 4 +- libraries/classes/Sanitize.php | 2 +- libraries/classes/Server/Privileges.php | 24 +++--- libraries/classes/Server/Status/Advisor.php | 2 +- libraries/classes/Server/Status/Monitor.php | 14 ++-- libraries/classes/Server/Status/Processes.php | 12 +-- libraries/classes/Server/UserGroups.php | 8 +- libraries/classes/Sql.php | 2 +- libraries/classes/Tracking.php | 38 ++++----- libraries/classes/Util.php | 64 +++++++------- libraries/user_preferences.inc.php | 12 +-- tbl_change.php | 2 +- templates/database/create_table.twig | 2 +- .../print_view_data_dictionary_link.twig | 4 +- .../structure/structure_table_row.twig | 4 +- .../database/structure/tracking_icon.twig | 4 +- templates/display/import/options.twig | 2 +- templates/privileges/add_user_fieldset.twig | 2 +- .../privileges/delete_user_fieldset.twig | 2 +- templates/server/databases/create.twig | 6 +- .../server/databases/databases_footer.twig | 2 +- templates/server/databases/table_header.twig | 4 +- templates/server/databases/table_row.twig | 2 +- templates/server/engines/engine.twig | 2 +- templates/server/sub_page_header.twig | 18 ++-- templates/server/variables/link_template.twig | 6 +- templates/server/variables/variable_row.twig | 4 +- templates/table/relation/foreign_key_row.twig | 2 +- templates/table/search/input_box.twig | 2 +- templates/table/secondary_tabs.twig | 4 +- .../structure/actions_in_table_structure.twig | 4 +- templates/table/structure/add_column.twig | 2 +- .../structure/check_all_table_column.twig | 20 ++--- .../table/structure/display_structure.twig | 20 ++--- .../table/structure/display_table_stats.twig | 2 +- .../structure/optional_action_links.twig | 12 +-- .../Server/ServerVariablesControllerTest.php | 4 +- test/classes/Display/CreateTableTest.php | 2 +- test/classes/Server/PrivilegesTest.php | 2 +- test/classes/UtilTest.php | 46 +++++----- 80 files changed, 335 insertions(+), 375 deletions(-) diff --git a/index.php b/index.php index d66365ce9b..f85e000758 100644 --- a/index.php +++ b/index.php @@ -184,7 +184,7 @@ if ($server > 0 || count($cfg['Servers']) > 1 || ($server == 0 && count($cfg['Servers']) == 1))) ) { echo '
  • '; - echo Util::getImage('s_host.png') , " " + echo Util::getImage('s_host') , " " , Select::render(true, true); echo '
  • '; } @@ -200,7 +200,7 @@ if ($server > 0 || count($cfg['Servers']) > 1 if ($cfg['ShowChgPassword']) { $conditional_class = 'ajax'; Core::printListItem( - Util::getImage('s_passwd.png') . " " . __( + Util::getImage('s_passwd') . " " . __( 'Change password' ), 'li_change_password', @@ -217,7 +217,7 @@ if ($server > 0 || count($cfg['Servers']) > 1 echo '
    ' , "\n" . Url::getHiddenInputs(null, null, 4, 'collation_connection') . '