From 7c343b997f37f17a0ed52a72ad63e49cf2b09639 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 12:50:42 +0200 Subject: [PATCH 1/6] Use HTML5 placeholder attribute for fast-filter inputbox --- libraries/navigation/NavigationTree.class.php | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/libraries/navigation/NavigationTree.class.php b/libraries/navigation/NavigationTree.class.php index 99be9eb382..bac5b677d4 100644 --- a/libraries/navigation/NavigationTree.class.php +++ b/libraries/navigation/NavigationTree.class.php @@ -1031,7 +1031,14 @@ class PMA_NavigationTree $retval .= "
"; $retval .= PMA_getHiddenFields($url_params); $retval .= ""; + // allow html5 placeholder attribute + $placeholder_key = 'value'; + if (PMA_USR_BROWSER_AGENT !== 'IE' + || PMA_USR_BROWSER_VER > 9 + ) { + $placeholder_key = 'placeholder'; + } + $retval .= " $placeholder_key='" . __('filter databases by name') . "' />"; $retval .= "X"; $retval .= "
"; $retval .= ""; @@ -1057,7 +1064,14 @@ class PMA_NavigationTree $retval .= "
"; $retval .= PMA_getHiddenFields($url_params); $retval .= ""; + // allow html5 placeholder attribute + $placeholder_key = 'value'; + if (PMA_USR_BROWSER_AGENT !== 'IE' + || PMA_USR_BROWSER_VER > 9 + ) { + $placeholder_key = 'placeholder'; + } + $retval .= " $placeholder_key='" . __('filter items by name') . "' />"; $retval .= "X"; $retval .= "
"; $retval .= ""; From 0458afab28630ee2a132a72889f18821f70f35b6 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 13:00:21 +0200 Subject: [PATCH 2/6] Add HTML class for current browser and version --- libraries/Header.class.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libraries/Header.class.php b/libraries/Header.class.php index c248bbe792..a465daa69c 100644 --- a/libraries/Header.class.php +++ b/libraries/Header.class.php @@ -484,7 +484,9 @@ class PMA_Header $dir = $GLOBALS['text_dir']; $retval = ""; - $retval .= ""; + $retval .= ""; return $retval; } From 1de35ef88bf805d7c1dfae1a2c2dcac250170cd2 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 13:08:58 +0200 Subject: [PATCH 3/6] Detect Firefox browser --- libraries/Config.class.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libraries/Config.class.php b/libraries/Config.class.php index 91338f1a69..9b59a02d41 100644 --- a/libraries/Config.class.php +++ b/libraries/Config.class.php @@ -242,6 +242,14 @@ class PMA_Config 'PMA_USR_BROWSER_VER', $log_version[1] . '.' . $log_version2[1] ); $this->set('PMA_USR_BROWSER_AGENT', 'SAFARI'); + // Firefox + } elseif (! strstr($HTTP_USER_AGENT, 'compatible') + && preg_match('@Firefox/([\w.]+)@', $HTTP_USER_AGENT, $log_version2) + ) { + $this->set( + 'PMA_USR_BROWSER_VER', $log_version2[1] + ); + $this->set('PMA_USR_BROWSER_AGENT', 'FIREFOX'); } elseif (preg_match('@rv:1.9(.*)Gecko@', $HTTP_USER_AGENT)) { $this->set('PMA_USR_BROWSER_VER', '1.9'); $this->set('PMA_USR_BROWSER_AGENT', 'GECKO'); From b49cc419401bb41f77c052e4d8d0f382c7b1ae3d Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 13:19:01 +0200 Subject: [PATCH 4/6] Detect Internet Explorer 10 and 11 --- libraries/Config.class.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/Config.class.php b/libraries/Config.class.php index 9b59a02d41..8d0275ac06 100644 --- a/libraries/Config.class.php +++ b/libraries/Config.class.php @@ -189,11 +189,11 @@ class PMA_Config $this->set('PMA_USR_BROWSER_VER', $log_version[2]); $this->set('PMA_USR_BROWSER_AGENT', 'OPERA'); } elseif (preg_match( - '@MSIE ([0-9].[0-9]{1,2})@', + '@(MS)?IE ([0-9]{1,2}.[0-9]{1,2})@', $HTTP_USER_AGENT, $log_version )) { - $this->set('PMA_USR_BROWSER_VER', $log_version[1]); + $this->set('PMA_USR_BROWSER_VER', $log_version[2]); $this->set('PMA_USR_BROWSER_AGENT', 'IE'); } elseif (preg_match( '@OmniWeb/([0-9].[0-9]{1,2})@', From 765fa81a82407531d368e157caf73dc22cc44652 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 13:46:57 +0200 Subject: [PATCH 5/6] Disable custom fast-filter clear button for IE10+ --- themes/original/css/navigation.css.php | 8 ++++++++ themes/pmahomme/css/navigation.css.php | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/themes/original/css/navigation.css.php b/themes/original/css/navigation.css.php index 902e60e488..5ec999a93c 100644 --- a/themes/original/css/navigation.css.php +++ b/themes/original/css/navigation.css.php @@ -207,6 +207,14 @@ li.fast_filter span { font-weight: bold; color: #800; } +/* IE10+ has its own reset X */ +html.ie li.fast_filter span { + display: none; +} +html.ie.ie9 li.fast_filter span, +html.ie.ie8 li.fast_filter span { + display: auto; +} li.fast_filter.db_fast_filter { border: 0; } diff --git a/themes/pmahomme/css/navigation.css.php b/themes/pmahomme/css/navigation.css.php index eae6fa74e7..a5592a8634 100644 --- a/themes/pmahomme/css/navigation.css.php +++ b/themes/pmahomme/css/navigation.css.php @@ -203,6 +203,14 @@ li.fast_filter span { font-weight: bold; color: #800; } +/* IE10+ has its own reset X */ +html.ie li.fast_filter span { + display: none; +} +html.ie.ie9 li.fast_filter span, +html.ie.ie8 li.fast_filter span { + display: auto; +} li.fast_filter.db_fast_filter { border: 0; } From 257afb8b6fc4645d2151e67604e81d5ec861c232 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 13:51:15 +0200 Subject: [PATCH 6/6] Don't let fast-filter input placeholder flow behind custom clear button --- themes/original/css/navigation.css.php | 2 +- themes/pmahomme/css/navigation.css.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/themes/original/css/navigation.css.php b/themes/original/css/navigation.css.php index 5ec999a93c..54ea35f41c 100644 --- a/themes/original/css/navigation.css.php +++ b/themes/original/css/navigation.css.php @@ -196,7 +196,7 @@ li.fast_filter { border-: 1px solid #666; } li.fast_filter input { - padding-: .4em; + padding-: 1.7em; width: 100%; } li.fast_filter span { diff --git a/themes/pmahomme/css/navigation.css.php b/themes/pmahomme/css/navigation.css.php index a5592a8634..905a4285f8 100644 --- a/themes/pmahomme/css/navigation.css.php +++ b/themes/pmahomme/css/navigation.css.php @@ -192,7 +192,7 @@ li.fast_filter { border-: 1px solid #666; } li.fast_filter input { - padding-: .4em; + padding-: 1.7em; width: 100%; } li.fast_filter span {