diff --git a/pmd_pdf.php b/pmd_pdf.php index 725d44c202..9a1adb9f5a 100644 --- a/pmd_pdf.php +++ b/pmd_pdf.php @@ -1,6 +1,7 @@ ' . __('Export/Import to scale:'); diff --git a/pmd_relation_new.php b/pmd_relation_new.php index 9a5f17c9b7..60247edf1a 100644 --- a/pmd_relation_new.php +++ b/pmd_relation_new.php @@ -1,6 +1,7 @@ fetchAssoc($result)) { $index_array2[$row['Column_name']] = 1; } diff --git a/pmd_relation_upd.php b/pmd_relation_upd.php index 1b0285d5eb..9dff0579b8 100644 --- a/pmd_relation_upd.php +++ b/pmd_relation_upd.php @@ -1,6 +1,7 @@ $value) { } //---------------------------------------------------------------------------- -function PMD_err_sav() +/** + * Error handler + * + * @return void + */ +function PMD_errorSave() { global $die_save_pos; // if this file included if (! empty($die_save_pos)) { header("Content-Type: text/xml; charset=utf-8"); header("Cache-Control: no-cache"); - die(''); + die( + '' + ); } } @@ -72,7 +82,9 @@ if (! empty($die_save_pos)) { header("Content-Type: text/xml; charset=utf-8"); header("Cache-Control: no-cache"); ?> - '> + '> diff --git a/schema_edit.php b/schema_edit.php index 498ccb7afb..8b79774cca 100644 --- a/schema_edit.php +++ b/schema_edit.php @@ -1,6 +1,7 @@ selectDb($db); if (isset($where_clause)) { $result = $GLOBALS['dbi']->query( - 'SELECT * FROM ' . PMA_Util::backquote($table) . ' WHERE ' . $where_clause . ';', + 'SELECT * FROM ' . PMA_Util::backquote($table) + . ' WHERE ' . $where_clause . ';', null, PMA_DatabaseInterface::QUERY_STORE ); diff --git a/user_password.php b/user_password.php index 252302bda8..6e9c4c8a77 100644 --- a/user_password.php +++ b/user_password.php @@ -68,8 +68,8 @@ exit; /** * Send the message as an ajax request * - * @param array $change_password_message - * @param string $sql_query + * @param array $change_password_message Message to display + * @param string $sql_query SQL query executed * * @return void */ @@ -120,9 +120,9 @@ function PMA_setChangePasswordMsg() /** * Change the password * - * @param string $password - * @param string $message - * @param array $change_password_message + * @param string $password + * @param string $message + * @param array $change_password_message Message to show * * @return void */ @@ -133,7 +133,7 @@ function PMA_changePassword($password, $message, $change_password_message) $hashing_function = PMA_changePassHashingFunction(); $sql_query = 'SET password = ' . (($password == '') ? '\'\'' : $hashing_function . '(\'***\')'); - PMA_ChangePassUrlParamsAndSubmitQuery( + PMA_changePassUrlParamsAndSubmitQuery( $password, $_url_params, $sql_query, $hashing_function ); @@ -167,7 +167,7 @@ function PMA_changePassHashingFunction() * * @return void */ -function PMA_ChangePassUrlParamsAndSubmitQuery( +function PMA_changePassUrlParamsAndSubmitQuery( $password, $_url_params, $sql_query, $hashing_function ) { $err_url = 'user_password.php' . PMA_generate_common_url($_url_params); diff --git a/view_create.php b/view_create.php index 0a2cae5f85..743329f3b8 100644 --- a/view_create.php +++ b/view_create.php @@ -31,7 +31,7 @@ $view_with_options = array( 'LOCAL' ); -$view_sql_security_options = array( +$view_security_options = array( 'DEFINER', 'INVOKER' ); @@ -60,7 +60,7 @@ if (isset($_REQUEST['createview']) || isset($_REQUEST['alterview'])) { } if (isset($_REQUEST['view']['sql_security'])) { - if (in_array($_REQUEST['view']['sql_security'], $view_sql_security_options)) { + if (in_array($_REQUEST['view']['sql_security'], $view_security_options)) { $sql_query .= $sep . ' SQL SECURITY ' . $_REQUEST['view']['sql_security']; } @@ -211,7 +211,7 @@ $htmlString .= '' . __('Definer') . '' $htmlString .= 'SQL SECURITY' . '