diff --git a/libraries/common.lib.php b/libraries/common.lib.php
index e908d9e1a5..eeae7c356e 100644
--- a/libraries/common.lib.php
+++ b/libraries/common.lib.php
@@ -980,19 +980,14 @@ if (typeof(window.parent) != 'undefined'
*
* @access public
*/
-function PMA_showMessage($message, $sql_query = null, $type = 'notice',
+function PMA_showMessage(
+ $message,
+ $sql_query = null,
+ $type = 'notice',
$is_view = false
) {
- /*
- * PMA_ajaxResponse uses this function to collect the string of HTML generated
- * for showing the message. Use output buffering to collect it and return it
- * in a string. In some special cases on sql.php, buffering has to be disabled
- * and hence we check with $GLOBALS['buffer_message']
- */
- if ($GLOBALS['is_ajax_request'] == true && ! isset($GLOBALS['buffer_message'])) {
- ob_start();
- }
global $cfg;
+ $retval = '';
if (null === $sql_query) {
if (! empty($GLOBALS['display_query'])) {
@@ -1009,7 +1004,7 @@ function PMA_showMessage($message, $sql_query = null, $type = 'notice',
}
if (isset($GLOBALS['using_bookmark_message'])) {
- $GLOBALS['using_bookmark_message']->display();
+ $retval .= $GLOBALS['using_bookmark_message']->getDisplay();
unset($GLOBALS['using_bookmark_message']);
}
@@ -1018,13 +1013,13 @@ function PMA_showMessage($message, $sql_query = null, $type = 'notice',
if (! $is_view && strlen($GLOBALS['table']) && $cfg['ShowTooltip']) {
$tooltip = PMA_Table::sGetToolTip($GLOBALS['db'], $GLOBALS['table']);
$uni_tbl = PMA_jsFormat($GLOBALS['db'] . '.' . $GLOBALS['table'], false);
- echo "\n";
- echo '' . "\n";
+ $retval .= '//]]>' . "\n";
+ $retval .= '' . "\n";
} // end if ... elseif
// Checks if the table needs to be repaired after a TRUNCATE query.
@@ -1043,7 +1038,7 @@ function PMA_showMessage($message, $sql_query = null, $type = 'notice',
// In an Ajax request, $GLOBALS['cell_align_left'] may not be defined. Hence,
// check for it's presence before using it
- echo '
';
// avoid displaying a Profiling checkbox that could
// be checked, which would reexecute an INSERT, for example
if (! empty($refresh_link)) {
- PMA_profilingCheckbox($sql_query);
+ $retval .= PMA_getProfilingForm($sql_query);
}
// if needed, generate an invisible form that contains controls for the
// Inline link; this way, the behavior of the Inline link does not
// depend on the profiling support or on the refresh link
if (empty($refresh_link) || ! PMA_profilingSupported()) {
- echo '';
+ $retval .= '';
}
// in the tools div, only display the Inline link when not in ajax
@@ -1329,7 +1323,7 @@ function PMA_showMessage($message, $sql_query = null, $type = 'notice',
) {
// see in js/functions.js the jQuery code attached to id inline_edit
// document.write conflicts with jQuery, hence used $().append()
- echo "";
}
- echo $edit_link . $explain_link . $php_link . $refresh_link . $validate_link;
- echo '