From c38b78defbcc15bcac84fc4678d5d4f1adffdc28 Mon Sep 17 00:00:00 2001 From: Hugues Peccatte Date: Sat, 15 Mar 2014 11:46:16 +0100 Subject: [PATCH] PHPCS updates. Signed-off-by: Hugues Peccatte --- db_search.php | 7 +- .../plugins/auth/swekey/swekey.auth.lib.php | 3 +- pmd_general.php | 11 ++- test/engines/PMA_StorageEngine_pbxt_test.php | 5 ++ test/libraries/PMA_GIS_modifyQuery_test.php | 5 ++ test/libraries/PMA_SQL_validator_test.php | 42 ++++++++- test/libraries/PMA_bookmark_test.php | 6 +- test/libraries/PMA_build_html_for_db_test.php | 5 ++ test/libraries/PMA_escapeJsString_test.php | 5 ++ test/libraries/PMA_generateCommonUrl_test.php | 5 ++ test/libraries/PMA_js_escape_test.php | 5 ++ test/libraries/PMA_prettyPrint_test.php | 5 ++ test/libraries/PMA_sanitize_test.php | 5 ++ .../common/PMA_browseUploadFile_test.php | 12 ++- .../common/PMA_buildActionTitles_test.php | 17 +++- .../common/PMA_checkParameters_test.php | 21 +++++ .../PMA_contains_nonprintable_ascii_test.php | 4 +- .../PMA_convert_bit_default_value_test.php | 15 +++- ...PMA_extractValueFromFormattedSize_test.php | 54 +++++++----- test/libraries/common/PMA_formatSql_test.php | 16 ++++ .../PMA_generateHiddenMaxFileSize_test.php | 17 +++- .../libraries/common/PMA_getCheckbox_test.php | 42 ++++++++- .../common/PMA_getDivForSliderEffect_test.php | 27 +++++- .../libraries/common/PMA_getDropdown_test.php | 30 ++++++- ...PMA_getFormattedMaximumUploadSize_test.php | 6 ++ test/libraries/common/PMA_getIcon_test.php | 37 +++++++- .../common/PMA_getRadioFields_test.php | 88 ++++++++++++++++--- .../common/PMA_getTitleForTarget_test.php | 19 +++- test/libraries/common/PMA_pow_test.php | 41 +++++++++ test/libraries/common/PMA_showDocu_test.php | 16 ++++ .../common/PMA_showMessage_test_disabled.php | 16 ++++ .../libraries/common/PMA_showPHPDocu_test.php | 21 ++++- .../common/PMA_unsupportedDatatypes_test.php | 12 ++- test/libraries/core/PMA_array_test.php | 7 ++ .../core/PMA_checkPageValidity_test.php | 59 +++++++------ test/libraries/core/PMA_fatalError_test.php | 24 +++++ test/libraries/core/PMA_getLinks_test.php | 5 ++ .../core/PMA_getTableCount_test_dis.php | 17 +++- .../libraries/core/PMA_get_real_size_test.php | 54 +++++++----- .../core/PMA_headerLocation_test.php | 5 ++ test/libraries/core/PMA_ifSetOr_test.php | 28 ++++++ test/libraries/core/PMA_isValid_test.php | 5 ++ .../core/PMA_warnMissingExtension_test.php | 21 +++++ .../rte/PMA_RTN_getEditorForm_test.php | 5 ++ .../select_lang/PMA_langList_test.php | 25 +++++- .../select_lang/PMA_langName_test.php | 29 +++++- 46 files changed, 772 insertions(+), 132 deletions(-) diff --git a/db_search.php b/db_search.php index fe80d4ea8e..8d5d80f346 100644 --- a/db_search.php +++ b/db_search.php @@ -54,9 +54,10 @@ if ($GLOBALS['is_ajax_request'] == true && empty($_REQUEST['ajax_page_request']) } // Display the search form -$response->addHTML('
' - . '
' - . '
'); +$response->addHTML( + '
' + . '
' +); $response->addHTML($db_search->getSelectionForm($url_params)); $response->addHTML($db_search->_getResultDivs()); ?> diff --git a/libraries/plugins/auth/swekey/swekey.auth.lib.php b/libraries/plugins/auth/swekey/swekey.auth.lib.php index 05d02f4abb..7464f030f2 100644 --- a/libraries/plugins/auth/swekey/swekey.auth.lib.php +++ b/libraries/plugins/auth/swekey/swekey.auth.lib.php @@ -172,7 +172,8 @@ function Swekey_Auth_error() if (file_exists($caFile)) { Swekey_SetCAFile($caFile); } elseif (! empty($caFile) - && (substr($_SESSION['SWEKEY']['CONF_SERVER_CHECK'], 0, 8) == "https://")) { + && (substr($_SESSION['SWEKEY']['CONF_SERVER_CHECK'], 0, 8) == "https://") + ) { return "Internal Error: CA File $caFile not found"; } diff --git a/pmd_general.php b/pmd_general.php index b041bbbbee..3abe218d4a 100644 --- a/pmd_general.php +++ b/pmd_general.php @@ -241,7 +241,7 @@ for ($i = 0; $i < count($GLOBALS['PMD']["TABLE_NAME"]); $i++) { px; top: ',0, )" onmouseout="Table_onover('',1,)"> - '; - echo $GLOBALS['PMD_OUT']["TABLE_NAME_SMALL"][$i]; - ?> + . + + + {$name}($arguments); } + + /** + * Mock the SOAP_Client::openSession method + * + * @param array $args Arguments + * + * @return Session + */ public function openSession($args) { $session = new Session; @@ -111,6 +136,14 @@ class SOAP_Client $session->sessionKey = "sessionKey"; return $session; } + + /** + * Mock the SOAP_Client::validateSQL method + * + * @param array $args Arguments + * + * @return Session + */ public function validateSQL($args) { $session = new Session; @@ -126,7 +159,12 @@ class SOAP_Client } } -//Mock return Session class + +/** + * Mock return Session class + * + * @package PhpMyAdmin-test + */ class Session { var $target = null; diff --git a/test/libraries/PMA_bookmark_test.php b/test/libraries/PMA_bookmark_test.php index f298609913..0e6335a76a 100644 --- a/test/libraries/PMA_bookmark_test.php +++ b/test/libraries/PMA_bookmark_test.php @@ -15,6 +15,11 @@ require_once 'libraries/database_interface.inc.php'; require_once 'libraries/Tracker.class.php'; require_once 'libraries/relation.lib.php'; +/** + * tests for bookmark.lib.php + * + * @package PhpMyAdmin-test + */ class PMA_Bookmark_Test extends PHPUnit_Framework_TestCase { /** @@ -26,7 +31,6 @@ class PMA_Bookmark_Test extends PHPUnit_Framework_TestCase */ public function setUp() { - $GLOBALS['cfg']['Server']['user'] = 'root'; $GLOBALS['cfg']['Server']['pmadb'] = 'phpmyadmin'; $GLOBALS['cfg']['Server']['bookmarktable'] = 'pma_bookmark'; diff --git a/test/libraries/PMA_build_html_for_db_test.php b/test/libraries/PMA_build_html_for_db_test.php index 62a63bcf17..a2a03f5c34 100644 --- a/test/libraries/PMA_build_html_for_db_test.php +++ b/test/libraries/PMA_build_html_for_db_test.php @@ -21,6 +21,11 @@ require_once 'libraries/Tracker.class.php'; require_once 'libraries/Types.class.php'; require_once 'libraries/mysql_charsets.inc.php'; +/** + * tests for build_html_for_db.lib.php + * + * @package PhpMyAdmin-test + */ class PMA_BuildHtmlForDb_Test extends PHPUnit_Framework_TestCase { /** diff --git a/test/libraries/PMA_escapeJsString_test.php b/test/libraries/PMA_escapeJsString_test.php index a96b12f9bd..91cb02f2f3 100644 --- a/test/libraries/PMA_escapeJsString_test.php +++ b/test/libraries/PMA_escapeJsString_test.php @@ -11,6 +11,11 @@ */ require_once 'libraries/js_escape.lib.php'; +/** + * Test for javascript escaping. + * + * @package PhpMyAdmin-test + */ class PMA_EscapeJsString_Test extends PHPUnit_Framework_TestCase { /** diff --git a/test/libraries/PMA_generateCommonUrl_test.php b/test/libraries/PMA_generateCommonUrl_test.php index 10a30ca2fe..23929691c4 100644 --- a/test/libraries/PMA_generateCommonUrl_test.php +++ b/test/libraries/PMA_generateCommonUrl_test.php @@ -12,6 +12,11 @@ require_once 'libraries/core.lib.php'; require_once 'libraries/url_generating.lib.php'; +/** + * tests for PMA_URL_getCommon() + * + * @package PhpMyAdmin-test + */ class PMA_GenerateCommonURL_Test extends PHPUnit_Framework_TestCase { diff --git a/test/libraries/PMA_js_escape_test.php b/test/libraries/PMA_js_escape_test.php index 30e762fc3d..4ae369f0cc 100644 --- a/test/libraries/PMA_js_escape_test.php +++ b/test/libraries/PMA_js_escape_test.php @@ -12,6 +12,11 @@ require_once 'libraries/js_escape.lib.php'; require_once 'libraries/Util.class.php'; +/** + * tests for JS variable formatting + * + * @package PhpMyAdmin-test + */ class PMA_JS_Escape_Test extends PHPUnit_Framework_TestCase { /** diff --git a/test/libraries/PMA_prettyPrint_test.php b/test/libraries/PMA_prettyPrint_test.php index da401e540c..6c0ebc53d5 100644 --- a/test/libraries/PMA_prettyPrint_test.php +++ b/test/libraries/PMA_prettyPrint_test.php @@ -11,6 +11,11 @@ */ require_once 'libraries/error_report.lib.php'; +/** + * tests for PMA_prettyPrint() + * + * @package PhpMyAdmin-test + */ class PMA_PrettyPrint_Test extends PHPUnit_Framework_TestCase { /** diff --git a/test/libraries/PMA_sanitize_test.php b/test/libraries/PMA_sanitize_test.php index 1cfb339438..6836d32ad8 100644 --- a/test/libraries/PMA_sanitize_test.php +++ b/test/libraries/PMA_sanitize_test.php @@ -14,6 +14,11 @@ require_once 'libraries/url_generating.lib.php'; require_once 'libraries/core.lib.php'; require_once 'libraries/Util.class.php'; +/** + * tests for PMA_sanitize() + * + * @package PhpMyAdmin-test + */ class PMA_Sanitize_Test extends PHPUnit_Framework_TestCase { /** diff --git a/test/libraries/common/PMA_browseUploadFile_test.php b/test/libraries/common/PMA_browseUploadFile_test.php index cbe9a9f747..a79777397a 100644 --- a/test/libraries/common/PMA_browseUploadFile_test.php +++ b/test/libraries/common/PMA_browseUploadFile_test.php @@ -13,9 +13,19 @@ require_once 'libraries/Util.class.php'; require_once 'libraries/php-gettext/gettext.inc'; +/** + * Test for PMA_Util::getBrowseUploadFileBlock from common.lib + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_GetBrowseUploadFileBlock_Test extends PHPUnit_Framework_TestCase { - + /** + * Set up + * + * @return void + */ protected function setUp() { $GLOBALS['is_upload'] = false; diff --git a/test/libraries/common/PMA_buildActionTitles_test.php b/test/libraries/common/PMA_buildActionTitles_test.php index b0d479c77e..7c2c82291d 100644 --- a/test/libraries/common/PMA_buildActionTitles_test.php +++ b/test/libraries/common/PMA_buildActionTitles_test.php @@ -14,9 +14,19 @@ require_once 'libraries/Util.class.php'; require_once 'libraries/Theme.class.php'; require_once 'libraries/php-gettext/gettext.inc'; +/** + * Test for PMA_Util::buildActionTitles from common.lib + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_BuildActionTitles_Test extends PHPUnit_Framework_TestCase { - + /** + * Set up + * + * @return void + */ function setup() { $_SESSION['PMA_Theme'] = PMA_Theme::load('./themes/pmahomme'); @@ -24,6 +34,11 @@ class PMA_BuildActionTitles_Test extends PHPUnit_Framework_TestCase $GLOBALS['pmaThemeImage'] = 'theme/'; } + /** + * Test for buildActionTitles + * + * @return void + */ function testBuildActionTitles() { $titles = array(); diff --git a/test/libraries/common/PMA_checkParameters_test.php b/test/libraries/common/PMA_checkParameters_test.php index 24df9fe632..8d34eca547 100644 --- a/test/libraries/common/PMA_checkParameters_test.php +++ b/test/libraries/common/PMA_checkParameters_test.php @@ -17,8 +17,19 @@ require_once 'libraries/Config.class.php'; require_once 'libraries/select_lang.lib.php'; require_once 'libraries/sanitizing.lib.php'; +/** + ** Test for PMA_Util::checkParameters from Util.class.php + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_CheckParameters_Test extends PHPUnit_Framework_TestCase { + /** + * Set up + * + * @return void + */ function setup() { $GLOBALS['PMA_Config'] = new PMA_Config(); @@ -28,6 +39,11 @@ class PMA_CheckParameters_Test extends PHPUnit_Framework_TestCase $GLOBALS['text_dir'] = 'ltr'; } + /** + * Test for checkParameters + * + * @return void + */ function testCheckParameterMissing() { $GLOBALS['PMA_PHP_SELF'] = PMA_getenv('PHP_SELF'); @@ -40,6 +56,11 @@ class PMA_CheckParameters_Test extends PHPUnit_Framework_TestCase ); } + /** + * Test for checkParameters + * + * @return void + */ function testCheckParameter() { $GLOBALS['PMA_PHP_SELF'] = PMA_getenv('PHP_SELF'); diff --git a/test/libraries/common/PMA_contains_nonprintable_ascii_test.php b/test/libraries/common/PMA_contains_nonprintable_ascii_test.php index ab7fc59aad..080576a863 100644 --- a/test/libraries/common/PMA_contains_nonprintable_ascii_test.php +++ b/test/libraries/common/PMA_contains_nonprintable_ascii_test.php @@ -25,7 +25,7 @@ class PMA_ContainsNonPrintableAsciiTest extends PHPUnit_Framework_TestCase * * @return array */ - function dataProvider() + public function dataProvider() { return array( array("normal string", 0), @@ -46,7 +46,7 @@ class PMA_ContainsNonPrintableAsciiTest extends PHPUnit_Framework_TestCase * * @dataProvider dataProvider */ - function testContainsNonPrintableAscii($str, $res) + public function testContainsNonPrintableAscii($str, $res) { $this->assertEquals( $res, PMA_Util::containsNonPrintableAscii($str) diff --git a/test/libraries/common/PMA_convert_bit_default_value_test.php b/test/libraries/common/PMA_convert_bit_default_value_test.php index 81810742fe..628fcd76cd 100644 --- a/test/libraries/common/PMA_convert_bit_default_value_test.php +++ b/test/libraries/common/PMA_convert_bit_default_value_test.php @@ -12,17 +12,23 @@ */ require_once 'libraries/Util.class.php'; +/** + ** Test for PMA_Util::convertBitDefaultValue from common.lib + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_ConvertBitDefaultValueTest extends PHPUnit_Framework_TestCase { /** * Provider for testConvertBitDefaultValueTest * - * @return array + * @return array * * @dataProvider dataProvider */ - function dataProvider() + public function dataProvider() { return array( array("b'",""), @@ -34,11 +40,14 @@ class PMA_ConvertBitDefaultValueTest extends PHPUnit_Framework_TestCase /** * Test for convertBitDefaultValue * + * @param string $bit Value + * @param string $val Expected value + * * @return void * * @dataProvider dataProvider */ - function testConvertBitDefaultValueTest($bit, $val) + public function testConvertBitDefaultValueTest($bit, $val) { $this->assertEquals( $val, PMA_Util::convertBitDefaultValue($bit) diff --git a/test/libraries/common/PMA_extractValueFromFormattedSize_test.php b/test/libraries/common/PMA_extractValueFromFormattedSize_test.php index ee8c12c92a..6999bc04e8 100644 --- a/test/libraries/common/PMA_extractValueFromFormattedSize_test.php +++ b/test/libraries/common/PMA_extractValueFromFormattedSize_test.php @@ -12,38 +12,44 @@ */ require_once 'libraries/Util.class.php'; +/** + ** Test for PMA_Util::extractValueFromFormattedSize from common.lib + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_ExtractValueFromFormattedSize_Test extends PHPUnit_Framework_TestCase { - - function testExtractValueFromFormattedSizeNoFormat() + /** + * Test for extractValueFromFormattedSize + * + * @param int|string $size Size + * @param int $expected Expected value + * + * @return void + * + * @dataProvider provider + */ + function testExtractValueFromFormattedSize($size, $expected) { $this->assertEquals( - -1, - PMA_Util::extractValueFromFormattedSize(100) + $expected, + PMA_Util::extractValueFromFormattedSize($size) ); } - function testExtractValueFromFormattedSizeGB() + /** + * Data provider for testExtractValueFromFormattedSize + * + * @return array + */ + public function provider() { - $this->assertEquals( - 10737418240, - PMA_Util::extractValueFromFormattedSize("10GB") - ); - } - - function testExtractValueFromFormattedSizeMB() - { - $this->assertEquals( - 15728640, - PMA_Util::extractValueFromFormattedSize("15MB") - ); - } - - function testExtractValueFromFormattedSizeK() - { - $this->assertEquals( - 262144, - PMA_Util::extractValueFromFormattedSize("256K") + return array( + array(100, -1), + array("10GB", 10737418240), + array("15MB", 15728640), + array("256K", 262144) ); } } diff --git a/test/libraries/common/PMA_formatSql_test.php b/test/libraries/common/PMA_formatSql_test.php index fc4f329210..7aa9d5e998 100644 --- a/test/libraries/common/PMA_formatSql_test.php +++ b/test/libraries/common/PMA_formatSql_test.php @@ -13,8 +13,19 @@ require_once 'libraries/Util.class.php'; require_once 'libraries/sqlparser.lib.php'; +/** + ** Test for PMA_Util::formatSql from Util.class.php + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_FormatSql_Test extends PHPUnit_Framework_TestCase { + /** + * Test for formatSql + * + * @return void + */ function testFormatSQL() { @@ -26,6 +37,11 @@ class PMA_FormatSql_Test extends PHPUnit_Framework_TestCase ); } + /** + * Test for formatSql + * + * @return void + */ function testFormatSQLTruncate() { $GLOBALS['cfg']['MaxCharactersInDisplayedSQL'] = 6; diff --git a/test/libraries/common/PMA_generateHiddenMaxFileSize_test.php b/test/libraries/common/PMA_generateHiddenMaxFileSize_test.php index 8f682cc1f3..3926c3feb1 100644 --- a/test/libraries/common/PMA_generateHiddenMaxFileSize_test.php +++ b/test/libraries/common/PMA_generateHiddenMaxFileSize_test.php @@ -12,11 +12,19 @@ */ require_once 'libraries/Util.class.php'; +/** + ** Test for PMA_Util::generateHiddenMaxFileSize from Util.class.php + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_GenerateHiddenMaxFileSize_Test extends PHPUnit_Framework_TestCase { - /* + /** * Data provider for test + * + * @return array */ public function dataProvider() { @@ -31,8 +39,13 @@ class PMA_GenerateHiddenMaxFileSize_Test extends PHPUnit_Framework_TestCase } /** - * @dataProvider dataProvider + * Test for generateHiddenMaxFileSize + * + * @param int $size Size + * * @return void + * + * @dataProvider dataProvider */ function test_generateHiddenMaxFileSize($size) { diff --git a/test/libraries/common/PMA_getCheckbox_test.php b/test/libraries/common/PMA_getCheckbox_test.php index 988c04d0ad..340c3b61de 100644 --- a/test/libraries/common/PMA_getCheckbox_test.php +++ b/test/libraries/common/PMA_getCheckbox_test.php @@ -12,8 +12,19 @@ */ require_once 'libraries/Util.class.php'; +/** + ** Test for PMA_Util::getCheckbox from Util.class.php + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_GetCheckboxTest extends PHPUnit_Framework_TestCase { + /** + * Test for getCheckbox + * + * @return void + */ function testGetCheckbox() { $name = "test_display_html_checkbox"; @@ -21,10 +32,17 @@ class PMA_GetCheckboxTest extends PHPUnit_Framework_TestCase $this->assertEquals( PMA_Util::getCheckbox($name, $label, false, false), - '' + '' ); } + /** + * Test for getCheckbox + * + * @return void + */ function testGetCheckboxChecked() { $name = "test_display_html_checkbox"; @@ -32,10 +50,17 @@ class PMA_GetCheckboxTest extends PHPUnit_Framework_TestCase $this->assertEquals( PMA_Util::getCheckbox($name, $label, true, false), - '' + '' ); } + /** + * Test for getCheckbox + * + * @return void + */ function testGetCheckboxOnclick() { $name = "test_display_html_checkbox"; @@ -43,10 +68,17 @@ class PMA_GetCheckboxTest extends PHPUnit_Framework_TestCase $this->assertEquals( PMA_Util::getCheckbox($name, $label, false, true), - '' + '' ); } + /** + * Test for getCheckbox + * + * @return void + */ function testGetCheckboxCheckedOnclick() { $name = "test_display_html_checkbox"; @@ -54,7 +86,9 @@ class PMA_GetCheckboxTest extends PHPUnit_Framework_TestCase $this->assertEquals( PMA_Util::getCheckbox($name, $label, true, true), - '' + '' ); } } diff --git a/test/libraries/common/PMA_getDivForSliderEffect_test.php b/test/libraries/common/PMA_getDivForSliderEffect_test.php index 93c2796b30..79867f275d 100644 --- a/test/libraries/common/PMA_getDivForSliderEffect_test.php +++ b/test/libraries/common/PMA_getDivForSliderEffect_test.php @@ -12,8 +12,19 @@ */ require_once 'libraries/Util.class.php'; +/** + ** Test for PMA_Util::getDivForSliderEffect from Util.class.php + * + * @package PhpMyAdmin-test + * @group common.lib-tests + */ class PMA_GetDivForSliderEffectTest extends PHPUnit_Framework_TestCase { + /** + * Test for getDivForSliderEffect + * + * @return void + */ function testGetDivForSliderEffectTest() { global $cfg; @@ -24,10 +35,16 @@ class PMA_GetDivForSliderEffectTest extends PHPUnit_Framework_TestCase $this->assertEquals( PMA_Util::getDivForSliderEffect($id, $message), - '
' + '
' ); } + /** + * Test for getDivForSliderEffect + * + * @return void + */ function testGetDivForSliderEffectTestClosed() { global $cfg; @@ -38,11 +55,17 @@ class PMA_GetDivForSliderEffectTest extends PHPUnit_Framework_TestCase $this->assertEquals( PMA_Util::getDivForSliderEffect($id, $message), - '