From c411121fd808bb6c82b9f7444b4ea27be88fe643 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Mon, 13 Dec 2021 12:01:56 -0300 Subject: [PATCH] Move Relation classes into the ConfigStorage namespace MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: MaurĂ­cio Meneghini Fauth --- libraries/classes/Bookmark.php | 2 + .../classes/{ => ConfigStorage}/Relation.php | 25 +- .../{ => ConfigStorage}/RelationCleanup.php | 10 +- .../RelationParameters.php | 45 +- libraries/classes/Console.php | 2 + .../BrowseForeignersController.php | 2 +- .../Controllers/CheckRelationsController.php | 2 +- .../Database/DataDictionaryController.php | 2 +- .../Database/OperationsController.php | 4 +- .../Database/QueryByExampleController.php | 4 +- .../Structure/DropTableController.php | 2 +- .../Structure/EmptyTableController.php | 4 +- .../Structure/FavoriteTableController.php | 2 +- .../Database/StructureController.php | 4 +- .../Export/Template/CreateController.php | 2 +- .../Export/Template/DeleteController.php | 2 +- .../Export/Template/LoadController.php | 2 +- .../Export/Template/UpdateController.php | 2 +- .../classes/Controllers/HomeController.php | 2 +- .../Controllers/NavigationController.php | 2 +- .../Preferences/ExportController.php | 2 +- .../Preferences/FeaturesController.php | 2 +- .../Preferences/ImportController.php | 2 +- .../Preferences/MainPanelController.php | 2 +- .../Preferences/ManageController.php | 2 +- .../Preferences/NavigationController.php | 2 +- .../Controllers/Preferences/SqlController.php | 2 +- .../Preferences/TwoFactorController.php | 2 +- .../Server/Databases/DestroyController.php | 2 +- .../Server/DatabasesController.php | 2 +- .../Server/PrivilegesController.php | 4 +- .../Server/UserGroupsController.php | 2 +- .../Server/UserGroupsFormController.php | 4 +- .../Controllers/Table/AddFieldController.php | 2 +- .../Controllers/Table/ChangeController.php | 2 +- .../Controllers/Table/CreateController.php | 2 +- .../Table/DeleteRowsController.php | 4 +- .../Table/DropColumnController.php | 2 +- .../Table/OperationsController.php | 7 +- .../Controllers/Table/RelationController.php | 4 +- .../Controllers/Table/ReplaceController.php | 2 +- .../Controllers/Table/SearchController.php | 4 +- .../Table/Structure/ChangeController.php | 2 +- .../Table/Structure/SaveController.php | 2 +- .../Controllers/Table/StructureController.php | 6 +- .../Table/ZoomSearchController.php | 2 +- .../Transformation/WrapperController.php | 2 +- libraries/classes/Database/CentralColumns.php | 2 +- libraries/classes/Database/Designer.php | 2 +- .../classes/Database/Designer/Common.php | 2 +- .../classes/Database/MultiTableQuery.php | 4 +- libraries/classes/Database/Qbe.php | 2 +- libraries/classes/DatabaseInterface.php | 1 + libraries/classes/Display/Results.php | 2 +- libraries/classes/ErrorReport.php | 1 + libraries/classes/Export/Options.php | 2 +- libraries/classes/Footer.php | 1 + libraries/classes/Header.php | 1 + libraries/classes/InsertEdit.php | 1 + libraries/classes/Menu.php | 1 + libraries/classes/Navigation/Navigation.php | 2 +- libraries/classes/Navigation/Nodes/Node.php | 2 +- libraries/classes/Normalization.php | 1 + libraries/classes/Operations.php | 1 + .../classes/Plugins/Export/Helpers/Pdf.php | 2 +- libraries/classes/Plugins/ExportPlugin.php | 2 +- .../Plugins/Schema/ExportRelationSchema.php | 2 +- libraries/classes/Plugins/Schema/Pdf/Pdf.php | 2 +- .../classes/Plugins/Schema/TableStats.php | 2 +- libraries/classes/RecentFavoriteTable.php | 2 + libraries/classes/SavedSearches.php | 2 + libraries/classes/Server/Privileges.php | 4 +- libraries/classes/Server/UserGroups.php | 2 +- libraries/classes/Sql.php | 2 + libraries/classes/SystemDatabase.php | 1 + libraries/classes/Table.php | 2 + libraries/classes/Table/ColumnsDefinition.php | 2 +- libraries/classes/Tracker.php | 1 + libraries/classes/Tracking.php | 1 + libraries/classes/Transformations.php | 1 + libraries/classes/Twig/RelationExtension.php | 2 +- libraries/classes/UserPreferences.php | 1 + libraries/services.php | 7 +- phpstan-baseline.neon | 286 +++++----- psalm-baseline.xml | 496 +++++++++--------- .../RelationCleanupTest.php | 9 +- .../RelationParametersTest.php | 6 +- .../{ => ConfigStorage}/RelationTest.php | 7 +- .../CheckRelationsControllerTest.php | 2 +- .../Structure/FavoriteTableControllerTest.php | 2 +- .../Database/StructureControllerTest.php | 4 +- .../Export/Template/CreateControllerTest.php | 2 +- .../Export/Template/DeleteControllerTest.php | 2 +- .../Export/Template/LoadControllerTest.php | 2 +- .../Export/Template/UpdateControllerTest.php | 2 +- .../Databases/DestroyControllerTest.php | 4 +- .../Server/DatabasesControllerTest.php | 4 +- .../Table/RelationControllerTest.php | 2 +- .../Table/SearchControllerTest.php | 2 +- .../Table/Structure/ChangeControllerTest.php | 2 +- .../Table/Structure/SaveControllerTest.php | 2 +- test/classes/Database/Designer/CommonTest.php | 2 +- test/classes/Database/DesignerTest.php | 2 +- test/classes/Database/QbeTest.php | 2 +- test/classes/DatabaseInterfaceTest.php | 2 +- test/classes/ErrorReportTest.php | 2 +- test/classes/Export/OptionsTest.php | 2 +- test/classes/Navigation/NavigationTest.php | 4 +- test/classes/NormalizationTest.php | 2 +- test/classes/OperationsTest.php | 2 +- .../Plugins/Export/ExportHtmlwordTest.php | 4 +- .../Plugins/Export/ExportLatexTest.php | 4 +- test/classes/Plugins/Export/ExportOdtTest.php | 4 +- test/classes/Plugins/Export/ExportSqlTest.php | 4 +- .../Plugins/Export/ExportTexytextTest.php | 2 +- test/classes/Server/PrivilegesTest.php | 4 +- test/classes/SqlTest.php | 4 +- test/classes/TableTest.php | 2 +- test/classes/TrackingTest.php | 2 +- test/classes/UserPasswordTest.php | 4 +- 120 files changed, 596 insertions(+), 557 deletions(-) rename libraries/classes/{ => ConfigStorage}/Relation.php (98%) rename libraries/classes/{ => ConfigStorage}/RelationCleanup.php (99%) rename libraries/classes/{ => ConfigStorage}/RelationParameters.php (95%) rename test/classes/{ => ConfigStorage}/RelationCleanupTest.php (98%) rename test/classes/{ => ConfigStorage}/RelationParametersTest.php (99%) rename test/classes/{ => ConfigStorage}/RelationTest.php (99%) diff --git a/libraries/classes/Bookmark.php b/libraries/classes/Bookmark.php index 29e7c86c27..88c199d029 100644 --- a/libraries/classes/Bookmark.php +++ b/libraries/classes/Bookmark.php @@ -7,6 +7,8 @@ declare(strict_types=1); namespace PhpMyAdmin; +use PhpMyAdmin\ConfigStorage\Relation; + use function count; use function is_array; use function preg_match_all; diff --git a/libraries/classes/Relation.php b/libraries/classes/ConfigStorage/Relation.php similarity index 98% rename from libraries/classes/Relation.php rename to libraries/classes/ConfigStorage/Relation.php index 9b8b2e2acd..5339e6e1cc 100644 --- a/libraries/classes/Relation.php +++ b/libraries/classes/ConfigStorage/Relation.php @@ -2,11 +2,18 @@ declare(strict_types=1); -namespace PhpMyAdmin; +namespace PhpMyAdmin\ConfigStorage; +use PhpMyAdmin\DatabaseInterface; +use PhpMyAdmin\InternalRelations; +use PhpMyAdmin\RecentFavoriteTable; use PhpMyAdmin\SqlParser\Parser; use PhpMyAdmin\SqlParser\Statements\CreateStatement; use PhpMyAdmin\SqlParser\Utils\Table as TableUtils; +use PhpMyAdmin\Table; +use PhpMyAdmin\Template; +use PhpMyAdmin\Util; +use PhpMyAdmin\Version; use function __; use function array_keys; @@ -948,11 +955,11 @@ class Relation /** * Outputs dropdown with values of foreign fields * - * @param array[] $disp_row array of the displayed row - * @param string $foreign_field the foreign field - * @param string $foreign_display the foreign field to display - * @param string $data the current data of the dropdown (field in row) - * @param int $max maximum number of items in the dropdown + * @param array[] $disp_row array of the displayed row + * @param string $foreign_field the foreign field + * @param string $foreign_display the foreign field to display + * @param string $data the current data of the dropdown (field in row) + * @param int|null $max maximum number of items in the dropdown * * @return string the