From 69672d854d4264330b3b331f725531c9e406c90e Mon Sep 17 00:00:00 2001 From: Piotr Przybylski Date: Wed, 17 Aug 2011 17:51:21 +0200 Subject: [PATCH 1/3] Fix More icon position --- themes/original/css/theme_right.css.php | 3 +++ themes/pmahomme/css/theme_right.css.php | 2 ++ 2 files changed, 5 insertions(+) diff --git a/themes/original/css/theme_right.css.php b/themes/original/css/theme_right.css.php index 6cb423363f..b8ac623a59 100644 --- a/themes/original/css/theme_right.css.php +++ b/themes/original/css/theme_right.css.php @@ -284,6 +284,9 @@ th.headerSortUp img.sortableIcon { background-position: 0 -1445px; width: 11px; /* Same as s_desc */ th.headerSortDown img.sortableIcon { background-position: 0 -1528px; width: 11px; height: 9px; } +/* Fix position */ +.ic_more { vertical-align: middle; } + /******************************************************************************/ /* classes */ .clearfloat { diff --git a/themes/pmahomme/css/theme_right.css.php b/themes/pmahomme/css/theme_right.css.php index 1103bfa770..ee2edea8a7 100644 --- a/themes/pmahomme/css/theme_right.css.php +++ b/themes/pmahomme/css/theme_right.css.php @@ -468,6 +468,8 @@ th.headerSortUp img.sortableIcon { background-position: -1516px 0; } /* Same as s_desc */ th.headerSortDown img.sortableIcon { background-position: 0 0; } +/* Fix position */ +.ic_more { vertical-align: middle; } /******************************************************************************/ /* classes */ From 18c65bbbba63d6f504d9589d7fc99f22312c97fd Mon Sep 17 00:00:00 2001 From: Piotr Przybylski Date: Wed, 17 Aug 2011 18:04:22 +0200 Subject: [PATCH 2/3] relative position doesn't work correctly on elements in this case it broke position of "More" menus --- themes/original/css/theme_right.css.php | 4 ---- themes/pmahomme/css/theme_right.css.php | 1 - 2 files changed, 5 deletions(-) diff --git a/themes/original/css/theme_right.css.php b/themes/original/css/theme_right.css.php index b8ac623a59..3a7eeb598f 100644 --- a/themes/original/css/theme_right.css.php +++ b/themes/original/css/theme_right.css.php @@ -2410,10 +2410,6 @@ span.cm-number { padding: 1px 3px !important; } -.data { - position: relative; -} - .cHide { background: #D3DCE3 url(getImgPath(); ?>col_hide.png); color: #CCC; diff --git a/themes/pmahomme/css/theme_right.css.php b/themes/pmahomme/css/theme_right.css.php index ee2edea8a7..6da96cfd23 100644 --- a/themes/pmahomme/css/theme_right.css.php +++ b/themes/pmahomme/css/theme_right.css.php @@ -72,7 +72,6 @@ h2 a img{display:inline;} .data{ margin: 0 0 12px 0; - position: relative; } h3 { From 2fdfc4fc1e19971767368061694a76499ca97463 Mon Sep 17 00:00:00 2001 From: Piotr Przybylski Date: Wed, 17 Aug 2011 18:25:56 +0200 Subject: [PATCH 3/3] "position: relative" on tables was required for grid, add it dynamically in PMA_makegrid --- js/makegrid.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/makegrid.js b/js/makegrid.js index 1a51eb90ee..aabe9b59cd 100644 --- a/js/makegrid.js +++ b/js/makegrid.js @@ -1614,6 +1614,9 @@ function PMA_makegrid(t, enableResize, enableReorder, enableVisib, enableGridEdi * Initialize grid ******************/ + // add relative position to table so that resize handlers are correctly positioned + $(t).css('position', 'relative'); + // wrap all data cells, except actions cell, with span $(t).find('th, td:not(:has(span))') .wrapInner('');