From 8d331c1cc9c2b693a9e34ef8b168111fae231698 Mon Sep 17 00:00:00 2001
From: Umair Khan <omerjerk@gmail.com>
Date: Thu, 14 Nov 2013 13:53:14 +0530
Subject: [PATCH 1/2] Bug Fix #4086

---
 libraries/sql_query_form.lib.php | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/libraries/sql_query_form.lib.php b/libraries/sql_query_form.lib.php
index 07fab07e0c..abdb2465c2 100644
--- a/libraries/sql_query_form.lib.php
+++ b/libraries/sql_query_form.lib.php
@@ -84,14 +84,8 @@ function PMA_getHtmlForSqlQueryForm(
 
     // start output
     if ($is_querywindow) {
-        $html .= '<form method="post" id="sqlqueryform" target="frame_content"';
-        $html .= '      action="import.php" ' . $enctype . ' name="sqlform"';
-        $html .= '      onsubmit="var save_name ';
-        $html .= '          = window.opener.parent.frame_content.name;';
-        $html .= '      window.opener.parent.frame_content.name ';
-        $html .= '          = save_name + \'' .  time() . '\';';
-        $html .= '      this.target = window.opener.parent.frame_content.name;';
-        $html .= '      return checkSqlQuery(this)">';
+        $html .= '<form method="post" id="sqlqueryform"';
+        $html .= ' action="sql.php" ' . $enctype . ' name="sqlform"';
     } else {
         $html .= '<form method="post" action="import.php" ' . $enctype;
         $html .= ' class="ajax"';
@@ -377,8 +371,11 @@ function PMA_getHtmlForSqlQueryFormInsert(
             . '</label>';
     }
     $html .= '</div>' . "\n";
-    $html .= '<input type="submit" id="button_submit_query" name="SQL"'
-        . ' tabindex="200" value="' . __('Go') . '" />' . "\n";
+    $html .= '<input type="submit" id="button_submit_query" name="SQL"';
+    if ($is_querywindow){
+        $html .= 'onclick="var form = this.parentNode.parentNode; window.opener.name = \'sqlParentWindow\'; form.target = \'sqlParentWindow\'; return checkSqlQuery(form);"';
+    }
+    $html .= ' tabindex="200" value="' . __('Go') . '" />' . "\n";
     $html .= '<div class="clearfloat"></div>' . "\n";
     $html .= '</fieldset>' . "\n";
 

From 5594ad5778639e5db6783d6a73e663382b1a47c3 Mon Sep 17 00:00:00 2001
From: Umair Khan <omerjerk@gmail.com>
Date: Thu, 14 Nov 2013 13:59:04 +0530
Subject: [PATCH 2/2] Fix code style

---
 libraries/sql_query_form.lib.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libraries/sql_query_form.lib.php b/libraries/sql_query_form.lib.php
index abdb2465c2..019741555e 100644
--- a/libraries/sql_query_form.lib.php
+++ b/libraries/sql_query_form.lib.php
@@ -373,7 +373,10 @@ function PMA_getHtmlForSqlQueryFormInsert(
     $html .= '</div>' . "\n";
     $html .= '<input type="submit" id="button_submit_query" name="SQL"';
     if ($is_querywindow){
-        $html .= 'onclick="var form = this.parentNode.parentNode; window.opener.name = \'sqlParentWindow\'; form.target = \'sqlParentWindow\'; return checkSqlQuery(form);"';
+        $html .= 'onclick="var form = this.parentNode.parentNode;'
+            . ' window.opener.name = \'sqlParentWindow\';'
+            . ' form.target = \'sqlParentWindow\';'
+            . ' return checkSqlQuery(form);"';
     }
     $html .= ' tabindex="200" value="' . __('Go') . '" />' . "\n";
     $html .= '<div class="clearfloat"></div>' . "\n";