From ca1b975a781930e0a84069571f44a9402693ae4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Fri, 20 Feb 2026 17:46:51 -0300 Subject: [PATCH] Remove method AbstractTestCase::setProperty() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: MaurĂ­cio Meneghini Fauth --- tests/unit/AbstractTestCase.php | 17 ----------------- tests/unit/Gis/GisVisualizationTest.php | 7 ++++--- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/tests/unit/AbstractTestCase.php b/tests/unit/AbstractTestCase.php index 0aca9c2dec..fd7d79546a 100644 --- a/tests/unit/AbstractTestCase.php +++ b/tests/unit/AbstractTestCase.php @@ -129,21 +129,4 @@ abstract class AbstractTestCase extends TestCase return $method->invokeArgs($object, $params); } - - /** - * Set a private or protected property via reflection. - * - * @param object|null $object The object to inspect, pass null for static objects() - * @param string $className The class name - * @param string $propertyName The method name - * @param mixed $value The parameters for the invocation - * @phpstan-param class-string $className - */ - protected function setProperty(object|null $object, string $className, string $propertyName, mixed $value): void - { - $class = new ReflectionClass($className); - $property = $class->getProperty($propertyName); - - $property->setValue($object, $value); - } } diff --git a/tests/unit/Gis/GisVisualizationTest.php b/tests/unit/Gis/GisVisualizationTest.php index ad0316c45c..cb26ba3796 100644 --- a/tests/unit/Gis/GisVisualizationTest.php +++ b/tests/unit/Gis/GisVisualizationTest.php @@ -10,6 +10,7 @@ use PhpMyAdmin\Gis\GisVisualization; use PhpMyAdmin\Gis\GisVisualizationSettings; use PhpMyAdmin\Tests\AbstractTestCase; use PHPUnit\Framework\Attributes\CoversClass; +use ReflectionProperty; #[CoversClass(GisVisualization::class)] class GisVisualizationTest extends AbstractTestCase @@ -174,7 +175,7 @@ class GisVisualizationTest extends AbstractTestCase { $this->dbi->setVersion(['@@version' => '8.0.0']); $gis = GisVisualization::getByData([], new GisVisualizationSettings(600, 450, 'abc')); - $this->setProperty($gis, GisVisualization::class, 'rows', 10); + (new ReflectionProperty(GisVisualization::class, 'rows'))->setValue($gis, 10); $queryString = $this->callFunction( $gis, GisVisualization::class, @@ -188,8 +189,8 @@ class GisVisualizationTest extends AbstractTestCase ); $gis = GisVisualization::getByData([], new GisVisualizationSettings(600, 450, 'abc')); - $this->setProperty($gis, GisVisualization::class, 'pos', 10); - $this->setProperty($gis, GisVisualization::class, 'rows', 15); + (new ReflectionProperty(GisVisualization::class, 'pos'))->setValue($gis, 10); + (new ReflectionProperty(GisVisualization::class, 'rows'))->setValue($gis, 15); $queryString = $this->callFunction( $gis, GisVisualization::class,