From cbbe3401b17ef1cc2ffd937662b6fc098a3d31be Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Mon, 18 Mar 2024 14:19:37 +0100 Subject: [PATCH] SQL without unique clause is not recognized Signed-off-by: Kamil Tekiela --- libraries/classes/Sql.php | 3 ++- psalm-baseline.xml | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libraries/classes/Sql.php b/libraries/classes/Sql.php index f7e03b08f2..5e3f241af7 100644 --- a/libraries/classes/Sql.php +++ b/libraries/classes/Sql.php @@ -21,6 +21,7 @@ use PhpMyAdmin\SqlParser\Utils\Query; use PhpMyAdmin\Utils\ForeignKey; use function __; +use function array_key_exists; use function array_keys; use function array_map; use function bin2hex; @@ -198,7 +199,7 @@ class Sql foreach (array_keys($indexColumns) as $indexColumnName) { if ( ! in_array($indexColumnName, $resultSetColumnNames) - && in_array($indexColumnName, $columns) + && array_key_exists($indexColumnName, $columns) && ! str_contains($columns[$indexColumnName]['Extra'], 'INVISIBLE') ) { continue; diff --git a/psalm-baseline.xml b/psalm-baseline.xml index 2838a68906..955301ac82 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -13265,9 +13265,6 @@ $_SESSION['tmpval']['possible_as_geometry'] $statement->expr[0] - - $columns[$indexColumnName] - $maxRows $oneFieldMeta