From cbfbb3adaf4984597917d8ef8d5ff2361a8920cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Mon, 30 Apr 2018 00:31:37 -0300 Subject: [PATCH] Remove incomplete tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: MaurĂ­cio Meneghini Fauth --- test/classes/Dbi/DbiMysqliTest.php | 17 ------------- test/classes/Display/ResultsTest.php | 38 ---------------------------- 2 files changed, 55 deletions(-) diff --git a/test/classes/Dbi/DbiMysqliTest.php b/test/classes/Dbi/DbiMysqliTest.php index 5f0215b175..971fcb2e4a 100644 --- a/test/classes/Dbi/DbiMysqliTest.php +++ b/test/classes/Dbi/DbiMysqliTest.php @@ -203,23 +203,6 @@ class DbiMysqliTest extends PmaTestCase ); } - /** - * Test for selectDb - * - * @return void - * - * @group medium - */ - public function testSelectDb() - { - $this->markTestIncomplete('Not testing anything'); - //$link is empty - $this->assertEquals( - false, - $this->object->selectDb("PMA", null) - ); - } - /** * Test for numRows * diff --git a/test/classes/Display/ResultsTest.php b/test/classes/Display/ResultsTest.php index 3108c2ca50..1326168f2e 100644 --- a/test/classes/Display/ResultsTest.php +++ b/test/classes/Display/ResultsTest.php @@ -164,44 +164,6 @@ class ResultsTest extends PmaTestCase ); } - /** - * Test for table navigation - * - * @return void - * - * @dataProvider providerForTestGetTableNavigation - */ - public function testGetTableNavigation( - // $pos_next, $pos_prev, $is_innodb, $output - ) { - $_SESSION['tmpval']['max_rows'] = '20'; - $_SESSION['tmpval']['pos'] = true; - $GLOBALS['num_rows'] = '20'; - $GLOBALS['unlim_num_rows'] = '50'; - $GLOBALS['cfg']['ShowAll'] = true; - $_SESSION['tmpval']['repeat_cells'] = '1'; - - /** - * FIXME Counting words of a generated large HTML is not a good way - * of testing IMO. Introduce more granular assertions that assert for - * existence of important content inside the generated HTML. - */ - /* - $this->assertEquals( - $output, - str_word_count( - $this->_callPrivateFunction( - '_getTableNavigation', - array( - $pos_next, $pos_prev, $is_innodb - ) - ) - ) - ); - */ - $this->markTestIncomplete('Not yet implemented!'); - } - /** * Provider for testing table navigation *