diff --git a/libraries/classes/Controllers/Table/TableGisVisualizationController.php b/libraries/classes/Controllers/Table/TableGisVisualizationController.php index 8069f77ced..775ad8775d 100644 --- a/libraries/classes/Controllers/Table/TableGisVisualizationController.php +++ b/libraries/classes/Controllers/Table/TableGisVisualizationController.php @@ -198,13 +198,14 @@ class TableGisVisualizationController extends TableController $html = Template::get('table/gis_visualization/gis_visualization')->render( array( 'url_params' => $this->url_params, - 'downloadUrl' => $downloadUrl, - 'labelCandidates' => $labelCandidates, - 'spatialCandidates' => $spatialCandidates, - 'visualizationSettings' => $this->visualizationSettings, + 'download_url' => $downloadUrl, + 'label_candidates' => $labelCandidates, + 'spatial_candidates' => $spatialCandidates, + 'visualization_settings' => $this->visualizationSettings, 'sql_query' => $this->sql_query, 'visualization' => $this->visualization->toImage('svg'), - 'drawOl' => $this->visualization->asOl() + 'draw_ol' => $this->visualization->asOl(), + 'pma_theme_image' => $GLOBALS['pmaThemeImage'] ) ); diff --git a/libraries/classes/Twig/UrlExtension.php b/libraries/classes/Twig/UrlExtension.php index 40d0045062..1b07326e50 100644 --- a/libraries/classes/Twig/UrlExtension.php +++ b/libraries/classes/Twig/UrlExtension.php @@ -26,17 +26,17 @@ class UrlExtension extends Twig_Extension { return array( new Twig_SimpleFunction( - 'URL_getHiddenInputs', + 'Url_getHiddenInputs', 'PhpMyAdmin\Url::getHiddenInputs', array('is_safe' => array('html')) ), new Twig_SimpleFunction( - 'URL_getHiddenFields', + 'Url_getHiddenFields', 'PhpMyAdmin\Url::getHiddenFields', array('is_safe' => array('html')) ), new Twig_SimpleFunction( - 'URL_getCommon', + 'Url_getCommon', 'PhpMyAdmin\Url::getCommon', array('is_safe' => array('html')) ) diff --git a/libraries/classes/Twig/UtilExtension.php b/libraries/classes/Twig/UtilExtension.php index f5e6a98921..a23b76576a 100644 --- a/libraries/classes/Twig/UtilExtension.php +++ b/libraries/classes/Twig/UtilExtension.php @@ -80,6 +80,11 @@ class UtilExtension extends Twig_Extension 'PhpMyAdmin\Util::getImage', array('is_safe' => array('html')) ), + new Twig_SimpleFunction( + 'Util_getStartAndNumberOfRowsPanel', + 'PhpMyAdmin\Util::getStartAndNumberOfRowsPanel', + array('is_safe' => array('html')) + ), new Twig_SimpleFunction( 'Util_getSupportedDatatypes', 'PhpMyAdmin\Util::getSupportedDatatypes', diff --git a/templates/database/create_table.twig b/templates/database/create_table.twig index 63fe5cfe73..c3abae2291 100644 --- a/templates/database/create_table.twig +++ b/templates/database/create_table.twig @@ -6,7 +6,7 @@ {%- endif %} {% trans "Create table" %} - {{ URL_getHiddenInputs(db) }} + {{ Url_getHiddenInputs(db) }}
{% trans "Name" %}: diff --git a/templates/database/structure/tracking_icon.twig b/templates/database/structure/tracking_icon.twig index 776a1d8fca..adc11a7cc7 100644 --- a/templates/database/structure/tracking_icon.twig +++ b/templates/database/structure/tracking_icon.twig @@ -1,4 +1,4 @@ - + {% if is_tracked -%} {{ Util_getImage('eye.png', 'Tracking is active.'|trans) }} {%- else -%} diff --git a/templates/privileges/add_user_fieldset.twig b/templates/privileges/add_user_fieldset.twig index 47327d9b00..b07aa6f8cf 100644 --- a/templates/privileges/add_user_fieldset.twig +++ b/templates/privileges/add_user_fieldset.twig @@ -1,8 +1,8 @@
{% trans %}New{% context %}Create new user{% endtrans %} - {{ Util_getIcon('b_usradd.png') }}{% trans 'Add user account' %}
diff --git a/templates/privileges/choose_user_group.twig b/templates/privileges/choose_user_group.twig index 2ffb6d518c..64a2e223d2 100644 --- a/templates/privileges/choose_user_group.twig +++ b/templates/privileges/choose_user_group.twig @@ -1,5 +1,5 @@
- {{ URL_getHiddenInputs(params) }} + {{ Url_getHiddenInputs(params) }}
{% trans 'User group' %} {% trans 'User group' %}: diff --git a/templates/privileges/edit_routine_privileges.twig b/templates/privileges/edit_routine_privileges.twig index 5f60fa81ed..461edbdc09 100644 --- a/templates/privileges/edit_routine_privileges.twig +++ b/templates/privileges/edit_routine_privileges.twig @@ -1,7 +1,7 @@
{{ header }} - {{ URL_getHiddenInputs() }} + {{ Url_getHiddenInputs() }} diff --git a/templates/select_lang.twig b/templates/select_lang.twig index 5a2232a697..98b5863fa2 100644 --- a/templates/select_lang.twig +++ b/templates/select_lang.twig @@ -1,5 +1,5 @@ - {{ URL_getHiddenInputs(_form_params) }} + {{ Url_getHiddenInputs(_form_params) }} {% if use_fieldset %}
diff --git a/templates/server/engines/engines.twig b/templates/server/engines/engines.twig index 230bc05a20..5a3d68c12c 100644 --- a/templates/server/engines/engines.twig +++ b/templates/server/engines/engines.twig @@ -11,7 +11,7 @@ {{- details['Support'] == 'NO' or details['Support'] == 'DISABLED' ? ' disabled' }} {{ details['Support'] == 'DEFAULT' ? ' marked' }}"> - + {{ details['Engine'] }} diff --git a/templates/table/chart/tbl_chart.phtml b/templates/table/chart/tbl_chart.phtml deleted file mode 100644 index d27e18445a..0000000000 --- a/templates/table/chart/tbl_chart.phtml +++ /dev/null @@ -1,160 +0,0 @@ - - -
- - -
- - - -
-
- - -
-
- - -
-
- - -
-
- - -
-
- - -
- - - - - - - - - - - - -

- - - - -

- - -
- -
- - -
- - - - -
-
- - -
- - -
-
-
-
- - -
- - - - -
- -
-
-
- - - -
-
-
-
-
- -
diff --git a/templates/table/chart/tbl_chart.twig b/templates/table/chart/tbl_chart.twig new file mode 100644 index 0000000000..1458690bf3 --- /dev/null +++ b/templates/table/chart/tbl_chart.twig @@ -0,0 +1,161 @@ + +{# Display Chart options #} +
+
+ {{ Url_getHiddenInputs(url_params) }} +
+ + {% trans 'Display chart' %} + +
+
+ + +
+
+ + +
+
+ + +
+
+ + +
+
+ + +
+ + + + + + + + + + + + +

+ + + + +

+ + +
+ {% set xaxis = null %} +
+ + +
+ + + + +
+
+ + +
+ + +
+
+
+
+ + +
+ + + + +
+ {{ Util_getStartAndNumberOfRowsPanel(sql_query) }} +
+ +
+
+
diff --git a/templates/table/gis_visualization/gis_visualization.phtml b/templates/table/gis_visualization/gis_visualization.twig similarity index 51% rename from templates/table/gis_visualization/gis_visualization.phtml rename to templates/table/gis_visualization/gis_visualization.twig index c6d6fcb51a..8d23a68728 100644 --- a/templates/table/gis_visualization/gis_visualization.phtml +++ b/templates/table/gis_visualization/gis_visualization.twig @@ -1,29 +1,29 @@
- + {% trans 'Display GIS Visualization' %}
- + {{ Url_getHiddenInputs(url_params) }} @@ -31,31 +31,31 @@ + {% if visualization_settings['choice'] is defined %} checked="checked" - /> + {% endif %}/> - + {{ Util_getStartAndNumberOfRowsPanel(sql_query) }}
- + {{ Util_getImage('b_saveimage', 'Save'|trans) }}
@@ -65,15 +65,15 @@
- + style="width:{{ visualization_settings['width'] }}px;height:{{ visualization_settings['height'] }}px;"> + {{ visualization }}
- +
diff --git a/templates/table/index_form.twig b/templates/table/index_form.twig index 04877ec2c1..fe4ffab7dd 100644 --- a/templates/table/index_form.twig +++ b/templates/table/index_form.twig @@ -4,7 +4,7 @@ id="index_frm" class="ajax"> - {{ URL_getHiddenInputs(form_params) }} + {{ Url_getHiddenInputs(form_params) }}
diff --git a/templates/table/relation/common_form.phtml b/templates/table/relation/common_form.phtml index 55c0cc5b52..0cdc8095b4 100644 --- a/templates/table/relation/common_form.phtml +++ b/templates/table/relation/common_form.phtml @@ -93,12 +93,51 @@ + getTables($foreign_db); + } + + // column dropdown + $uniqueColumns = array(); + if ($foreign_db && $foreign_table) { + if (isset($existrel[$myfield])) { + $foreign_column = $existrel[$myfield]['foreign_field']; + } + $table_obj = new PhpMyAdmin\Table($foreign_table, $foreign_db); + $uniqueColumns = $table_obj->getUniqueColumns(false, false); + } + ?> render( array( - 'save_row' => $save_row, - 'i' => $i, - 'existrel' => $existrel, - 'db' => $db + 'myfield' => $myfield, + 'myfield_md5' => $myfield_md5, + 'databases' => $GLOBALS['dblist']->databases, + 'tables' => $tables, + 'columns' => $uniqueColumns, + 'foreign_db' => $foreign_db, + 'foreign_table' => $foreign_table, + 'foreign_column' => $foreign_column ) ); ?> diff --git a/templates/table/relation/internal_relational_row.phtml b/templates/table/relation/internal_relational_row.phtml deleted file mode 100644 index 37879f6884..0000000000 --- a/templates/table/relation/internal_relational_row.phtml +++ /dev/null @@ -1,72 +0,0 @@ -getTables($foreign_db); -} - -// column dropdown -$columns = array(); -if ($foreign_db && $foreign_table) { - if (isset($existrel[$myfield])) { - $foreign_column = $existrel[$myfield]['foreign_field']; - } - $table_obj = new Table($foreign_table, $foreign_db); - $columns = $table_obj->getUniqueColumns(false, false); -} -?> - - - - - - - - render( - array( - 'name' => 'destination_db[' . $myfield_md5 . ']', - 'title' => __('Database'), - 'values' => $GLOBALS['dblist']->databases, - 'foreign' => $foreign_db - ) - ); ?> - render( - array( - 'name' => 'destination_table[' . $myfield_md5 . ']', - 'title' => __('Table'), - 'values' => $tables, - 'foreign' => $foreign_table - ) - ); ?> - render( - array( - 'name' => 'destination_column[' . $myfield_md5 . ']', - 'title' => __('Column'), - 'values' => $columns, - 'foreign' => $foreign_column - ) - ); ?> - - diff --git a/templates/table/relation/internal_relational_row.twig b/templates/table/relation/internal_relational_row.twig new file mode 100644 index 0000000000..f588f22987 --- /dev/null +++ b/templates/table/relation/internal_relational_row.twig @@ -0,0 +1,30 @@ + + + {{ myfield }} + + + + + {% include 'table/relation/relational_dropdown.twig' with { + 'name': 'destination_db[' ~ myfield_md5 ~ ']', + 'title': 'Database'|trans, + 'values': databases, + 'foreign': foreign_db + } only %} + + {% include 'table/relation/relational_dropdown.twig' with { + 'name': 'destination_table[' ~ myfield_md5 ~ ']', + 'title': 'Table'|trans, + 'values': tables, + 'foreign': foreign_table + } only %} + + {% include 'table/relation/relational_dropdown.twig' with { + 'name': 'destination_column[' ~ myfield_md5 ~ ']', + 'title': 'Column'|trans, + 'values': columns, + 'foreign': foreign_column + } only %} + + diff --git a/templates/table/search/form_tag.twig b/templates/table/search/form_tag.twig index 1b2dea07fb..827c051f3d 100644 --- a/templates/table/search/form_tag.twig +++ b/templates/table/search/form_tag.twig @@ -1,4 +1,4 @@
- {{ URL_getHiddenInputs(db, table) }} + {{ Url_getHiddenInputs(db, table) }} diff --git a/templates/table/search/replace_preview.twig b/templates/table/search/replace_preview.twig index 48067b3f9f..dab10f08f9 100644 --- a/templates/table/search/replace_preview.twig +++ b/templates/table/search/replace_preview.twig @@ -2,7 +2,7 @@ action="tbl_find_replace.php" name="previewForm" id="previewForm"> - {{ URL_getHiddenInputs(db, table) }} + {{ Url_getHiddenInputs(db, table) }} diff --git a/templates/table/structure/add_column.twig b/templates/table/structure/add_column.twig index 5a81002cba..c38d550005 100644 --- a/templates/table/structure/add_column.twig +++ b/templates/table/structure/add_column.twig @@ -1,5 +1,5 @@ - {{ URL_getHiddenInputs(db, table) }} + {{ Url_getHiddenInputs(db, table) }} {% if Util_showIcons('ActionLinksMode') %} {{ Util_getImage('b_insrow.png', 'Add column'|trans) }}  {% endif %} diff --git a/templates/table/structure/display_partitions.twig b/templates/table/structure/display_partitions.twig index c711848927..4904aa63e2 100644 --- a/templates/table/structure/display_partitions.twig +++ b/templates/table/structure/display_partitions.twig @@ -129,7 +129,7 @@