diff --git a/db_operations.php b/db_operations.php index 0bdb94f046..2818864c6e 100644 --- a/db_operations.php +++ b/db_operations.php @@ -73,7 +73,8 @@ if (strlen($db) && (! empty($_REQUEST['db_rename']) || ! empty($_REQUEST['db_cop "sql", 'libraries/plugins/export/', array( - 'single_table' => isset($single_table) + 'single_table' => isset($single_table), + 'export_type' => 'database' ) ); $GLOBALS['sql_constraints_query_full_db'] = diff --git a/db_structure.php b/db_structure.php index 80e1ee582d..c425e8af19 100644 --- a/db_structure.php +++ b/db_structure.php @@ -140,7 +140,7 @@ $overhead_check = ''; $create_time_all = ''; $update_time_all = ''; $check_time_all = ''; -$checked = !empty($checkall) ? ' checked="checked"' : ''; +$checked = (!empty($checkall) ? ' checked="checked"' : ''); $num_columns = $cfg['PropertiesNumColumns'] > 1 ? ceil($num_tables / $cfg['PropertiesNumColumns']) + 1 : 0; @@ -167,7 +167,7 @@ foreach ($tables as $keyname => $current_table) { list($current_table, $formatted_size, $unit, $formatted_overhead, $overhead_unit, $overhead_size, $table_is_view, $sum_size) - = PMA_getStuffForEnginetable($current_table, $db_is_information_schema, + = PMA_getStuffForEngineTypeTable($current_table, $db_is_information_schema, $is_show_stats, $table_is_view, $sum_size, $overhead_size ); @@ -218,7 +218,7 @@ foreach ($tables as $keyname => $current_table) { ); } - list($alias, $truename) = PMA_getAliasAndTruename( + list($alias, $truename) = PMA_getAliasAndTrueName( $tooltip_aliasname, $current_table, $tooltip_truename ); @@ -318,7 +318,10 @@ $response->addHTML('
'); */ /* DATABASE WORK */ /* Printable view of a table */ -$response->addHTML(PMA_getHtmlForPrintViewAndDataDictionaryLinks($url_query)); +$response->addHTML( + PMA_getHtmlForTablePrintViewLink($url_query) + . PMA_getHtmlForDataDictionaryLink($url_query) +); if (empty($db_is_information_schema)) { ob_start(); diff --git a/js/server_privileges.js b/js/server_privileges.js index 5303ac276f..363c938bb0 100644 --- a/js/server_privileges.js +++ b/js/server_privileges.js @@ -546,6 +546,7 @@ $(function() { $.get($(this).attr('href'), {'ajax_request' : true}, function(data) { // This form is not on screen when first entering Privileges // if there are more than 50 users + $("div.notice").remove(); $("#usersForm").hide("medium").remove(); $("#fieldset_add_user").hide("medium").remove(); $("#initials_table") diff --git a/libraries/operations.lib.php b/libraries/operations.lib.php index eedaf5437d..76804ba6c0 100644 --- a/libraries/operations.lib.php +++ b/libraries/operations.lib.php @@ -57,7 +57,7 @@ function PMA_getHtmlForRenameDatabase($db) . '
'; + . 'onsubmit="return emptyFormElements(this, \'newname\')">'; if (isset($_REQUEST['db_collation'])) { $html_output .= ''; + . 'onsubmit="return emptyFormElements(this, \'newname\')">'; if (isset($_REQUEST['db_collation'])) { $html_output .= ''; + : '' . '/>'); $html_output .= '' . ''; diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php index 278883b2d7..e46f03a4db 100644 --- a/libraries/server_privileges.lib.php +++ b/libraries/server_privileges.lib.php @@ -26,17 +26,17 @@ if (! defined('PHPMYADMIN')) { */ function PMA_wildcardEscapeForGrant($dbname, $tablename) { + $common_functions = PMA_CommonFunctions::getInstance(); if (! strlen($dbname)) { $db_and_table = '*.*'; } else { if (strlen($tablename)) { - $db_and_table - = PMA_CommonFunctions::getInstance()->backquote( - PMA_CommonFunctions::getInstance()->unescapeMysqlWildcards($dbname) + $db_and_table = $common_functions->backquote( + $common_functions->unescapeMysqlWildcards($dbname) ) . '.' - . PMA_CommonFunctions::getInstance()->backquote($tablename); + . $common_functions->backquote($tablename); } else { - $db_and_table = PMA_CommonFunctions::getInstance()->backquote($dbname) . '.*'; + $db_and_table = $common_functions->backquote($dbname) . '.*'; } } return $db_and_table; @@ -51,13 +51,14 @@ function PMA_wildcardEscapeForGrant($dbname, $tablename) */ function PMA_rangeOfUsers($initial = '') { + $common_functions = PMA_CommonFunctions::getInstance(); // strtolower() is used because the User field // might be BINARY, so LIKE would be case sensitive if (! empty($initial)) { $ret = " WHERE `User` LIKE '" - . PMA_CommonFunctions::getInstance()->sqlAddSlashes($initial, true) . "%'" + . $common_functions->sqlAddSlashes($initial, true) . "%'" . " OR `User` LIKE '" - . PMA_CommonFunctions::getInstance()->sqlAddSlashes(strtolower($initial), true) . "%'"; + . $common_functions->sqlAddSlashes(strtolower($initial), true) . "%'"; } else { $ret = ''; } @@ -309,11 +310,15 @@ function PMA_getHtmlForDisplayColumnPrivileges($columns, $row, $name_for_select, . $name_for_select . '[]" multiple="multiple" size="8">' . "\n"; foreach ($columns as $current_column => $current_column_privileges) { - $html_output .= '' . "\n"; } $html_output .= '' . "\n" @@ -465,12 +470,16 @@ function PMA_getHtmlToDisplayPrivilegesTable($random_n, $db = '*', ); } else { // g l o b a l o r d b - s p e c i f i c - $html_output .= PMA_getHtmlForGlobalOrDbSpecificPrivs($db, $table, $row, $random_n); + $html_output .= PMA_getHtmlForGlobalOrDbSpecificPrivs( + $db, $table, $row, $random_n + ); } $html_output .= '' . "\n"; if ($submit) { - $html_output .= '