From cd3a0e46cea930e760581b5cd742dbd328dd9629 Mon Sep 17 00:00:00 2001 From: William Desportes Date: Thu, 19 Nov 2020 23:24:26 +0100 Subject: [PATCH] Ref #16429 - PHP 8 error on preg_replace 47) PhpMyAdmin\Tests\Setup\ConfigGeneratorTest::testGetConfigFile TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, int given libraries/classes/Setup/ConfigGenerator.php:61 test/classes/Setup/ConfigGeneratorTest.php:55 vendor/phpunit/phpunit/phpunit:61 Signed-off-by: William Desportes --- libraries/classes/Setup/ConfigGenerator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/classes/Setup/ConfigGenerator.php b/libraries/classes/Setup/ConfigGenerator.php index 6bc7cbd1a5..4c5edfafb9 100644 --- a/libraries/classes/Setup/ConfigGenerator.php +++ b/libraries/classes/Setup/ConfigGenerator.php @@ -58,7 +58,7 @@ class ConfigGenerator $persistKeys = $cf->getPersistKeysMap(); foreach ($conf as $k => $v) { - $k = preg_replace('/[^A-Za-z0-9_]/', '_', $k); + $k = preg_replace('/[^A-Za-z0-9_]/', '_', (string) $k); $ret .= self::getVarExport($k, $v, $crlf); if (! isset($persistKeys[$k])) { continue;