gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix errors due to undefined variables

Browse Source 
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
This commit is contained in:
CommanderRoot 2018-04-18 20:07:36 +02:00 committed by GitHub
parent 2cde3122a3
commit ceed1d6459
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/common.inc.php
View File

@ -140,7 +140,7 @@ $GLOBALS['url_params'] = array();
*/
$GLOBALS['goto'] = '';
// Security fix: disallow accessing serious server files via "?goto="
if (Core::checkPageValidity($_REQUEST['goto'])) {
if (isset($_REQUEST['goto']) && Core::checkPageValidity($_REQUEST['goto'])) {
$GLOBALS['goto'] = $_REQUEST['goto'];
$GLOBALS['url_params']['goto'] = $_REQUEST['goto'];
} else {
@ -151,7 +151,7 @@ if (Core::checkPageValidity($_REQUEST['goto'])) {
* returning page
* @global string $GLOBALS['back']
*/
if (Core::checkPageValidity($_REQUEST['back'])) {
if (isset($_REQUEST['back']) && Core::checkPageValidity($_REQUEST['back'])) {
$GLOBALS['back'] = $_REQUEST['back'];
} else {
unset($_REQUEST['back'], $_GET['back'], $_POST['back'], $_COOKIE['back']);
@ -219,7 +219,7 @@ Core::setGlobalDbOrTable('table');
* Store currently selected recent table.
* Affect $GLOBALS['db'] and $GLOBALS['table']
*/
if (Core::isValid($_REQUEST['selected_recent_table'])) {
if (isset($_REQUEST['selected_recent_table']) && Core::isValid($_REQUEST['selected_recent_table'])) {
$recent_table = json_decode($_REQUEST['selected_recent_table'], true);
$GLOBALS['db']