Merge pull request #18427 from kamil-tekiela/voidify-loadIndexes

Voidify loadIndexes

libraries/classes/Index.php

@@ -179,10 +179,10 @@ class Index
     /**
      * Load index data for table
      */
-    private static function loadIndexes(DatabaseInterface $dbi, string $table, string $schema): bool
+    private static function loadIndexes(DatabaseInterface $dbi, string $table, string $schema): void
     {
         if (isset(self::$registry[$schema][$table])) {
-            return true;
+            return;
         }
 
         $rawIndexes = $dbi->getTableIndexes($schema, $table);
@@ -198,8 +198,6 @@ class Index
 
             $key->addColumn($eachIndex);
         }
-
-        return true;
     }
 
     /**

psalm-baseline.xml

@@ -7776,9 +7776,6 @@
       <code>hasPrimary</code>
       <code>isPacked</code>
     </PossiblyUnusedMethod>
-    <UnusedReturnValue>
-      <code>bool</code>
-    </UnusedReturnValue>
   </file>
   <file src="libraries/classes/IndexColumn.php">
     <MixedAssignment>