From dc5c7b0c6764261839940ea7cade2f0f2b006075 Mon Sep 17 00:00:00 2001 From: Deven Bansod Date: Sun, 16 Oct 2016 11:27:06 +0530 Subject: [PATCH 1/2] Fix submission of Save page form using Enter keypress Signed-off-by: Deven Bansod --- js/pmd/move.js | 89 ++++++++++++++++++++++++++++---------------------- 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/js/pmd/move.js b/js/pmd/move.js index 75f111a2e6..897e14e103 100644 --- a/js/pmd/move.js +++ b/js/pmd/move.js @@ -681,6 +681,49 @@ function Save2(callback) } } + +function submitSaveDialogAndClose(callback) +{ + var $form = $("#save_page"); + var name = $form.find('input[name="selected_value"]').val().trim(); + if (name === '') { + PMA_ajaxShowMessage(PMA_messages.strEnterValidPageName, false); + return; + } + $('#page_save_dialog').dialog('close'); + + if (pmd_tables_enabled) { + var $msgbox = PMA_ajaxShowMessage(PMA_messages.strProcessingRequest); + PMA_prepareForAjaxRequest($form); + $.post($form.attr('action'), $form.serialize() + Get_url_pos(), function (data) { + if (data.success === false) { + PMA_ajaxShowMessage(data.error, false); + } else { + PMA_ajaxRemoveMessage($msgbox); + MarkSaved(); + if (data.id) { + selected_page = data.id; + } + $('#page_name').text(name); + if (typeof callback !== 'undefined') { + callback(); + } + } + }); + } else { + Save_to_new_page(db, name, Get_url_pos(), function (page) { + MarkSaved(); + if (page.pg_nr) { + selected_page = page.pg_nr; + } + $('#page_name').text(page.page_descr); + if (typeof callback !== 'undefined') { + callback(); + } + }); + } +} + function Save3(callback) { if (parseInt(selected_page) !== -1) { @@ -689,44 +732,8 @@ function Save3(callback) var button_options = {}; button_options[PMA_messages.strGo] = function () { var $form = $("#save_page"); - var name = $form.find('input[name="selected_value"]').val().trim(); - if (name === '') { - PMA_ajaxShowMessage(PMA_messages.strEnterValidPageName, false); - return; - } - $(this).dialog('close'); - - if (pmd_tables_enabled) { - var $msgbox = PMA_ajaxShowMessage(PMA_messages.strProcessingRequest); - PMA_prepareForAjaxRequest($form); - $.post($form.attr('action'), $form.serialize() + Get_url_pos(), function (data) { - if (data.success === false) { - PMA_ajaxShowMessage(data.error, false); - } else { - PMA_ajaxRemoveMessage($msgbox); - MarkSaved(); - if (data.id) { - selected_page = data.id; - } - $('#page_name').text(name); - if (typeof callback !== 'undefined') { - callback(); - } - } - }); - } else { - Save_to_new_page(db, name, Get_url_pos(), function (page) { - MarkSaved(); - if (page.pg_nr) { - selected_page = page.pg_nr; - } - $('#page_name').text(page.page_descr); - if (typeof callback !== 'undefined') { - callback(); - } - }); - } - }; + $form.submit(); + } button_options[PMA_messages.strCancel] = function () { $(this).dialog('close'); }; @@ -739,6 +746,10 @@ function Save3(callback) .append('') .append(':'); + $form.on('submit', function(e){ + e.preventDefault(); + submitSaveDialogAndClose(callback); + }); $('
') .append($form) .dialog({ @@ -1095,7 +1106,7 @@ function Load_page(page) { function Grid() { - var value_sent = ''; + var value_sent = ''; if (!ON_grid) { ON_grid = 1; value_sent = 'on'; From 0983ff058663e5f7aec1f635d5a9ed9f8785a822 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Tue, 25 Oct 2016 10:27:30 +0200 Subject: [PATCH 2/2] Changelog entry for #12648 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Michal Čihař --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 4a69d4a9ee..bd99ed63ab 100644 --- a/ChangeLog +++ b/ChangeLog @@ -73,6 +73,7 @@ phpMyAdmin - ChangeLog - issue #12344 Fixed parsing of labels in loop - issue #12228 Fixed parsing of BEGIN labels - issue #12637 Fixed editing some timestamp values +- issue #12622 Fixed javascript error in designer 4.6.4 (2016-08-16) - issue [security] Weaknesses with cookie encryption, see PMASA-2016-29