diff --git a/index.php b/index.php index e62f6ee230..ad268e2833 100644 --- a/index.php +++ b/index.php @@ -174,10 +174,7 @@ if ($server > 0 || count($cfg['Servers']) > 1 . ' '. PMA_Util::getImage('s_asci.png') . " " . __('Server connection collation') . "\n" // put the doc link in the form so that it appears on the same line - . PMA_Util::showMySQLDocu( - 'MySQL_Database_Administration', - 'Charset-connection' - ) + . PMA_Util::showMySQLDocu('Charset-connection') . ': ' . "\n" . ' ' . "\n" @@ -640,7 +637,7 @@ function PMA_printListItem($name, $id = null, $url = null, echo '' . "\n"; } if (null !== $mysql_help_page) { - echo PMA_Util::showMySQLDocu('', $mysql_help_page); + echo PMA_Util::showMySQLDocu($mysql_help_page); } echo ''; } diff --git a/libraries/DbSearch.class.php b/libraries/DbSearch.class.php index 89489161ae..ec0f3d7df3 100644 --- a/libraries/DbSearch.class.php +++ b/libraries/DbSearch.class.php @@ -405,7 +405,7 @@ class PMA_DbSearch ), '3' => __('the exact phrase'), '4' => __('as regular expression') . ' ' - . PMA_Util::showMySQLDocu('Regexp', 'Regexp') + . PMA_Util::showMySQLDocu('Regexp') ); // 4th parameter set to true to add line breaks // 5th parameter set to false to avoid htmlspecialchars() escaping diff --git a/libraries/Index.class.php b/libraries/Index.class.php index 4e1e9aab45..5a193b95eb 100644 --- a/libraries/Index.class.php +++ b/libraries/Index.class.php @@ -534,9 +534,7 @@ class PMA_Index if (! $print_mode) { $r = '
'; $r .= '' . __('Indexes'); - $r .= PMA_Util::showMySQLDocu( - 'optimization', 'optimizing-database-structure' - ); + $r .= PMA_Util::showMySQLDocu('optimizing-database-structure'); $r .= ''; $r .= $no_indexes; diff --git a/libraries/TableSearch.class.php b/libraries/TableSearch.class.php index 6c4b723f27..212387f145 100644 --- a/libraries/TableSearch.class.php +++ b/libraries/TableSearch.class.php @@ -789,9 +789,7 @@ EOT; $html_output .= '
' . '' . '' . __('Or') . ' ' . __('Add search conditions (body of the "where" clause):') . ''; - $html_output .= PMA_Util::showMySQLDocu( - 'SQL-Syntax', 'Functions' - ); + $html_output .= PMA_Util::showMySQLDocu('Functions'); $html_output .= ''; $html_output .= '
'; diff --git a/libraries/Util.class.php b/libraries/Util.class.php index 631c363111..0087005c01 100644 --- a/libraries/Util.class.php +++ b/libraries/Util.class.php @@ -440,11 +440,10 @@ class PMA_Util * * @access public */ - public static function getMySQLDocuURL($chapter, $link, $anchor = '') { + public static function getMySQLDocuURL($link, $anchor = '') { global $cfg; // Fixup for newly used names: - $chapter = str_replace('_', '-', strtolower($chapter)); $link = str_replace('_', '-', strtolower($link)); if (empty($link)) { @@ -486,9 +485,9 @@ class PMA_Util * @access public */ public static function showMySQLDocu( - $chapter, $link, $big_icon = false, $anchor = '', $just_open = false + $link, $big_icon = false, $anchor = '', $just_open = false ) { - $url = self::getMySQLDocuURL($chapter, $link, $anchor); + $url = self::getMySQLDocuURL($link, $anchor); $open_link = ''; if ($just_open) { return $open_link; @@ -643,7 +642,7 @@ class PMA_Util $error_msg .= '

' . __('SQL query:') . '' . "\n"; if (strstr(strtolower($formatted_sql), 'select')) { // please show me help to the error on select - $error_msg .= self::showMySQLDocu('SQL-Syntax', 'SELECT'); + $error_msg .= self::showMySQLDocu('SELECT'); } if ($is_modify_link) { $_url_params = array( @@ -685,7 +684,7 @@ class PMA_Util // (now error-messages-server) $error_msg .= '

' . "\n" . ' ' . __('MySQL said: ') . '' - . self::showMySQLDocu('Error-messages-server', 'Error-messages-server') + . self::showMySQLDocu('Error-messages-server') . "\n" . '

' . "\n"; diff --git a/libraries/display_create_database.lib.php b/libraries/display_create_database.lib.php index 1b3b1a78a9..ec97bbe63a 100644 --- a/libraries/display_create_database.lib.php +++ b/libraries/display_create_database.lib.php @@ -16,26 +16,26 @@ require_once './libraries/check_user_privileges.lib.php'; if ($is_create_db_priv) { // The user is allowed to create a db - $html .= '
'; $html .= ' ' - . PMA_Util::showMySQLDocu('SQL-Syntax', 'CREATE_DATABASE'); + . PMA_Util::showMySQLDocu('CREATE_DATABASE'); $html .= '
'; $html .= PMA_generate_common_hidden_inputs('', '', 5); $html .= ''; - $html .= ''; include_once './libraries/mysql_charsets.inc.php'; $html .= PMA_generateCharsetDropdownBox( - PMA_CSDROPDOWN_COLLATION, - 'db_collation', - null, - null, - true, + PMA_CSDROPDOWN_COLLATION, + 'db_collation', + null, + null, + true, 5 ); @@ -47,14 +47,14 @@ if ($is_create_db_priv) { $html .= '
'; } else { $html .= ''; - $html .= '' . __('Create database:') . ' ' - . PMA_Util::showMySQLDocu('SQL-Syntax', 'CREATE_DATABASE') + $html .= '' . __('Create database:') . ' ' + . PMA_Util::showMySQLDocu('CREATE_DATABASE') . '
'; - + $html .= '' . PMA_Util::getImage( - 's_error2.png', - '', + 's_error2.png', + '', array('hspace' => 2, 'border' => 0, 'align' => 'middle') ) . '' . __('No Privileges') .''; diff --git a/libraries/display_indexes.lib.php b/libraries/display_indexes.lib.php index d158dda1b0..e4ed7f2f03 100644 --- a/libraries/display_indexes.lib.php +++ b/libraries/display_indexes.lib.php @@ -97,7 +97,7 @@ $html .= '
' . '' . '' . '' . '
' diff --git a/libraries/navigation/NavigationHeader.class.php b/libraries/navigation/NavigationHeader.class.php index d0bfaaec1b..87b3603bf2 100644 --- a/libraries/navigation/NavigationHeader.class.php +++ b/libraries/navigation/NavigationHeader.class.php @@ -172,8 +172,8 @@ class PMA_NavigationHeader private function _links() { // always iconic - $showIcon = true; - $showText = false; + $showIcon = true; + $showText = false; $retval = ''; $retval .= '
\n"; $retval .= "
\n"; $retval .= "\n\n"; diff --git a/libraries/rte/rte_list.lib.php b/libraries/rte/rte_list.lib.php index d531cd86fb..f49dd3ea75 100644 --- a/libraries/rte/rte_list.lib.php +++ b/libraries/rte/rte_list.lib.php @@ -38,7 +38,7 @@ function PMA_RTE_getList($type, $items) $retval .= "
\n"; $retval .= " \n"; $retval .= " " . PMA_RTE_getWord('title') . "\n"; - $retval .= " " . PMA_Util::showMySQLDocu('SQL-Syntax', PMA_RTE_getWord('docu')) . "\n"; + $retval .= " " . PMA_Util::showMySQLDocu(PMA_RTE_getWord('docu')) . "\n"; $retval .= " \n"; $retval .= "
\n"; $retval .= " " . PMA_RTE_getWord('nothing') . "\n"; diff --git a/libraries/server_engines.lib.php b/libraries/server_engines.lib.php index 8e937c42da..35ebc13e05 100644 --- a/libraries/server_engines.lib.php +++ b/libraries/server_engines.lib.php @@ -5,7 +5,7 @@ * functions for displaying server engines * * @usedby server_engines.php - * + * * @package PhpMyAdmin */ if (! defined('PHPMYADMIN')) { @@ -30,7 +30,7 @@ function PMA_getHtmlForServerEngines() } else { $html .= PMA_getHtmlForSpecifiedServerEngines(); } - + return $html; } @@ -75,7 +75,7 @@ function PMA_getHtmlForAllServerEngines() unset($odd_row, $engine, $details); $html .= '' . "\n" . '' . "\n"; - + return $html; } @@ -89,12 +89,12 @@ function PMA_getHtmlForSpecifiedServerEngines() /** * Displays details about a given Storage Engine */ - $html = ''; + $html = ''; $engine_plugin = PMA_StorageEngine::getEngine($_REQUEST['engine']); $html .= '

' . "\n" . PMA_Util::getImage('b_engine.png') . ' ' . htmlspecialchars($engine_plugin->getTitle()) . "\n" - . ' ' . PMA_Util::showMySQLDocu('', $engine_plugin->getMysqlHelpPage()) + . ' ' . PMA_Util::showMySQLDocu($engine_plugin->getMysqlHelpPage()) . "\n" . '

' . "\n\n"; $html .= '

' . "\n" . ' ' . "\n" @@ -139,7 +139,7 @@ function PMA_getHtmlForSpecifiedServerEngines() . '

' . "\n" . $engine_plugin->getHtmlVariables(); } - + return $html; } diff --git a/libraries/server_status_monitor.lib.php b/libraries/server_status_monitor.lib.php index 0f29b0f3b5..97183621d2 100644 --- a/libraries/server_status_monitor.lib.php +++ b/libraries/server_status_monitor.lib.php @@ -5,7 +5,7 @@ * functions for displaying server status sub item: monitor * * @usedby server_status_monitor.php - * + * * @package PhpMyAdmin */ if (! defined('PHPMYADMIN')) { @@ -22,9 +22,9 @@ if (! defined('PHPMYADMIN')) { function PMA_getHtmlForMonitor($ServerStatusData) { $retval = PMA_getHtmlForTabLinks(); - + $retval .= PMA_getHtmlForSettingsDialog(); - + $retval .= PMA_getHtmlForInstructionsDialog(); $retval .= PMA_getHtmlForAddChartDialog(); @@ -120,7 +120,7 @@ function PMA_getHtmlForAnalyseDialog() $retval .= '

'; $retval .= '
'; $retval .= '
'; - + return $retval; } @@ -193,7 +193,7 @@ function PMA_getHtmlForInstructionsDialog() $retval .= ''; } $retval .= ''; - + return $retval; } @@ -210,7 +210,7 @@ function PMA_getHtmlForAddChartDialog() $retval .= ''; $retval .= ''; $retval .= '
'; - $retval .= ''; $retval .= '