gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

getTableDef in Pdf

Browse Source 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This commit is contained in:
Kamil Tekiela 2023-05-12 22:17:18 +01:00
parent 9f9bf09ea9
commit d3701b52cf
3 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/classes/Plugins/Export/ExportPdf.php
View File

@ -272,13 +272,13 @@ class ExportPdf extends ExportPlugin
*/
switch ($exportMode) {
case 'create_table':
$pdf->getTableDef($db, $table, $doRelation, true, $doMime, false, $aliases);
$pdf->getTableDef($db, $table, $doRelation, true, $doMime);
break;
case 'triggers':
$pdf->getTriggers($db, $table);
break;
case 'create_view':
$pdf->getTableDef($db, $table, $doRelation, true, $doMime, false, $aliases);
$pdf->getTableDef($db, $table, $doRelation, true, $doMime);
break;
case 'stand_in':
// export a stand-in definition to resolve view dependencies

24
libraries/classes/Plugins/Export/Helpers/Pdf.php
View File

@ -431,18 +431,16 @@ class Pdf extends PdfLib
/**
* Print $table's CREATE definition
*
* @param string $db the database name
* @param string $table the table name
* @param bool $doRelation whether to include relation comments
* @param bool $doComments whether to include the pmadb-style column
* comments as comments in the structure;
* this is deprecated but the parameter is
* left here because /export calls
* PMA_exportStructure() also for other
* export types which use this parameter
* @param bool $doMime whether to include mime comments
* @param bool $view whether we're handling a view
* @param mixed[] $aliases aliases of db/table/columns
* @param string $db the database name
* @param string $table the table name
* @param bool $doRelation whether to include relation comments
* @param bool $doComments whether to include the pmadb-style column
* comments as comments in the structure;
* this is deprecated but the parameter is
* left here because /export calls
* PMA_exportStructure() also for other
* export types which use this parameter
* @param bool $doMime whether to include mime comments
*/
public function getTableDef(
string $db,
@ -450,8 +448,6 @@ class Pdf extends PdfLib
bool $doRelation,
bool $doComments,
bool $doMime,
bool $view = false,
array $aliases = [],
): void {
$relationParameters = $this->relation->getRelationParameters();

4
psalm-baseline.xml
View File

@ -10089,10 +10089,6 @@
<code>$resRel</code>
<code>$resRel</code>
</PossiblyUndefinedVariable>
<PossiblyUnusedParam>
<code>$aliases</code>
<code>$view</code>
</PossiblyUnusedParam>
<PropertyNotSetInConstructor>
<code>$results</code>
<code>Pdf</code>