From 332f369c57cab2a7af76951402c45847643fb6d2 Mon Sep 17 00:00:00 2001 From: Madhura Jayaratne Date: Mon, 4 May 2015 10:08:30 +0530 Subject: [PATCH] bug #4886 Clicking on external links in advisor rules give JS error Signed-off-by: Madhura Jayaratne --- ChangeLog | 1 + libraries/Advisor.class.php | 2 +- libraries/advisory_rules.txt | 14 +++++++------- libraries/core.lib.php | 9 ++++++++- 4 files changed, 17 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index d146f4c4bc..11ee6b6ca6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,7 @@ phpMyAdmin - ChangeLog - bug #4883 Search function breaks when searching for certain combinations of backslashes and slashes - bug #4830 Maximum execution time exceeded in Util.class.php (better fix) - bug #4885 Some icons are above the overlay of jQuery dialogs +- bug #4886 Clicking on external links in advisor rules give JS error 4.4.4.0 (2015-04-26) - bug #4863 Edit vs Change diff --git a/libraries/Advisor.class.php b/libraries/Advisor.class.php index fed6d19a23..41612bdbed 100644 --- a/libraries/Advisor.class.php +++ b/libraries/Advisor.class.php @@ -267,7 +267,7 @@ class Advisor */ private function _replaceLinkURL($matches) { - return 'href="' . PMA_linkURL($matches[2]) . '"'; + return 'href="' . PMA_linkURL($matches[2]) . '" target="_blank"'; } /** diff --git a/libraries/advisory_rules.txt b/libraries/advisory_rules.txt index 0060b45d19..b3d6114967 100644 --- a/libraries/advisory_rules.txt +++ b/libraries/advisory_rules.txt @@ -129,14 +129,14 @@ rule 'Distribution' version_comment preg_match('/percona/i',value) The MySQL manual only is accurate for official MySQL binaries. - Percona documentation is at http://www.percona.com/docs/wiki/ + Percona documentation is at http://www.percona.com/software/documentation/ 'percona' found in version_comment rule 'Distribution' version PMA_DRIZZLE The MySQL manual only is accurate for official MySQL binaries. - Drizzle documentation is at http://docs.drizzle.org/ + Drizzle documentation is at http://www.drizzle.org/content/documentation/ Version string (%s) matches Drizzle versioning scheme | value rule 'MySQL Architecture' @@ -284,7 +284,7 @@ rule 'Temp disk rate' [!fired('Percentage of temp tables on disk')] # Several independent Blog entries suggest (http://ronaldbradford.com/blog/more-on-understanding-sort_buffer_size-2010-05-10/ and http://www.xaprb.com/blog/2010/05/09/how-to-tune-mysqls-sort_buffer_size/) # that sort_buffer_size should be left as it is. And increasing read_buffer_size is only suggested when there are a lot of # table scans (http://dev.mysql.com/doc/refman/5.5/en/server-system-variables.html#sysvar_read_buffer_size and other sources) though -# setting it too high is bad too (http://www.mysqlperformanceblog.com/2007/09/17/mysql-what-read_buffer_size-value-is-optimal/). +# setting it too high is bad too (http://www.percona.com/blog/2007/09/17/mysql-what-read_buffer_size-value-is-optimal/). #rule 'Temp table rate' # Created_tmp_tables / Uptime # value * 60 * 60 > 1 @@ -400,14 +400,14 @@ rule 'Percentage of aborted connections' Aborted_connects / Connections * 100 value > 1 Too many connections are aborted. - Connections are usually aborted when they cannot be authorized. This article might help you track down the source. + Connections are usually aborted when they cannot be authorized. This article might help you track down the source. %s% of all connections are aborted. This value should be below 1% | round(value,1) rule 'Rate of aborted connections' Aborted_connects / Uptime value * 60 * 60 > 1 Too many connections are aborted. - Connections are usually aborted when they cannot be authorized. This article might help you track down the source. + Connections are usually aborted when they cannot be authorized. This article might help you track down the source. Aborted connections rate is at %s, this value should be less than 1 per hour | ADVISOR_bytime(value,2) rule 'Percentage of aborted clients' @@ -444,14 +444,14 @@ rule 'Max InnoDB log size' [innodb_buffer_pool_size > 0 && innodb_log_file_size innodb_log_file_size / (1024 * 1024) value > 256 The InnoDB log file size is inadequately large. - It is usually sufficient to set {innodb_log_file_size} to 25% of the size of {innodb_buffer_pool_size}. A very big {innodb_log_file_size} slows down the recovery time after a database crash considerably. See also this Article. You need to shutdown the server, remove the InnoDB log files, set the new value in my.cnf, start the server, then check the error logs if everything went fine. See also this blog entry + It is usually sufficient to set {innodb_log_file_size} to 25% of the size of {innodb_buffer_pool_size}. A very big {innodb_log_file_size} slows down the recovery time after a database crash considerably. See also this Article. You need to shutdown the server, remove the InnoDB log files, set the new value in my.cnf, start the server, then check the error logs if everything went fine. See also this blog entry Your absolute InnoDB log size is %s MiB | round(value,1) rule 'InnoDB buffer pool size' [system_memory > 0] innodb_buffer_pool_size / system_memory * 100 value < 60 Your InnoDB buffer pool is fairly small. - The InnoDB buffer pool has a profound impact on performance for InnoDB tables. Assign all your remaining memory to this buffer. For database servers that use solely InnoDB as storage engine and have no other services (e.g. a web server) running, you may set this as high as 80% of your available memory. If that is not the case, you need to carefully assess the memory consumption of your other services and non-InnoDB-Tables and set this variable accordingly. If it is set too high, your system will start swapping, which decreases performance significantly. See also this article + The InnoDB buffer pool has a profound impact on performance for InnoDB tables. Assign all your remaining memory to this buffer. For database servers that use solely InnoDB as storage engine and have no other services (e.g. a web server) running, you may set this as high as 80% of your available memory. If that is not the case, you need to carefully assess the memory consumption of your other services and non-InnoDB-Tables and set this variable accordingly. If it is set too high, your system will start swapping, which decreases performance significantly. See also this article You are currently using %s% of your memory for the InnoDB buffer pool. This rule fires if you are assigning less than 60%, however this might be perfectly adequate for your system if you don't have much InnoDB tables or other services running on the same machine. | value # diff --git a/libraries/core.lib.php b/libraries/core.lib.php index d0ed214891..4add6f4680 100644 --- a/libraries/core.lib.php +++ b/libraries/core.lib.php @@ -857,12 +857,19 @@ function PMA_isAllowedDomain($url) 'docs.phpmyadmin.net', /* mysql.com domains */ 'dev.mysql.com','bugs.mysql.com', + /* drizzle.com domains */ + 'www.drizzle.org', /* php.net domains */ 'php.net', /* Github domains*/ 'github.com','www.github.com', /* Following are doubtful ones. */ - 'www.primebase.com','pbxt.blogspot.com' + 'www.primebase.com', + 'pbxt.blogspot.com', + 'www.percona.com', + 'mysqldatabaseadministration.blogspot.com', + 'ronaldbradford.com', + 'xaprb.com', ); if (in_array(/*overload*/mb_strtolower($domain), $domainWhiteList)) { return true;