From 52bf8f03ede1e8467d68f418643fe25d9039dba6 Mon Sep 17 00:00:00 2001 From: Chanaka Indrajith Date: Sat, 17 May 2014 23:43:46 +0530 Subject: [PATCH] Fixed coding style issue in inser_edit.lib.php file, raised by scrutinizer Signed-off-by: Chanaka Indrajith --- libraries/insert_edit.lib.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libraries/insert_edit.lib.php b/libraries/insert_edit.lib.php index dc81a0cbd7..f23561e2dd 100644 --- a/libraries/insert_edit.lib.php +++ b/libraries/insert_edit.lib.php @@ -1924,7 +1924,7 @@ function PMA_getErrorUrl($url_params) * @param array $query_fields column names array * @param array $value_sets array of query values * - * @return string a query + * @return array of query */ function PMA_buildSqlQuery($is_insertignore, $query_fields, $value_sets) { @@ -1933,11 +1933,15 @@ function PMA_buildSqlQuery($is_insertignore, $query_fields, $value_sets) } else { $insert_command = 'INSERT '; } - $query[] = $insert_command . 'INTO ' + + $query = array( + $insert_command . 'INTO ' . PMA_Util::backquote($GLOBALS['db']) . '.' . PMA_Util::backquote($GLOBALS['table']) . ' (' . implode(', ', $query_fields) . ') VALUES (' - . implode('), (', $value_sets) . ')'; + . implode('), (', $value_sets) . ')' + ); + unset($insert_command, $query_fields); return $query; }