From e1ba7b792e2d11bd33bf876344144320253539a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Fri, 24 May 2019 23:06:02 -0300 Subject: [PATCH] Disallow JS functions in loops MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Maurício Meneghini Fauth --- .eslintrc.json | 2 +- js/designer/page.js | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index f5642c96a8..1f5582c21c 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -17,7 +17,7 @@ "new-cap": "warn", "no-array-constructor": "error", "no-eval": "error", - "no-loop-func": "warn", + "no-loop-func": "error", "no-mixed-spaces-and-tabs": "error", "no-multiple-empty-lines": "error", "no-new-func": "error", diff --git a/js/designer/page.js b/js/designer/page.js index c60d5bf7ed..8cfc75844a 100644 --- a/js/designer/page.js +++ b/js/designer/page.js @@ -13,15 +13,16 @@ function Save_to_new_page (db, page_name, table_positions, callback) { Create_new_page(db, page_name, function (page) { if (page) { var tbl_cords = []; + var saveCallback = function (id) { + tbl_cords.push(id); + if (table_positions.length === tbl_cords.length) { + page.tbl_cords = tbl_cords; + DesignerOfflineDB.addObject('pdf_pages', page); + } + }; for (var pos = 0; pos < table_positions.length; pos++) { table_positions[pos].pdf_pg_nr = page.pg_nr; - Save_table_positions(table_positions[pos], function (id) { - tbl_cords.push(id); - if (table_positions.length === tbl_cords.length) { - page.tbl_cords = tbl_cords; - DesignerOfflineDB.addObject('pdf_pages', page); - } - }); + Save_table_positions(table_positions[pos], saveCallback); } if (typeof callback !== 'undefined') { callback(page);