diff --git a/libraries/relation.lib.php b/libraries/relation.lib.php index 2baf635744..d2da975a46 100644 --- a/libraries/relation.lib.php +++ b/libraries/relation.lib.php @@ -87,11 +87,16 @@ function PMA_getRelationsParam($verbose = false) */ function PMA_printRelationsParamDiagnostic($cfgRelation) { - $messages['error'] = '' . __('not OK') - . ' [ ' - . __('Documentation') . ' ]'; + $messages['error'] = '' + . __('not OK') + . '' + . ' [ ' + . __('Documentation') + . ' ]'; - $messages['ok'] = '' . _pgettext('Correctly working', 'OK') . ''; + $messages['ok'] = '' + . _pgettext('Correctly working', 'OK') + . ''; $messages['enabled'] = '' . __('Enabled') . ''; $messages['disabled'] = '' . __('Disabled') . ''; @@ -309,11 +314,16 @@ function PMA_printRelationsParamDiagnostic($cfgRelation) * * @return void */ -function PMA_printDiagMessageForFeature($feature_name, $relation_parameter, $messages, $skip_line=true) -{ - echo ' ' . $feature_name . ': ' - . ($GLOBALS['cfgRelation'][$relation_parameter] ? $messages['enabled'] : $messages['disabled']) - . '' . "\n"; +function PMA_printDiagMessageForFeature($feature_name, + $relation_parameter, $messages, $skip_line = true +) { + echo ' ' . $feature_name . ': '; + if ($GLOBALS['cfgRelation'][$relation_parameter]) { + echo $messages['enabled']; + } else { + echo $messages['disabled']; + } + echo '' . "\n"; if ($skip_line) { echo '  ' . "\n"; } @@ -329,11 +339,18 @@ function PMA_printDiagMessageForFeature($feature_name, $relation_parameter, $mes * * @return void */ -function PMA_printDiagMessageForParameter($parameter, $relation_parameter_set, $messages, $doc_anchor) -{ - echo ' '; - echo '$cfg[\'Servers\'][$i][\'' . $parameter . '\'] ... '; - echo ($relation_parameter_set ? $messages['ok'] : sprintf($messages['error'], $doc_anchor)) . '' . "\n"; +function PMA_printDiagMessageForParameter($parameter, + $relation_parameter_set, $messages, $doc_anchor +) { + echo ''; + echo '$cfg[\'Servers\'][$i][\'' . $parameter . '\'] ... '; + echo ''; + if ($GLOBALS['cfgRelation'][$relation_parameter]) { + echo $messages['ok']; + } else { + printf($messages['error'], $doc_anchor); + } + echo '' . "\n"; } @@ -383,7 +400,8 @@ function PMA__getRelationsParam() // I was thinking of checking if they have all required columns but I // fear it might be too slow - $tab_query = 'SHOW TABLES FROM ' . PMA_backquote($GLOBALS['cfg']['Server']['pmadb']); + $tab_query = 'SHOW TABLES FROM ' + . PMA_backquote($GLOBALS['cfg']['Server']['pmadb']); $tab_rs = PMA_query_as_controluser($tab_query, false, PMA_DBI_QUERY_STORE); if (! $tab_rs) {