From eaae50a1bcafe6fc19f82ccb20cd5a67957ebc05 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?=
 <mauriciofauth@gmail.com>
Date: Fri, 9 Feb 2018 21:10:17 -0200
Subject: [PATCH] Add a constructor
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
---
 error_report.php                  |  3 ++-
 libraries/classes/ErrorReport.php | 30 +++++++++++++++++++++++-------
 2 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/error_report.php b/error_report.php
index 55feb8da34..6b6af843ff 100644
--- a/error_report.php
+++ b/error_report.php
@@ -9,6 +9,7 @@ use PhpMyAdmin\ErrorReport;
 use PhpMyAdmin\Message;
 use PhpMyAdmin\Response;
 use PhpMyAdmin\UserPreferences;
+use PhpMyAdmin\Utils\HttpRequest;
 
 require_once 'libraries/common.inc.php';
 
@@ -20,7 +21,7 @@ if (!isset($_REQUEST['exception_type'])
 
 $response = Response::getInstance();
 
-$errorReport = new ErrorReport();
+$errorReport = new ErrorReport(new HttpRequest());
 
 if (isset($_REQUEST['send_error_report'])
     && ($_REQUEST['send_error_report'] == true
diff --git a/libraries/classes/ErrorReport.php b/libraries/classes/ErrorReport.php
index 22a7742a70..79dcb62ce5 100644
--- a/libraries/classes/ErrorReport.php
+++ b/libraries/classes/ErrorReport.php
@@ -1,7 +1,7 @@
 <?php
 /* vim: set expandtab sw=4 ts=4 sts=4: */
 /**
- * Error reporting functions used to generate and submit error reports
+ * Holds the PhpMyAdmin\ErrorReport class
  *
  * @package PhpMyAdmin
  */
@@ -10,11 +10,10 @@ namespace PhpMyAdmin;
 use PhpMyAdmin\Relation;
 use PhpMyAdmin\Template;
 use PhpMyAdmin\Url;
-use PhpMyAdmin\Util;
 use PhpMyAdmin\Utils\HttpRequest;
 
 /**
- * PhpMyAdmin\ErrorReport class
+ * Error reporting functions used to generate and submit error reports
  *
  * @package PhpMyAdmin
  */
@@ -22,8 +21,26 @@ class ErrorReport
 {
     /**
      * the url where to submit reports to
+     *
+     * @var string
      */
-    const SUBMISSION_URL = "https://reports.phpmyadmin.net/incidents/create";
+    private $submissionUrl;
+
+    /**
+     * @var HttpRequest
+     */
+    private $httpRequest;
+
+    /**
+     * Constructor
+     *
+     * @param HttpRequest $httpRequest HttpRequest instance
+     */
+    public function __construct(HttpRequest $httpRequest)
+    {
+        $this->httpRequest = $httpRequest;
+        $this->submissionUrl = 'https://reports.phpmyadmin.net/incidents/create';
+    }
 
     /**
      * returns the pretty printed error report data collected from the
@@ -179,9 +196,8 @@ class ErrorReport
      */
     public function send(array $report)
     {
-        $httpRequest = new HttpRequest();
-        $response = $httpRequest->create(
-            self::SUBMISSION_URL,
+        $response = $this->httpRequest->create(
+            $this->submissionUrl,
             "POST",
             false,
             json_encode($report),