From f2dcdfff5016c40ae94c658467f5133e032ec377 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Fri, 20 Oct 2017 11:24:00 +0200 Subject: [PATCH] Do not hardcode secure flag in examples MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We can not assume that setup will be https by default, so having false as default is safer. Fixes #13758 Signed-off-by: Michal Čihař --- examples/openid.php | 5 ++++- examples/signon.php | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/examples/openid.php b/examples/openid.php index a87c1b19a8..68b7dfed98 100644 --- a/examples/openid.php +++ b/examples/openid.php @@ -20,6 +20,9 @@ if (false === @include_once 'OpenID/RelyingParty.php') { exit; } +/* Change this to true if using phpMyAdmin over https */ +$secure_cookie = false; + /** * Map of authenticated users to MySQL user/password pairs. */ @@ -74,7 +77,7 @@ function Die_error($e) /* Need to have cookie visible from parent directory */ -session_set_cookie_params(0, '/', '', true, true); +session_set_cookie_params(0, '/', '', $secure_cookie, true); /* Create signon session */ $session_name = 'SignonSession'; session_name($session_name); diff --git a/examples/signon.php b/examples/signon.php index da9fadfabc..0927fa84e2 100644 --- a/examples/signon.php +++ b/examples/signon.php @@ -11,8 +11,10 @@ * @subpackage Example */ +/* Change this to true if using phpMyAdmin over https */ +$secure_cookie = false; /* Need to have cookie visible from parent directory */ -session_set_cookie_params(0, '/', '', true, true); +session_set_cookie_params(0, '/', '', $secure_cookie, true); /* Create signon session */ $session_name = 'SignonSession'; session_name($session_name);