From 0f93ebb1d1f4944de1b23fb4e03ac2b78a0884a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Thu, 16 Nov 2023 18:14:13 -0300 Subject: [PATCH] Fix duplicate route parameter after logging in MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fixes #17363 Signed-off-by: Maurício Meneghini Fauth --- ChangeLog | 1 + .../classes/Plugins/Auth/AuthenticationCookie.php | 10 ---------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index cb3f1b617a..3a0703d513 100644 --- a/ChangeLog +++ b/ChangeLog @@ -65,6 +65,7 @@ phpMyAdmin - ChangeLog - issue Fix BETWEEN search does not validate input because of spaces - issue Fix JS number validation does not validate when the input is empty or emptied - issue #18561 Fix issue when adding System Monitor charts +- issue #17363 Fix duplicate route parameter after logging in 5.2.1 (2023-02-07) - issue #17522 Fix case where the routes cache file is invalid diff --git a/libraries/classes/Plugins/Auth/AuthenticationCookie.php b/libraries/classes/Plugins/Auth/AuthenticationCookie.php index db895a6508..0e8881d30c 100644 --- a/libraries/classes/Plugins/Auth/AuthenticationCookie.php +++ b/libraries/classes/Plugins/Auth/AuthenticationCookie.php @@ -147,10 +147,6 @@ class AuthenticationCookie extends AuthenticationPlugin } $_form_params = []; - if (isset($route)) { - $_form_params['route'] = $route; - } - if (strlen($GLOBALS['db'])) { $_form_params['db'] = $GLOBALS['db']; } @@ -455,8 +451,6 @@ class AuthenticationCookie extends AuthenticationPlugin */ public function rememberCredentials(): void { - global $route; - // Name and password cookies need to be refreshed each time // Duration = one month for username $this->storeUsernameCookie($this->user); @@ -470,10 +464,6 @@ class AuthenticationCookie extends AuthenticationPlugin // any parameters to pass? $url_params = []; - if (isset($route)) { - $url_params['route'] = $route; - } - if (strlen($GLOBALS['db']) > 0) { $url_params['db'] = $GLOBALS['db']; }