From f461ee9a7ddbda9ab1db0fe4ec032a2aab7b8c1f Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Wed, 13 Mar 2024 13:07:07 +0100 Subject: [PATCH] Fix impossible condition from #18630 Signed-off-by: Kamil Tekiela --- src/Table/Search.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/Table/Search.php b/src/Table/Search.php index 3bae1d0303..8c7a1879b5 100644 --- a/src/Table/Search.php +++ b/src/Table/Search.php @@ -81,14 +81,12 @@ final class Search return ' WHERE ' . $_POST['customWhereClause']; } - // If there are no search criteria set or no unary criteria operators, - // return if ( - ! isset($_POST['criteriaColumnOperators']) - || ( - ! isset($_POST['criteriaValues']) - && ! isset($_POST['criteriaColumnOperators']) - && ! isset($_POST['geom_func']) + ! isset( + $_POST['criteriaColumnOperators'], + $_POST['criteriaValues'], + $_POST['criteriaColumnNames'], + $_POST['criteriaColumnTypes'], ) ) { return '';