From f4fedc20ee3864ec6c494bacd52e5edf7eff1bbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Fri, 11 May 2018 20:44:27 -0300 Subject: [PATCH] Replace .change() with .on() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit .change() event shorthand is deprecated Signed-off-by: Maurício Meneghini Fauth --- js/config.js | 2 +- js/console.js | 4 ++-- js/db_central_columns.js | 4 ++-- js/db_structure.js | 2 +- js/designer/move.js | 4 ++-- js/export.js | 30 +++++++++++++++--------------- js/functions.js | 8 ++++---- js/makegrid.js | 2 +- js/replication.js | 4 ++-- js/server_status_monitor.js | 18 +++++++++--------- js/server_status_variables.js | 6 +++--- js/sql.js | 2 +- js/tbl_chart.js | 8 ++++---- js/tbl_gis_visualization.js | 6 +++--- js/tbl_zoom_plot_jqplot.js | 8 ++++---- 15 files changed, 54 insertions(+), 54 deletions(-) diff --git a/js/config.js b/js/config.js index bb4a182464..cd69c0dc52 100644 --- a/js/config.js +++ b/js/config.js @@ -742,7 +742,7 @@ AJAX.registerOnload('config.js', function () { if (ls_exists) { updatePrefsDate(); } - $('form.prefs-form').change(function () { + $('form.prefs-form').on('change', function () { var $form = $(this); var disabled = false; if (!ls_supported) { diff --git a/js/console.js b/js/console.js index b657bdaa00..cb19b5724d 100644 --- a/js/console.js +++ b/js/console.js @@ -152,7 +152,7 @@ var PMA_console = { PMA_console.hideCard($(this).closest('.card')); }); - $('#pma_console_options').find('input[type=checkbox]').change(function () { + $('#pma_console_options').find('input[type=checkbox]').on('change', function () { PMA_console.updateConfig(); }); @@ -165,7 +165,7 @@ var PMA_console = { PMA_console.updateConfig(); }); - $('#pma_console_options').find('input[name=enter_executes]').change(function () { + $('#pma_console_options').find('input[name=enter_executes]').on('change', function () { PMA_consoleMessages.showInstructions(PMA_console.config.EnterExecutes); }); diff --git a/js/db_central_columns.js b/js/db_central_columns.js index abb5b936a3..421c46b967 100644 --- a/js/db_central_columns.js +++ b/js/db_central_columns.js @@ -190,7 +190,7 @@ AJAX.registerOnload('db_central_columns.js', function () { } }); }); - $('#table-select').change(function (e) { + $('#table-select').on('change', function (e) { var selectvalue = $(this).val(); var default_column_select = $('#column-select').find('option:first'); var href = 'db_central_columns.php'; @@ -228,7 +228,7 @@ AJAX.registerOnload('db_central_columns.js', function () { $('#add_new').submit(function (event) { $('#add_new').toggle(); }); - $('#tableslistcontainer').find('select.default_type').change(function () { + $('#tableslistcontainer').find('select.default_type').on('change', function () { if ($(this).val() === 'USER_DEFINED') { $(this).siblings('.default_value').attr('name','col_default'); $(this).attr('name','col_default_sel'); diff --git a/js/db_structure.js b/js/db_structure.js index 7c0da763b6..a847876887 100644 --- a/js/db_structure.js +++ b/js/db_structure.js @@ -214,7 +214,7 @@ AJAX.registerOnload('db_structure.js', function () { /** * Event handler on select of "Make consistent with central list" */ - $('select[name=submit_mult]').change(function (event) { + $('select[name=submit_mult]').on('change', function (event) { if ($(this).val() === 'make_consistent_with_central_list') { event.preventDefault(); event.stopPropagation(); diff --git a/js/designer/move.js b/js/designer/move.js index 70f4fe0cfc..93187663c6 100644 --- a/js/designer/move.js +++ b/js/designer/move.js @@ -621,7 +621,7 @@ function Add_Other_db_tables () { } }); - $('#add_table_from').change(function () { + $('#add_table_from').on('change', function () { if ($(this).val()) { var db_name = $(this).val(); var sql_query = 'SHOW tables;'; @@ -1093,7 +1093,7 @@ function Export_pages () { $form.append(input); }); var $formatDropDown = $form.find('#plugins'); - $formatDropDown.change(function () { + $formatDropDown.on('change', function () { var format = $formatDropDown.val(); $form.find('.format_specific_options').hide(); $form.find('#' + format + '_options').show(); diff --git a/js/export.js b/js/export.js index 7f0c6ee723..650bff11b5 100644 --- a/js/export.js +++ b/js/export.js @@ -273,7 +273,7 @@ AJAX.registerOnload('export.js', function () { * Toggles the hiding and showing of each plugin's options * according to the currently selected plugin from the dropdown list */ - $('#plugins').change(function () { + $('#plugins').on('change', function () { $('#format_specific_opts').find('div.format_specific_options').hide(); var selected_plugin_name = $('#plugins').find('option:selected').val(); $('#' + selected_plugin_name + '_options').show(); @@ -282,7 +282,7 @@ AJAX.registerOnload('export.js', function () { /** * Toggles the enabling and disabling of the SQL plugin's comment options that apply only when exporting structure */ - $('input[type=\'radio\'][name=\'sql_structure_or_data\']').change(function () { + $('input[type=\'radio\'][name=\'sql_structure_or_data\']').on('change', function () { var comments_are_present = $('#checkbox_sql_include_comments').prop('checked'); var show = $('input[type=\'radio\'][name=\'sql_structure_or_data\']:checked').val(); if (show === 'data') { @@ -309,13 +309,13 @@ AJAX.registerOnload('export.js', function () { }); // For separate-file exports only ZIP compression is allowed - $('input[type="checkbox"][name="as_separate_files"]').change(function () { + $('input[type="checkbox"][name="as_separate_files"]').on('change', function () { if ($(this).is(':checked')) { $('#compression').val('zip'); } }); - $('#compression').change(function () { + $('#compression').on('change', function () { if ($('option:selected').val() !== 'zip') { $('input[type="checkbox"][name="as_separate_files"]').prop('checked', false); } @@ -413,14 +413,14 @@ function toggle_save_to_file () { AJAX.registerOnload('export.js', function () { toggle_save_to_file(); - $('input[type=\'radio\'][name=\'output_format\']').change(toggle_save_to_file); + $('input[type=\'radio\'][name=\'output_format\']').on('change', toggle_save_to_file); }); /** * For SQL plugin, toggles the disabling of the "display comments" options */ function toggle_sql_include_comments () { - $('#checkbox_sql_include_comments').change(function () { + $('#checkbox_sql_include_comments').on('change', function () { var $ulIncludeComments = $('#ul_include_comments'); if (!$('#checkbox_sql_include_comments').prop('checked')) { $ulIncludeComments.find('> li').fadeTo('fast', 0.4); @@ -547,10 +547,10 @@ AJAX.registerOnload('export.js', function () { */ var $create = $('#checkbox_sql_create_table_statements'); var $create_options = $('#ul_create_table_statements').find('input'); - $create.change(function () { + $create.on('change', function () { $create_options.prop('checked', $(this).prop('checked')); }); - $create_options.change(function () { + $create_options.on('change', function () { if ($create_options.is(':checked')) { $create.prop('checked', true); } @@ -559,7 +559,7 @@ AJAX.registerOnload('export.js', function () { /** * Disables the view output as text option if the output must be saved as a file */ - $('#plugins').change(function () { + $('#plugins').on('change', function () { var active_plugin = $('#plugins').find('option:selected').val(); var force_file = $('#force_file_' + active_plugin).val(); if (force_file === 'true') { @@ -648,7 +648,7 @@ AJAX.registerOnload('export.js', function () { /** * Handle force structure_or_data */ - $('#plugins').change(setup_table_structure_or_data); + $('#plugins').on('change', setup_table_structure_or_data); }); /** @@ -731,7 +731,7 @@ function aliasSelectHandler (event) { $inputWrapper.replaceWith(newTag); } } else if (type === '_tables') { - $('.table_alias_select:visible').change(); + $('.table_alias_select:visible').trigger('change'); } $('#alias_modal').dialog('option', 'position', 'center'); } @@ -763,7 +763,7 @@ function createAliasModal (event) { var option = $(''); option.text(db); option.attr('value', db); - $('#db_alias_select').append(option).val(db).change(); + $('#db_alias_select').append(option).val(db).trigger('change'); } else { var params = { ajax_request : true, @@ -833,7 +833,7 @@ function addAlias (type, name, field, value) { } AJAX.registerOnload('export.js', function () { - $('input[type=\'radio\'][name=\'quick_or_custom\']').change(toggle_quick_or_custom); + $('input[type=\'radio\'][name=\'quick_or_custom\']').on('change', toggle_quick_or_custom); $('#scroll_to_options_msg').hide(); $('#format_specific_opts').find('div.format_specific_options') @@ -859,7 +859,7 @@ AJAX.registerOnload('export.js', function () { /** * Disables the "Dump some row(s)" sub-options when it is not selected */ - $('input[type=\'radio\'][name=\'allrows\']').change(function () { + $('input[type=\'radio\'][name=\'allrows\']').on('change', function () { if ($('input[type=\'radio\'][name=\'allrows\']').prop('checked')) { enable_dump_some_rows_sub_options(); } else { @@ -880,7 +880,7 @@ AJAX.registerOnload('export.js', function () { var option = $(''); option.text(table); option.attr('value', table); - $('#table_alias_select').append(option).val(table).change(); + $('#table_alias_select').append(option).val(table).trigger('change'); } else { var params = { ajax_request : true, diff --git a/js/functions.js b/js/functions.js index 3315592eee..86f298526f 100644 --- a/js/functions.js +++ b/js/functions.js @@ -2985,7 +2985,7 @@ AJAX.registerOnload('functions.js', function () { col = col[0]; var $selectFieldKey = $('select[name="field_key[' + col + ']"]'); if ($selectFieldKey.val() === 'none_' + col) { - $selectFieldKey.val('primary_' + col).change(); + $selectFieldKey.val('primary_' + col).trigger('change'); } } }); @@ -3306,7 +3306,7 @@ function autoPopulate (input_id, offset) { $input6.val(central_column_list[db + '_' + table][offset].col_extra); } if (central_column_list[db + '_' + table][offset].col_extra.toUpperCase() === 'AUTO_INCREMENT') { - $('#' + input_id + '9').prop('checked',true).change(); + $('#' + input_id + '9').prop('checked',true).trigger('change'); } else { $('#' + input_id + '9').prop('checked',false); } @@ -3713,7 +3713,7 @@ AJAX.registerOnload('functions.js', function () { ); $newrow.find(':input').each(tempEmptyVal); // focus index size input on column picked - $newrow.find('select').change(tempSetFocus); + $newrow.find('select').on('change', tempSetFocus); } }); }); @@ -3850,7 +3850,7 @@ function showIndexEditDialog ($outer) { }); $('div.add_fields').removeClass('hide'); // focus index size input on column picked - $outer.find('table#index_columns select').change(function () { + $outer.find('table#index_columns select').on('change', function () { if ($(this).find('option:selected').val() === '') { return true; } diff --git a/js/makegrid.js b/js/makegrid.js index c9ca441775..6dda16838c 100644 --- a/js/makegrid.js +++ b/js/makegrid.js @@ -887,7 +887,7 @@ function PMA_makegrid (t, enableResize, enableReorder, enableVisib, enableGridEd // hide the value next to 'Browse foreign values' link $editArea.find('span.curr_value').hide(); // handle update for new values selected from new window - $editArea.find('span.curr_value').change(function () { + $editArea.find('span.curr_value').on('change', function () { $(g.cEdit).find('.edit_box').val($(this).text()); }); }); // end $.post() diff --git a/js/replication.js b/js/replication.js index 1d88ca6ebf..59f0f7e76f 100644 --- a/js/replication.js +++ b/js/replication.js @@ -46,8 +46,8 @@ AJAX.registerTeardown('replication.js', function () { AJAX.registerOnload('replication.js', function () { $('#rep').text(conf_prefix); - $('#db_type').change(update_config); - $('#db_select').change(update_config); + $('#db_type').on('change', update_config); + $('#db_select').on('change', update_config); $('#master_status_href').click(function () { $('#replication_master_section').toggle(); diff --git a/js/server_status_monitor.js b/js/server_status_monitor.js index efc2f47ee7..fa06dff28e 100644 --- a/js/server_status_monitor.js +++ b/js/server_status_monitor.js @@ -400,7 +400,7 @@ AJAX.registerOnload('server_status_monitor.js', function () { }); // global settings - $('div.popupContent select[name="chartColumns"]').change(function () { + $('div.popupContent select[name="chartColumns"]').on('change', function () { monitorSettings.columns = parseInt(this.value, 10); calculateChartSize(); @@ -466,7 +466,7 @@ AJAX.registerOnload('server_status_monitor.js', function () { saveMonitor(); // Save settings }); - $('div.popupContent select[name="gridChartRefresh"]').change(function () { + $('div.popupContent select[name="gridChartRefresh"]').on('change', function () { monitorSettings.gridRefresh = parseInt(this.value, 10) * 1000; clearTimeout(runtime.refreshTimeout); @@ -524,7 +524,7 @@ AJAX.registerOnload('server_status_monitor.js', function () { $.each(presetCharts, function (key, value) { $presetList.append(''); }); - $presetList.change(function () { + $presetList.on('change', function () { $('input[name="chartTitle"]').val( $presetList.find(':selected').text() ); @@ -540,7 +540,7 @@ AJAX.registerOnload('server_status_monitor.js', function () { $('#chartSeries').find(':selected').text().replace(/_/g, ' ') ); }); - $('#chartSeries').change(function () { + $('#chartSeries').on('change', function () { $('input[name="chartTitle"]').val( $('#chartSeries').find(':selected').text().replace(/_/g, ' ') ); @@ -809,7 +809,7 @@ AJAX.registerOnload('server_status_monitor.js', function () { return false; }); - $('input[name="chartType"]').change(function () { + $('input[name="chartType"]').on('change', function () { $('#chartVariableSettings').toggle(this.checked && this.value === 'variable'); var title = $('input[name="chartTitle"]').val(); if (title === PMA_messages.strChartTitle || @@ -821,15 +821,15 @@ AJAX.registerOnload('server_status_monitor.js', function () { } }); - $('input[name="useDivisor"]').change(function () { + $('input[name="useDivisor"]').on('change', function () { $('span.divisorInput').toggle(this.checked); }); - $('input[name="useUnit"]').change(function () { + $('input[name="useUnit"]').on('change', function () { $('span.unitInput').toggle(this.checked); }); - $('select[name="varChartList"]').change(function () { + $('select[name="varChartList"]').on('change', function () { if (this.selectedIndex !== 0) { $('#variableInput').val(this.value); } @@ -1652,7 +1652,7 @@ AJAX.registerOnload('server_status_monitor.js', function () { '' ); - $('#noWHEREData').change(function () { + $('#noWHEREData').on('change', function () { filterQueries(true); }); diff --git a/js/server_status_variables.js b/js/server_status_variables.js index 4028bc75d6..f228c0c400 100644 --- a/js/server_status_variables.js +++ b/js/server_status_variables.js @@ -23,17 +23,17 @@ AJAX.registerOnload('server_status_variables.js', function () { var text = ''; // Holds filter text /* 3 Filtering functions */ - $('#filterAlert').change(function () { + $('#filterAlert').on('change', function () { alertFilter = this.checked; filterVariables(); }); - $('#filterCategory').change(function () { + $('#filterCategory').on('change', function () { categoryFilter = $(this).val(); filterVariables(); }); - $('#dontFormat').change(function () { + $('#dontFormat').on('change', function () { // Hiding the table while changing values speeds up the process a lot $('#serverstatusvariables').hide(); $('#serverstatusvariables').find('td.value span.original').toggle(this.checked); diff --git a/js/sql.js b/js/sql.js index e6613ebbc6..28154b060c 100644 --- a/js/sql.js +++ b/js/sql.js @@ -228,7 +228,7 @@ AJAX.registerOnload('sql.js', function () { // If sql query with sort for current table is stored, change sort by key select value var sortStoredQuery = (isStorageSupported('localStorage') && typeof window.localStorage.auto_saved_sql_sort !== 'undefined') ? window.localStorage.auto_saved_sql_sort : Cookies.get('auto_saved_sql_sort'); if (typeof sortStoredQuery !== 'undefined' && sortStoredQuery !== $('select[name="sql_query"]').val() && $('select[name="sql_query"] option[value="' + sortStoredQuery + '"]').length !== 0) { - $('select[name="sql_query"]').val(sortStoredQuery).change(); + $('select[name="sql_query"]').val(sortStoredQuery).trigger('change'); } } }); diff --git a/js/tbl_chart.js b/js/tbl_chart.js index b43a221528..c13db82aa6 100644 --- a/js/tbl_chart.js +++ b/js/tbl_chart.js @@ -323,25 +323,25 @@ AJAX.registerOnload('tbl_chart.js', function () { }); // handle changing the x-axis - $('select[name="chartXAxis"]').change(function () { + $('select[name="chartXAxis"]').on('change', function () { onXAxisChange(); drawChart(); }); // handle changing the selected data series - $('select[name="chartSeries"]').change(function () { + $('select[name="chartSeries"]').on('change', function () { onDataSeriesChange(); drawChart(); }); // handle changing the series column - $('select[name="chartSeriesColumn"]').change(function () { + $('select[name="chartSeriesColumn"]').on('change', function () { currentSettings.seriesColumn = parseInt($(this).val(), 10); drawChart(); }); // handle changing the value column - $('select[name="chartValueColumn"]').change(function () { + $('select[name="chartValueColumn"]').on('change', function () { currentSettings.valueColumn = parseInt($(this).val(), 10); drawChart(); }); diff --git a/js/tbl_gis_visualization.js b/js/tbl_gis_visualization.js index 853283e851..9c0ee7d960 100644 --- a/js/tbl_gis_visualization.js +++ b/js/tbl_gis_visualization.js @@ -35,7 +35,7 @@ function zoomAndPan () { $('circle.vector').each(function () { id = $(this).attr('id'); circle = svg.getElementById(id); - svg.change(circle, { + svg.on('change', circle, { r : (3 / scale), 'stroke-width' : (2 / scale) }); @@ -45,7 +45,7 @@ function zoomAndPan () { $('polyline.vector').each(function () { id = $(this).attr('id'); line = svg.getElementById(id); - svg.change(line, { + svg.on('change', line, { 'stroke-width' : (2 / scale) }); }); @@ -54,7 +54,7 @@ function zoomAndPan () { $('path.vector').each(function () { id = $(this).attr('id'); polygon = svg.getElementById(id); - svg.change(polygon, { + svg.on('change', polygon, { 'stroke-width' : (0.5 / scale) }); }); diff --git a/js/tbl_zoom_plot_jqplot.js b/js/tbl_zoom_plot_jqplot.js index 897caed666..6cf7438c15 100644 --- a/js/tbl_zoom_plot_jqplot.js +++ b/js/tbl_zoom_plot_jqplot.js @@ -147,7 +147,7 @@ AJAX.registerOnload('tbl_zoom_plot_jqplot.js', function () { **/ // first column choice corresponds to the X axis - $('#tableid_0').change(function () { + $('#tableid_0').on('change', function () { // AJAX request for field type, collation, operators, and value field $.post('tbl_zoom_select.php', { 'ajax_request' : true, @@ -171,7 +171,7 @@ AJAX.registerOnload('tbl_zoom_plot_jqplot.js', function () { }); // second column choice corresponds to the Y axis - $('#tableid_1').change(function () { + $('#tableid_1').on('change', function () { // AJAX request for field type, collation, operators, and value field $.post('tbl_zoom_select.php', { 'ajax_request' : true, @@ -194,7 +194,7 @@ AJAX.registerOnload('tbl_zoom_plot_jqplot.js', function () { }); }); - $('#tableid_2').change(function () { + $('#tableid_2').on('change', function () { // AJAX request for field type, collation, operators, and value field $.post('tbl_zoom_select.php', { 'ajax_request' : true, @@ -215,7 +215,7 @@ AJAX.registerOnload('tbl_zoom_plot_jqplot.js', function () { }); }); - $('#tableid_3').change(function () { + $('#tableid_3').on('change', function () { // AJAX request for field type, collation, operators, and value field $.post('tbl_zoom_select.php', { 'ajax_request' : true,