diff --git a/psalm-baseline.xml b/psalm-baseline.xml index d2cabc14d2..bd904a3290 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -5988,7 +5988,6 @@ getPmaTable()]]> - bool bool|Message diff --git a/src/Favorites/RecentFavoriteTable.php b/src/Favorites/RecentFavoriteTable.php index dfed7f4be2..9e5886cdc7 100644 --- a/src/Favorites/RecentFavoriteTable.php +++ b/src/Favorites/RecentFavoriteTable.php @@ -158,18 +158,16 @@ class RecentFavoriteTable * Trim recent.favorite table according to the * NumRecentTables/NumFavoriteTables configuration. */ - private function trim(): bool + private function trim(): void { $max = max( Config::getInstance()->settings['Num' . ucfirst($this->tableType->value) . 'Tables'], 0, ); - $trimmingOccurred = count($this->tables) > $max; + while (count($this->tables) > $max) { array_pop($this->tables); } - - return $trimmingOccurred; } /**