From 421129535b8a136eb7fdb3fdb57703a0ae49c29b Mon Sep 17 00:00:00 2001 From: Michael Steininger <11192306+codegain@users.noreply.github.com> Date: Wed, 28 Sep 2022 15:17:44 +0200 Subject: [PATCH 1/3] move template including bulkActionModal outside of form tag The browser prevents the bulkActionModal loading other forms directly into its modal-body (f.e. the "Replace table prefix" action). Signed-off-by: Michael Steininger --- templates/database/structure/table_header.twig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/database/structure/table_header.twig b/templates/database/structure/table_header.twig index b44d3b917e..2490cf70b0 100644 --- a/templates/database/structure/table_header.twig +++ b/templates/database/structure/table_header.twig @@ -72,7 +72,7 @@ {% endif %} + {% if check_all_tables %} {% include 'database/structure/check_all_tables.twig' with check_all_tables only %} {% endif %} - From 24066609b7bcf1fbbce10c1d20214a928aaa2bc2 Mon Sep 17 00:00:00 2001 From: Michael Steininger Date: Thu, 13 Oct 2022 14:48:28 +0200 Subject: [PATCH 2/3] move bulkActionModal out of template because of failing tests Signed-off-by: Michael Steininger --- .../database/structure/bulk_action_modal.twig | 16 ++++++++++++++++ .../database/structure/check_all_tables.twig | 17 ----------------- templates/database/structure/table_header.twig | 5 ++++- 3 files changed, 20 insertions(+), 18 deletions(-) create mode 100644 templates/database/structure/bulk_action_modal.twig diff --git a/templates/database/structure/bulk_action_modal.twig b/templates/database/structure/bulk_action_modal.twig new file mode 100644 index 0000000000..36edbed5be --- /dev/null +++ b/templates/database/structure/bulk_action_modal.twig @@ -0,0 +1,16 @@ + \ No newline at end of file diff --git a/templates/database/structure/check_all_tables.twig b/templates/database/structure/check_all_tables.twig index ac14dafc90..da94978829 100644 --- a/templates/database/structure/check_all_tables.twig +++ b/templates/database/structure/check_all_tables.twig @@ -39,23 +39,6 @@ {{ hidden_fields|join('\n')|raw }} - - {% if central_columns_work is defined and central_columns_work %} +{% if check_all_tables %} + {% include 'database/structure/check_all_tables.twig' with check_all_tables only %} +{% endif %} {% if check_all_tables %} - {% include 'database/structure/check_all_tables.twig' with check_all_tables only %} + {% include 'database/structure/bulk_action_modal.twig' with check_all_tables only %} {% endif %} From e76f0d3a61adec6160f9ed9207edff3b126f4af6 Mon Sep 17 00:00:00 2001 From: William Desportes Date: Thu, 13 Oct 2022 20:49:49 +0200 Subject: [PATCH 3/3] Add a ChangeLog entry for #17656 Pull-request: #17741 Signed-off-by: William Desportes --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 40ec58b2ae..6a3b9fa1b0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -41,6 +41,7 @@ phpMyAdmin - ChangeLog - issue #17747 The Column Visibility Toggle will not be hidden by other elements - issue #17756 Edit/Copy/Delete row now works when using GROUP BY - issue #17248 Support the UUID data type for MariaDB >= 10.7 +- issue #17656 Fix replace/change/set table prefix is not working 5.2.0 (2022-05-10) - issue #16521 Upgrade Bootstrap to version 5