gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract getTables() method from Triggers::getEditorForm()

Browse Source 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
This commit is contained in:
Maurício Meneghini Fauth 2023-05-26 20:29:23 -03:00
parent 0d4b85552e
commit ff7fe4bfa0
No known key found for this signature in database
GPG Key ID: 6A16FD38AFC89CC8
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
libraries/classes/Triggers/Triggers.php
View File

@ -11,6 +11,7 @@ use PhpMyAdmin\Query\Generator as QueryGenerator;
use PhpMyAdmin\ResponseRenderer;
use PhpMyAdmin\Template;
use PhpMyAdmin\Util;
use Webmozart\Assert\Assert;
use function __;
use function array_column;
@ -299,10 +300,7 @@ class Triggers
*/
public function getEditorForm(string $db, string $table, string $mode, array $item): string
{
$query = 'SELECT `TABLE_NAME` FROM `INFORMATION_SCHEMA`.`TABLES` ';
$query .= 'WHERE `TABLE_SCHEMA`=\'' . $this->dbi->escapeString($db) . '\' ';
$query .= 'AND `TABLE_TYPE` IN (\'BASE TABLE\', \'SYSTEM VERSIONED\')';
$tables = $this->dbi->fetchResult($query);
$tables = $this->getTables($db);
return $this->template->render('triggers/editor_form', [
'db' => $db,
@ -553,4 +551,19 @@ class Triggers
return $result;
}
/** @return list<non-empty-string> */
private function getTables(string $db): array
{
$query = sprintf(
'SELECT `TABLE_NAME` FROM `INFORMATION_SCHEMA`.`TABLES` WHERE `TABLE_SCHEMA`=%s'
. " AND `TABLE_TYPE` IN ('BASE TABLE', 'SYSTEM VERSIONED')",
$this->dbi->quoteString($db),
);
$tables = $this->dbi->fetchResult($query);
Assert::allStringNotEmpty($tables);
Assert::isList($tables);
return $tables;
}
}

3
psalm-baseline.xml
View File

@ -12869,9 +12869,6 @@
</PossiblyUnusedReturnValue>
</file>
<file src="libraries/classes/Triggers/Triggers.php">
<DeprecatedMethod>
<code>escapeString</code>
</DeprecatedMethod>
<InvalidArrayOffset>
<code><![CDATA[$GLOBALS['errors']]]></code>
<code><![CDATA[$GLOBALS['errors']]]></code>