From 90336ba418fff0a1a2b1cf195aa3a4e56ac9fb4a Mon Sep 17 00:00:00 2001 From: Smita Kumari Date: Fri, 17 Apr 2015 15:57:23 +0530 Subject: [PATCH 1/2] fix bug #4857 Signed-off-by: Smita Kumari --- js/tbl_structure.js | 3 --- libraries/structure.lib.php | 17 ++++++++++++++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/js/tbl_structure.js b/js/tbl_structure.js index 4cd0dc314e..9cd7cd58a7 100644 --- a/js/tbl_structure.js +++ b/js/tbl_structure.js @@ -92,9 +92,6 @@ AJAX.registerOnload('tbl_structure.js', function () { indexes = []; fulltext_indexes = []; - //by default select the last option to add new column (adds at end of the table) - $("select[name=after_field] option:last").attr("selected","selected"); - /** *Ajax action for submitting the "Column Change" and "Add Column" form */ diff --git a/libraries/structure.lib.php b/libraries/structure.lib.php index 51dd2a5304..ab23b27d60 100644 --- a/libraries/structure.lib.php +++ b/libraries/structure.lib.php @@ -1704,10 +1704,21 @@ function PMA_getHtmlForAddColumn($columns_list) . 'value="first" data-pos = "first">' . __('at beginning of table') . ''; + $cols_count = count($columns_list); foreach ($columns_list as $one_column_name) { - $column_selector .= ''; } $column_selector .= ''; From 71f07d1e87246ca0457bb0c34849913559416023 Mon Sep 17 00:00:00 2001 From: Smita Kumari Date: Fri, 17 Apr 2015 17:33:21 +0530 Subject: [PATCH 2/2] edit changeLog Signed-off-by: Smita Kumari --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 3539d9892d..dc0c85b44c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,7 @@ phpMyAdmin - ChangeLog - bug PHP 7 compatibility in php-gettext - bug PHP 7 compatibility in bfShapeFiles - bug PHP 7 session_regenerate_id() warning +- bug #4857 Alter table after changing column name error 4.4.2.0 (2015-04-13) - bug #4835 PMA_hideShowConnection not called after submit_num_fields