Commit Graph

71 Commits

Author SHA1 Message Date
Michal Čihař
9d6157fda7 Ensure we use escaped version of type
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 13:47:15 +02:00
Michal Čihař
a1f69b4c80 Fix syntax error
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 13:17:36 +02:00
Michal Čihař
53cc34b374 Fix handing of GIS data
* Force geometry count to be integer
* Ensure proper escaping of GIS data

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 13:02:48 +02:00
Michal Čihař
0f119bb329 Merge branch 'QA_4_5' 2016-01-19 11:31:41 +01:00
Michal Čihař
a6ae24741e Validate parameters before use
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-19 11:23:36 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Michal Čihař
cc07b737dc Remove unused PMA_String class
The class is no longer used:

- the ctype part is not needed by new SQL parser
- the utf-8 manipulation was replaced by direct usage of mbstring

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-21 12:09:06 +01:00
Michal Čihař
98d88ef134 Remove unused pmaString variable
It was used in past when we didn't rely on mbstring.

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-21 11:35:36 +01:00
Marc Delisle
66c15daba0 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-06 08:01:07 -05:00
Marc Delisle
e16bc39f85 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-05 07:27:29 -05:00
Marc Delisle
357b1b4757 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-04 09:05:42 -05:00
Marc Delisle
2607023281 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 11:00:01 -05:00
Madhura Jayaratne
fbef26ee0d Another instance of legacy support
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-03 12:26:52 +11:00
Hugues Peccatte
a5d35d41b6 Revert PMA_String rename.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-14 22:39:03 +02:00
Hugues Peccatte
e23bbdf2a6 Set namespaces on GIS classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 22:33:15 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Madhura Jayaratne
53ae242e83 Fix x coordinates of these points are repeated as y coordinates
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-18 16:29:29 +05:30
Hugues Peccatte
bf61709259 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-23 14:38:07 +02:00
Jason
c24e96f1a3 Optimize logic in tbl_gis_visualization.php
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-06-17 01:50:10 +08:00
Jason
cb771052c8 Finish refactoring tbl_*.lib.php
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-06-17 01:14:27 +08:00
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Hugues Peccatte
49ababac08 Replace mb functions by standard string functions.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-04 10:09:06 +02:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Michal Čihař
9d17a602f5 Better messasge after creating a bookmark
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-02 11:32:15 +01:00
Madhura Jayaratne
16587a8c6b Suffix files containing classes with .class.php file extension
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-22 18:19:48 +05:30
Madhura Jayaratne
3c9f6a6890 Space around . operator - mroe instances
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 18:56:30 +05:30
Madhura Jayaratne
6335b10574 Fix coding style
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 14:35:15 +05:30
Hugues Peccatte
7bd1bf23d3 Fix PHPCS errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-11 22:13:10 +01:00
Hugues Peccatte
464ec23ad8 Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
Spun Nakandala
883c8ad73d gis insert/edit error corrected 2013-09-28 01:19:30 +05:30
Michal Čihař
0fecb355da Add explaining comment 2013-08-24 09:11:24 +02:00
Michal Čihař
aa0c22d348 Fix include path 2013-08-23 16:20:18 +02:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
2fbb4cee0d Consistently include colon in strings to translate
In some languages this makes difference in translating, so it's better
to give translators full context.
2013-04-25 14:22:31 +02:00
Madhura Jayaratne
7b12b12aee Avoid PHP, HTML mix. Improve doc comments 2012-09-04 21:32:11 +05:30
Dieter Adriaenssens
b947fd63c3 improve message 2012-09-03 18:05:01 +02:00
Dieter Adriaenssens
1136a46c74 improve coding style, fix indentation 2012-09-03 18:05:01 +02:00
Rouslan Placella
a16e723048 Dropped PMA_ajaxResponse() 2012-06-11 17:58:35 +01:00
Rouslan Placella
3d18fb588a Got rid of some dead code from gis_data_editor.php 2012-06-11 14:06:03 +01:00
Dieter Adriaenssens
3a3da2987e add vim directive for indenting with spaces 2012-04-11 16:18:53 +02:00
Rouslan Placella
c985fec282 Drop non-JS version of the "GIS data editor" 2012-04-10 21:50:34 +01:00
Jo Michael
b2fd866d87 Leading ./ paths for includes can be omitted, part 2 2012-03-16 23:11:57 +01:00
Marc Delisle
4a48e5d825 Typo 2012-01-07 09:03:59 -05:00
Dieter Adriaenssens
87459a5cf6 use include() instead of require() when including file conditionally 2011-09-06 22:04:51 +02:00
Michal Čihař
1b8018e436 Use format string for point number, otherwise the translation is wrong in some languages 2011-08-25 08:36:05 +02:00
Michal Čihař
eb37c00260 Avoid two messages for same thing 2011-08-23 10:50:11 +02:00
Madhura Jayaratne
d67165f7bc Fix code style 2011-08-17 23:42:43 +05:30
Madhura Jayaratne
cb0eca28e4 Rename functions to match PEAR coding style 2011-08-12 13:50:28 +05:30