Commit Graph

21 Commits

Author SHA1 Message Date
Deven Bansod
f14cffdbe7 Properly escape strings in MySQL statement values
Use *_real_escape string functions provided by connectors to escape strings while exporting

Fix #12453

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

Conflicts:
	libraries/server_privileges.lib.php
2016-10-29 10:45:12 +05:30
Deven Bansod
2d69d40fa2 Fix error in adcaf7c
Fix #12382

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-22 12:01:47 +05:30
Deven Bansod
adcaf7ca4b Use intval to prevent XSS instead, and use numeric to check valid datatype
Fix #12382

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-21 21:24:00 +05:30
Michal Čihař
f204208540 Move count() call outside loop
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-24 12:58:35 +02:00
Michal Čihař
4bcc606225 Always use delimiter not present in search expression
This avoids need to figure out correct escaping in case delimiter is
present in the expression.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-20 12:03:44 +02:00
Madhura Jayaratne
86b9067969 Fix #12085 Like search strings being escaped incorrectly
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-03-10 19:16:54 +11:00
Michal Čihař
a29f154f37 Merge branch 'MAINT_4_5_5-security' into QA_4_6-security 2016-02-29 10:35:47 +01:00
Madhura Jayaratne
f2a60e54f4 canvg.js does not seem to be used anymore
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-01-14 14:05:03 +11:00
Madhura Jayaratne
56f684e466 Move common code inside the method
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-01-14 13:09:55 +11:00
Michal Čihař
f4eb1a9b4f There is no need to reset() before foreach()
The code is there since past when PHP 4 was still supported reset was
necessary.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 11:26:34 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Marc Delisle
86769cafaa Use more modern statement
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-12 07:40:58 -05:00
Marc Delisle
ea2a7a324f Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-15 06:10:12 -05:00
Marc Delisle
9cb51e7bb1 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-08 05:17:23 -08:00
Marc Delisle
b49a746d35 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-25 09:54:07 -04:00
Marc Delisle
faaec8e9f4 Refactor high-level parser calling into a function
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-22 12:07:45 -04:00
Hugues Peccatte
9698d301f8 Fix #11550 Regression in Find and replace
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-18 22:14:20 +02:00
Hugues Peccatte
6c594eb0cf Fix calls.
Remove useless PHPDoc.
Add missing require.
Add missing 'use'.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 22:58:47 +02:00
Hugues Peccatte
32fd26ad42 Merge branch 'master' into useNamespaces_master 2015-09-02 21:48:40 +02:00
Hugues Peccatte
49e9dd1f13 Fix wrong rename.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 22:20:00 +02:00
Hugues Peccatte
5207ba43a7 Update controllers' namespace.
Move table controllers into 'table' folder.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:56:14 +02:00