Michal Čihař
85ff1b6c4b
Gracefully fail on missing parameter
...
Fixes #13841
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 09:07:04 +01:00
Michal Čihař
c95a2c35eb
Merge branch 'QA_4_6'
2016-08-25 09:40:59 +02:00
Michal Čihař
fb3b722da1
Fixed random logouts due to wrong cookie path
...
Some script did not properly configure their relative path and this
could lead to wrong cookie path being set. This doesn't happen in all
cases as the PHP session engine doesn't seem to set the cookie session
in every request.
Fixes #12251
Fixes phpmyadmin/docker#32
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-25 09:38:17 +02:00
Michal Čihař
791bdafcdd
Merge branch 'QA_4_6-security' into master-security
2016-06-17 16:24:39 +02:00
Michal Čihař
4767f24ea4
Limit number of included scripts in get_scripts.js.php
...
This avoids potential DOS, the limit is same as we use for generating
the URLs.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-15 18:07:12 +02:00
Michal Čihař
c7824a9be3
Remove unused variable
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 15:39:08 +01:00
Michal Čihař
74174ed6eb
Test dynamic javascripts
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 15:38:35 +01:00
Hugues Peccatte
7f8f34e89d
Remove classes require_once.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
f0ba28fc1d
Set namespace on Advisor, Config, Console and Util classes.
...
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Madhura Jayaratne
3b3a14f33c
Space after function keyword
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-27 19:14:00 +05:30
Madhura Jayaratne
e1ab1925c9
File is being unconditionally included; use "require_once" instead
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-27 19:12:17 +05:30
Madhura Jayaratne
fb52e6af04
Closing parenthesis of a multi-line function call must be on a line by itself
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-27 17:57:36 +05:30
Marc Delisle
775d1dca70
Best practice: remove PHP closing tag
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-04-24 11:33:29 -04:00
Madhura Jayaratne
847fa854e6
Output buffering for static JS
...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-09 14:07:36 +05:30
Michal Čihař
52be2f7fc9
Simplify file name validation
...
We don't want to expose possible hidden files as well (starting with .
on unix).
2013-10-03 15:54:50 +02:00
Michal Čihař
0ad8714cb1
Properly detect variable presence
2013-10-03 15:50:37 +02:00
Michal Čihař
39dd5f9e4f
Do not load common.inc for js/get_scripts.js.php
...
No functionality is being used there and the token protection only
causes troubles.
2013-10-03 15:39:59 +02:00
Marc Delisle
6aa99438d0
Fix typo
2013-10-03 05:52:51 -04:00
Michal Čihař
785c33261a
We no longer minify the code
2013-10-02 14:12:01 +02:00
Mohamed Ashraf
ed4771586f
Returned the cache setting to the get_scripts.js.php file
2013-09-05 20:02:16 +02:00
Mohamed Ashraf
918b670207
Changed the way scripts are loaded from getScript to appending script elements to head
2013-07-31 03:51:33 +02:00
Mohamed Ashraf
f99f448eb6
Added warning to change back the cache setting
2013-06-29 12:45:19 +02:00
Mohamed Ashraf
3541a6d2b5
error reporting now respects settings
2013-06-24 15:38:13 +02:00
Rouslan Placella
9f8de95316
Fixed path for Windows machines
2012-12-19 13:10:36 +00:00
Rouslan Placella
44c12545fc
Generate a single js file server-side for any number of requested files
...
IMPLEMENTS feature request #3583340
2012-12-19 13:10:36 +00:00