gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
109,918 Commits 12 Branches 481 Tags 2.4 GiB
QA_4_7
Commit Graph

3459 Commits

Author SHA1 Message Date
Michal Čihař
3fe1e5a625 Use python 3.6 to build docs 
It fixes SNI issues.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2018-02-22 23:38:20 +01:00
Michal Čihař
fc378b0bd3 Adjust table operations to use POST 
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 6b5d535da5)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-22 16:01:00 -03:00
Michal Čihař
6f4740e17c Always use POST for links containing SQL query 
This way the SQL queries will not apper in the web server logs.

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 99e9854473)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-22 13:36:20 -03:00
Michal Čihař
f31dfc530b Add tests for Util::linkOrButton 
Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 816c42665a)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-22 13:17:25 -03:00
Maurício Meneghini Fauth
c75166c3a9 Revert "Force using POST for SQL query in Util::linkOrButton" 
This reverts commit 44df4a3094.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-22 11:44:06 -03:00
Michal Čihař
5503abe53a Merge remote-tracking branch 'security/QA_4_7-security' into QA_4_7-security 2017-12-18 11:49:44 +01:00
Michal Čihař
44df4a3094 Force using POST for SQL query in Util::linkOrButton 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-18 11:46:57 +01:00
Michal Čihař
39b8020857 Fixed displaying of formatted numeric values for some locales 
The code was wrongly assuming that . is always decimal separator, what
it is not and can be even thousands separator.

Fixes #13865

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-15 11:05:54 +01:00
Michal Čihař
edd929216a Bring back token validation to GET requests 
This is necessary to avoid CSRF on SQL queries. This is really more a
short term fix, proper fix (to be implemented in master) is to avoid
accepting SQL queries from GET requests.

This reverts commits:

* dae3390a02
* ea73fded71
* 90433788d6
* f797a8d87d
* 9c1cfc8553

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-14 17:27:22 +01:00
Michal Čihař
48b95ece85 Adjust tests to new attributes 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-04 15:34:56 +02:00
Michal Čihař
108ea3dd3d Adjust tracker tests to new export code 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-21 12:59:38 +02:00
Michal Čihař
c40a1d1a5d Adjust tests to changed API usage in SQL export 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-21 12:49:43 +02:00
Michal Čihař
f753654ac8 Fixed edit variable link in advisor 
Fixes #13561

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-06 07:56:25 -04:00
Michal Čihař
1848826532 Add another test 
See #13522

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 14:32:00 +02:00
Michal Čihař
738b35b4ec Avoid runkit installation on PHP 7.2 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 08:54:42 +02:00
Michal Čihař
76e0e6dbc8 Implement Countable interface in OptionsPropertyGroup 
This is really needed in OptionsPropertyRootGroup, but makes sense here
as well.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 08:54:42 +02:00
Michal Čihař
b188c18fb0 Fix mocked return value 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 08:50:26 +02:00
Michal Čihař
456ec18cb1 Add missing mock 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 08:50:26 +02:00
Michal Čihař
53613a402c Add missing mock 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 08:50:26 +02:00
Michal Čihař
e85fc1cdff Fix mocked value 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-01 08:50:26 +02:00
Michal Čihař
b7788850a9 Fixed usage of some browser transformations 
Fixes #13478

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-18 14:18:02 +02:00
Michal Čihař
a4ec378179 Move spacing around buttons to Util::getMessage 
We really do not want to add spacing around all buttons, just the ones
in the SQL message.

Fixes #13445

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-09 10:50:22 +02:00
Michal Čihař
6c42802118 Fix DarwinSSL detection 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-28 18:41:46 +02:00
Michal Čihař
949a74d4d5 Skip CURLOPT_CAPATH and CURLOPT_CAINFO tests on unsupported platforms 
These flags are not supported on some of the platforms, see
https://curl.haxx.se/docs/ssl-compared.html

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-28 18:31:22 +02:00
Michal Čihař
49c963542d Add tests for both paths in curl 
Test both CURLOPT_CAPATH and URLOPT_CAINFO setup.

Fixes #13398

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-28 15:41:47 +02:00
Michal Čihař
bf3c6c6145 Merge remote-tracking branch 'origin/pull/13402' into QA_4_7 2017-06-28 10:47:32 +02:00
Michal Čihař
b9f1eb0296 Use better description for multi-level collations 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-28 09:56:37 +02:00
Isaac Bennetch
0d961951be Use non-breaking space entity instead of newline in the links on the browse page. 
This prevents awkward breaking of the link which would otherwise wrap on small screens like:

[ Create PHP code
]

which looks particularly bad on mobile devices.

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2017-06-22 01:06:50 -04:00
Michal Čihař
14f738c262 Show only supported charsets for conversion 
Fixes #13388

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-15 16:26:54 +02:00
Michal Čihař
358d2fd1f1 Rewrite export alias defining 
The old code did load all colums for all tables in all databases in
export. This can easily explode for server wide exports or exports on
database with lot of tables.

It has been rewritten in a way to load required data on demand from
server. This will make aliases defining slightly slower, but I think
it's acceptable price for making the export work on larger databases.

Fixes #13008

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-13 17:02:45 +02:00
Michal Čihař
3fe6c862a6 Adjust tests to scripts loader change 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-08 16:15:54 +02:00
Michal Čihař
a586c8ca4f Ensure we reset locales back to English after running tests 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-01 14:29:08 +02:00
Michal Čihař
61b9418f67 Add tests for Amazon RDS 
Issue #13258

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-05-09 15:02:13 +02:00
Michal Čihař
031d379bdc Rewite collation naming code 
Rewritten to use level based parser instead of hardcoding ordering. This
is necessary as MySQL charset naming got even more complex with MySQL
8.0.

Fixes #13216

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-28 16:04:27 +02:00
Michal Čihař
8d6b1dce57 Improved handling of logout with disabled LoginCookieDeleteAll 
- avoid removing session for cookie auth if LoginCookieDeleteAll is
  disabled
- redirect user to other server rather than to login page
- show message about partial logout
- adjust tests
- this is based on #13221

Fixes #12301

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-28 16:02:11 +02:00
Michal Čihař
13d3398ec9 Adjust tests to make them output neutral 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-30 14:31:46 +02:00
Raghuram
ebc935a915 Fixes retrieving tables names from nested $table_list array in tracking 
Fixes #13029

Signed-off-by: Raghuram Vadapalli <raghuram.vadapalli@research.iiit.ac.in>
 2017-03-13 09:18:31 +01:00
Michal Čihař
a6a917e262 Remove github from tests 
We no longer access it directly.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-06 13:42:48 +01:00
Michal Čihař
ce9ca75555 Avoid skipping tests on hhvm 
They seems to be quite slow on later versions, but work.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-02 10:20:22 +01:00
Michal Čihař
27bebd75bd Fix parameter name 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 22:19:26 +01:00
Michal Čihař
16567c6b2b Do not rely on xargs 
It does not work as expected on OSX.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 18:46:17 +01:00
Michal Čihař
6ad9436394 Simplify installation 
The upgrade does not seem to work anyway.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 18:19:34 +01:00
Michal Čihař
3fdf343899 Use installed pip for better caching 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 17:48:08 +01:00
Michal Čihař
2b42777cdf Leverage pip cache instead of using apt packages 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 16:57:26 +01:00
Michal Čihař
2fea612791 Simplify code for skipping not supported PHP versions 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 16:53:23 +01:00
Michal Čihař
4f37569773 Do not use ant on Travis 
It is just additional overhead without real benefit.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 16:51:06 +01:00
Michal Čihař
bdaab73967 Squeeze lint into test build 
- the setup costs are quite high, so do both steps at once
- lint only changed files
- always generate locales for tests to simplify code

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 16:49:40 +01:00
Michal Čihař
b7a87ce156 Adjust tests to new column selection code 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 15:57:18 +01:00
Michal Čihař
a72a048f1e Correctly handle case when CURRENT_USER() fails 
It's not likely, but the code path was obviously returning wrong value.

Maybe it did happen in issue #13037

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 10:53:19 +01:00
Michal Čihař
bb95ecf852 Extend Dummy driver to be able to inject expected queries results 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 10:52:37 +01:00