Commit Graph

84 Commits

Author SHA1 Message Date
Michal Čihař
aea2a28974 Make the string look like an error message
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 17:05:45 +01:00
Michal Čihař
308c9d7951 Simplify Response object handling
- always use use and short name
- avoid calling getInstance() several times in one script

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 18:17:59 +01:00
Deven Bansod
d46a5f5863 Check if '@' exists before exploding over it and assuming it exists always
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-02 11:55:05 +05:30
Deven Bansod
e3e51db544 Merge branch 'QA_4_6' 2016-07-23 15:46:21 +05:30
Deven Bansod
622a6f2389 Fix #12394 : Create view should require a view name
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-07-23 15:07:54 +05:30
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Deven Bansod
0882bc7f6d Fix correct class name. Use namespaces
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-01-15 03:18:27 +05:30
Michal Čihař
f22ea96616 Merge branch 'QA_4_5' 2016-01-07 11:33:27 +01:00
Michal Čihař
6de48ce8c1 Fix creating/editing VIEW with DEFINER containing special chars
Fixes #11826

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-07 11:32:51 +01:00
Hugues Peccatte
ffc4422db7 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-19 20:33:21 +02:00
Hugues Peccatte
6f4676cdfc Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-10-04 18:04:49 +02:00
Marc Delisle
fd7c8522ea Clarify method name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-03 10:14:29 -04:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Hugues Peccatte
a1cf9a24e3 Coding style modification.
Make PHPCS happy.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-22 22:08:24 +02:00
Madhura Jayaratne
7f3fa4c857 #4947 Editing a view gives errors - Included file no longer exists and its methods has been moved else where
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-08 14:40:17 +05:30
Madhura Jayaratne
6041162040 Do not use configurations TextareaCols and TextareaRows of their intended places.
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-25 14:51:31 +05:30
Jason
ce3c8b0c66 Refactoring tbl_view.lib and add PMA\Template
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-05-15 03:48:25 +08:00
Madhura Jayaratne
05c8553345 Max length for view names
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-23 13:17:24 +05:30
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Marc Delisle
65d46038af Cannot create view via Query results operation (master only)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-11-05 12:59:42 -05:00
Hugues Peccatte
42e0bdd47a Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 18:32:42 +01:00
Marc Delisle
a8d948895e Fix code execution path warning
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-05 17:38:23 -04:00
Dhananjay Nakrani
bfef3e80df Remove unnecessarily added empty lines.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
9a1fb901d0 Remove included 'common_error_reporting.php' script and its inclusion from all the scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e9d5523795 Include error reporting script at the end of all the 'relevant' scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
bf8bb147e4 Various coding style fixes 2013-08-06 16:04:11 +02:00
Kasun Chathuranga
d61fe0fe8c Fix typo 2013-07-12 10:49:58 +05:30
Kasun Chathuranga
784121514f Nowrap for labels 2013-07-12 10:32:19 +05:30
Kasun Chathuranga
c625e93440 Wrap some long lines 2013-07-12 10:20:09 +05:30
Kasun Chathuranga
e1ec1d24ce Allow setting view name only when creating a view 2013-07-12 10:12:27 +05:30
Kasun Chathuranga
f2e214247c Use Codemirror editor for view editing 2013-07-12 09:56:01 +05:30
Kasun Chathuranga
06e1ff3b2a Fix typo 2013-07-12 09:36:01 +05:30
Kasun Chathuranga
bee4c42060 Go back to tbl_structure page after editing a view 2013-07-12 09:26:08 +05:30
Kasun Chathuranga
05b5f0a284 It is illogical using 'TextareaCols' configuration here. Default values give a very small text area to edit the view 2013-07-12 09:24:55 +05:30
Kasun Chathuranga
f498b59af7 Fix syntax error in generated sql. Add required hidden inputs to properly execute view creation 2013-07-12 09:08:26 +05:30
Kasun Chathuranga
846ead2f90 Fix typos 2013-07-11 18:35:09 +05:30
Kasun Chathuranga
a2c36a55bd Add sql security field 2013-07-11 16:02:02 +05:30
Kasun Chathuranga
18dfc07367 Add definer field 2013-07-11 15:20:59 +05:30
Kasun Chathuranga
5621d85e36 Use ajax dialog for view editing 2013-07-10 14:53:54 +05:30
Kasun Chathuranga
d5a531f7b3 Match UI style of trigger, routine etc AJAX dialogs 2013-07-10 11:40:33 +05:30
Kasun Chathuranga
ce5c6e9e52 Use a drop down as only one check option can be selected. 2013-07-09 10:52:21 +05:30
Dieter Adriaenssens
e30a399398 Merge commit '3311c6f'
Conflicts:
	view_create.php
2013-05-31 15:58:45 +02:00
Dieter Adriaenssens
9b3551601c escape query in error message 2013-05-29 21:13:32 +02:00
Madhura Jayaratne
650a8cdda3 Convert database interface to a class 2013-05-24 17:30:59 +05:30
Kasun Chathuranga
d933575811 PMA_DBI_try_query --> PMA_DBI_tryQuery 2013-04-30 23:05:18 +05:30
Dieter Adriaenssens
dd8cdd3958 improve coding style : remove mixed php and html 2013-01-21 21:55:31 +01:00
Chanaka Indrajith
6971295e96 Renamed PMA_CommonFunctions::getInstance()-> with PMA_Util:: 2012-09-16 14:41:47 +05:30