gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
115,271 Commits 12 Branches 481 Tags 2.4 GiB
QA_4_9
Commit Graph

72 Commits

Author SHA1 Message Date
William Desportes
313da618bd
Fix redirection form secure.php.net to www.php.net 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 11:03:10 +01:00
William Desportes
3f9ac1dc98
Fix engine can be null 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-23 00:05:55 +01:00
William Desportes
97ccafa06a
Add a message for misconfigured designer (displaywork) 
- When adding a column as display column in designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-20 12:30:14 +01:00
William Desportes
770f30aa86
Fix display field in Designer 
Introduced by: a23f2ba51a

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-20 12:29:07 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible 
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 12:02:54 +01:00
William Desportes
4ae14a3da9
Improve l10n context for translators and fix a typo 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-09 15:35:59 +01:00
Maurício Meneghini Fauth
1a2cef1ae1 Fix some coding standard issues detected by PHPCS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-21 09:57:06 -03:00
Sergi L
602cf50e52
Text-area-overflows-parent-element 
Signed-off-by: Sergi Linares <sergi_linares@outlook.com>
 2019-10-17 23:21:24 +02:00
Maurício Meneghini Fauth
0a8fc4446b Fix some invalid array accesses with PHP 7.4 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-21 17:22:52 -03:00
William Desportes
58f56111df
Fix reloading a designer page 
- Added cast to be sure pageNumber is an int -1 or postitive

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-09-08 11:40:13 +02:00
William Desportes
6d0f3083ca
Fix display field can return a boolean 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-23 12:15:21 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names 
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-23 00:55:41 +02:00
Hugues Peccatte
de57539fb7 Build "tables list" in JS 
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-21 00:01:17 +02:00
Hugues Peccatte
14ba5a1b24 Retrieve DB instead of relying on current one 
When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-20 22:23:35 +02:00
William Desportes
5566aa6976
Fix #15228 - Notice - Undefined index: foreign_keys_data 
Fixes: #15228
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-26 23:45:20 +02:00
William Desportes
a80785198d
Fix #15141 - php notice Undefined index: designer_settings 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-01 16:12:24 +02:00
Madhura Jayaratne
d676d6941f Issue phpmyadmin-security/267 SQL injection in Designer feature 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-12-26 22:48:47 +11:00
Madhura Jayaratne
048670f1a5 Merge branch 'QA_4_8' into QA_4_8-security 2018-12-07 16:33:18 +11:00
William Desportes
cc2b1c8b99
Fix #14352 - JavaScript errors with Designer 
Closes: #14352

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-30 11:29:31 +01:00
William Desportes
18c23df20f
Issue #13032 - fix designer on QA_4_8 
Used cherry-pick : Merge pull request #14376 from williamdes/issue-13032-designer

Cherry-picked-from: cb2dae58be

Issue #13032 - fix designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-29 20:19:02 +01:00
Maurício Meneghini Fauth
0be9a53fcf Retrieve parameters from $_POST in db_search.php 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
6c03ebad38 Retrieve parameters from $_POST in database QBE 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
9fc76f9215 Add secondary tabs for database query 
Fixes #13621 QBE selenium tests broken since merge of #13342

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-10-31 21:52:54 -03:00
William Desportes
56d59a9d67
Fixes #14223 - designer error 
See: https://github.com/phpmyadmin/phpmyadmin/issues/14223#issuecomment-429312975
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-10-12 15:01:30 +02:00
Maurício Meneghini Fauth
ca7fd2b2c7 Fix case where 'query' is always considered defined 
Related to #14079

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-03-27 18:44:28 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods 
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-27 17:39:16 -03:00
Maurício Meneghini Fauth
c7f3d6e4e6 Rename $GLOBALS['PMD'] to $GLOBALS['designer'] 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-24 17:45:48 -03:00
Maurício Meneghini Fauth
f21bc9668d Replace static methods with instance methods 
Replace PhpMyAdmin\Database\Designer\Common static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-24 16:39:53 -03:00
Maurício Meneghini Fauth
7f62eef8a7 Rename PmdCommon to Database\Designer\Common 
Rename PhpMyAdmin\PmdCommon to PhpMyAdmin\Database\Designer\Common.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-24 16:14:44 -03:00
Maurício Meneghini Fauth
ce42c68823 Fix some coding styles issues 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-23 12:06:54 -03:00
Maurício Meneghini Fauth
92beb1a4f4 Replace static methods with instance methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-22 23:58:41 -03:00
Madhura Jayaratne
06d20fb47a Proper fix for the xss issue 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-02-08 00:32:35 +11:00
Maurício Meneghini Fauth
f9e4a1c6af Use template for getSearchResults method 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-17 03:49:55 -02:00
Maurício Meneghini Fauth
aa48445e9a Use template for getSelectionForm method 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-17 03:49:55 -02:00
Maurício Meneghini Fauth
fe91ba10f8 Remove underscores from methods and properties names 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-17 03:49:55 -02:00
Maurício Meneghini Fauth
0e82a5e83e Use template for getResultDivs method 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-15 15:44:36 -02:00
Maurício Meneghini Fauth
3010b27bab Use template for _getResultsRow method 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-15 11:43:35 -02:00
Gabriel Caruso
a8bd364e02 Clean elses 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
 2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
b996919c47 Move query results logic into MultiTableQuery class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 23:01:31 -02:00
Maurício Meneghini Fauth
fc08cca15b Refactor getFormHTML method 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 21:55:41 -02:00
Maurício Meneghini Fauth
45de599d79 Move columns template into form template 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 18:05:39 -02:00
Maurício Meneghini Fauth
a76fb00ce6 Refactor Database/MultiTableQuery to use DI 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 17:20:27 -02:00
Maurício Meneghini Fauth
41dfe10efe Use template for getFormHTML 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 16:13:53 -02:00
Maurício Meneghini Fauth
c82669ba57 Use template for getColumnsHTML 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 15:57:13 -02:00
Maurício Meneghini Fauth
608242662d Make Multi Table Query strings translatable. 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 13:15:56 -02:00
Maurício Meneghini Fauth
1f98dcf1c2 Fix designer not showing table column information 
Fix #13809

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-12 02:11:47 -02:00
Maurício Meneghini Fauth
3eed95aba0 Use template for _getFootersOptions 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 22:39:03 -02:00
Maurício Meneghini Fauth
3a00dc7d0a Use template for _getSortOrderSelectCell 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 22:11:06 -02:00
Maurício Meneghini Fauth
6c90b384f7 Refactor _getSortSelectCell 
Move 'selected' html to template.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 12:48:17 -02:00