Commit Graph

10 Commits

Author SHA1 Message Date
William Desportes
e3f4a57aa6
Fix #14321 - leaked HTML on auth_type=signon before redirect occurs and on error page when SignonURL is not set
This fix also fixes the display when SignonURL is empty at configuration time.

When the user was redirected there was HTML in the output that could leak some interesting details about the server or the user.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-25 01:36:36 +02:00
William Desportes
80a7f0a75c
Make the hmac secret a secret for the user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-13 19:05:04 +02:00
William Desportes
47c3f131b4
Fix #14412 - AuthenticationSignon.php's showFailure function does not consider SignonCookieParams
Fixes: #14412
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-05 13:48:29 +02:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Michal Čihař
8e8f4bd3bb Avoid using PHP_AUTH_USER and PHP_AUTH_PW globals for auth
Use object attributes to store the actual credentials and avoid
messing up with global variables.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00
Michal Čihař
62535ea5b9 Pass failure reason to showFailure
This way we can avoid relying on global variables to check it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00
Michal Čihař
026d722178 Rationalize AuthenticationPlugin API
Make the API more consistent, remove not needed auth prefix and stop
talking about advanced authentication which has been there about 10
years ago.

API changed:

- authCheck is now readCredentials
- authSetUser is now storeCredentials
- auth is now showLoginForm
- authFails is now showFailure
- storeUserCredentials is now rememberCredentials

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
56c1c9fc5c Share base code for AuthenticationPlugin::authSetUser
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
4a83171c30 Merge branch 'QA_4_7' 2017-08-01 09:09:19 +02:00
Maurício Meneghini Fauth
2631bcedba Move plugins classes to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-20 11:50:12 -03:00