Commit Graph

61 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
6f0d19f394
Do not encrypt params if used in data-post attribute
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 12:19:43 -03:00
Isaac Bennetch
3258978c38 More escaping of username and password.
Improves upon 89fbcd7c39

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-18 22:16:53 -04:00
Maurício Meneghini Fauth
89fbcd7c39 Escape user and hostname when getting auth plugin
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-05 20:10:13 -03:00
William Desportes
c86acbf3ed
Fix sql injection in user exists request
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-01 13:55:06 +01:00
Maurício Meneghini Fauth
aced4e1bb4 Remove fieldset close tag when setting global privs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-28 17:20:19 -03:00
William Desportes
a0bf9b50d1
Fix PHP 7.4 deprecation: accessing offset on null/bool
Pull-request: #15405
Ref: #15412
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 23:38:29 +02:00
Kartik Kathuria
fd1bcc2415
Fix #15202 - escaped correctly password
Fixes: #15202
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-08-15 20:27:58 +02:00
Jack Cherng
b89c17c7d7
Fix PHP 7.4 accessing offset on null/bool
null['xxx'] or false['xxx'] emits a notice in PHP 7.4.

Problematic pages:

- phpMyAdmin/db_tracking.php?db=DB_NAME
- phpMyAdmin/server_privileges.php?adduser=1
- some other pages using POST method...

0e6e2297fc/UPGRADING (L25-L28)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-07-27 09:14:13 +08:00
Jack Cherng
b989e825e1
Fix PHP 7.4 deprecation: array/string curly braces access
Deprecated: Array and string offset access syntax with curly braces is deprecated

0e6e2297fc/UPGRADING (L356-L357)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-07-27 08:34:16 +08:00
William Desportes
3027f0ef49
Fix #13726 - Can not copy user on Percona Server 5.7 (password copy)
Fixes: #13726
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 11:03:39 +02:00
William Desportes
1f0e34ad07
Add ; at the end of SET old_passwords
Why ? : because all other queries have ; at the end.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 09:54:42 +02:00
William Desportes
49874c4e28
Fix #13726 - Can not copy user on Percona Server 5.7
Fixes: #13726
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 09:53:57 +02:00
William Desportes
60564b5d92
Fix #14800 #14833 - Sort by Time and show full query on Processlist
Fixes: #14800
Fixes: #14833
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 00:26:29 +02:00
William Desportes
91c758aae4
Fix #15229 - Notice - Undefined index: strPrivDescDelete versioning rowsTbl
Fixes: #15229
Adds support for delete versioning rows privilege
See: https://mariadb.com/kb/en/library/grant/#table-privileges
The privilege is named 'Delete versioning rows' in SHOW GRANTS and 'Delete_history_priv' in mysql.user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 18:42:02 +02:00
Maurício Meneghini Fauth
12f898d871 Fix issue when adding user on MySQL 8.0.11
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 22:23:46 -02:00
Maurício Meneghini Fauth
77bbfec0a9 Remove debug line
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 22:47:10 -02:00
Maurício Meneghini Fauth
a98207c6de Retrieve parameters from $_POST in server_status_monitor.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
30543ad81f Retrieve parameters from $_POST in server_status_variables.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
89db84213b Retrieve parameters from $_POST in server_user_groups.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
79548c0dcf Retrieve parameters from $_POST in server_status_processes.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Madhura Jayaratne
35d87e6072 Retrieve parameters from $_POST in user/Privileges pages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-11-10 20:48:58 -02:00
William Desportes
dc4e6543ac
Fix #14438 - "Show Full Queries" icons
Closes: #14438
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-09-24 19:56:22 +02:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Michal Čihař
1ebf6c4953 Remove references to sourceforge.net issue trackers
We do not use it for years and all issues have been migrated.

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-02 13:24:05 +01:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
529e8c774f Merge branch 'QA_4_7' 2017-11-28 10:57:45 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
79f6f88bff Use template for server sub page header
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Michal Čihař
8fa32adb4e Fix handling of initial letter in privileges
Fixes #13783

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 09:36:11 +01:00
Michal Čihař
aa9da566a6 Define specific_db/specific_table outsite is_grant scope
Fixes #13784

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 09:34:05 +01:00
Michal Čihař
99e47a90d9 Always define correct connection type
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink']
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
60c1b32472 Remove usage of $GLOBALS['userlink']
The links are internal to DatabaseInterface and user link is default.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Maurício Meneghini Fauth
f9dd640c1a Port privileges/initials_row template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-24 23:32:52 -02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:28:00 +02:00
Maurício Meneghini Fauth
f8bd078088 Fix code standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-30 18:19:09 -03:00
Maurício Meneghini Fauth
295e538be8 Move Advisor dependencies to constructor
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-26 22:57:54 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
52a6bc0b06 Port privileges/privileges_summary template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-20 22:42:03 -03:00
Maurício Meneghini Fauth
ce4d28ab32 Port privileges/global_priv_table template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-20 21:27:53 -03:00
Maurício Meneghini Fauth
f49f94a62d Refactor sysinfo functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-14 17:51:33 -03:00
Maurício Meneghini Fauth
dcedb418dc Refactor replication_gui functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-13 16:00:40 -03:00
Maurício Meneghini Fauth
99642bf6e2 Refactor select_server functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 23:12:28 -03:00
Maurício Meneghini Fauth
15d8ee270f Refactor relation_cleanup functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 18:14:37 -03:00
Maurício Meneghini Fauth
f7051b2e5c Refactor server_common functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 00:28:06 -03:00
Maurício Meneghini Fauth
4022337194 Refactor server_user_groups to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 00:12:59 -03:00
Maurício Meneghini Fauth
8c41df5103 Refactor server_users functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 23:45:39 -03:00
Maurício Meneghini Fauth
94fa5946ce Refactor server_status_variables to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 22:43:16 -03:00
Maurício Meneghini Fauth
dfbea9648f Refactor server_status_queries to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 22:18:35 -03:00